From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22D2DC4332F for ; Wed, 13 Dec 2023 06:28:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A08708D0017; Wed, 13 Dec 2023 01:28:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B7B18D0015; Wed, 13 Dec 2023 01:28:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CE6B8D0017; Wed, 13 Dec 2023 01:28:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7ECFC8D0015 for ; Wed, 13 Dec 2023 01:28:43 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5554B40B4D for ; Wed, 13 Dec 2023 06:28:43 +0000 (UTC) X-FDA: 81560816526.15.2378E82 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP id 4491C20008 for ; Wed, 13 Dec 2023 06:28:40 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=0JFtG3rY; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf13.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702448921; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5cpCdGFyNgIm+UuGHcpqgky39S6rpy1muJgHd40gq4E=; b=cPtlGFYsiq6lIzAbw8Y43WnY8AVGLD1CloOiJqu1EKS0k3EnVKXjlwX+/HfOiXTHFR9q1W N+wqPV1rlFSx88HiOeCu41uMr4o/jlN6+GqESDrtFS6RwZCcsaEw602KXErFzzhO+Eiaum 1NZPy5UE8SZE0cGmZugfvvqMt637BeQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=0JFtG3rY; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf13.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702448921; a=rsa-sha256; cv=none; b=lh0LCW8ur6AbWAowOhmV4F7+7cmP/BSwklolMgKh5eB1w4/igBBFvzgUtSKeDDwQItrmWs YWYqfrEcXPwpnoDQ7e9XT14f1qujuMkdAOnWgJ2HjEDuVv21N3iiO1GK2tP4qWkvKi+1NB 1XIFRhnliU+IxuXgkjPlflevx9Sk3hM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5cpCdGFyNgIm+UuGHcpqgky39S6rpy1muJgHd40gq4E=; b=0JFtG3rYmb3+N31e73Nfzt5jOk hlMRraAChCza7PYOR3gdjxLx2S6uOdj4Tq5afLQFR4jJjD7E3QX0Q3r1Gu77jLDuGqXHIbUngZtiI 2ns4cUR95M1M7xpBqVisLNiVZ0XEvQ9C+kHT+u4uozyRZJRxjSgmpSHpOSms2IXwW/Y5O+rrtqtSi 2SjMOB/VomMZLYQcd5C7FoTRNR8SfARBi39rsS4Jqcog+mrLiZ4JR3Qw294Zf6gIV60Y8jDJu5ZNE BBndfGY5kBuA7ZB6ZPNVZZa5O+G/V66WGPjtagQfyEEOxHJOz/0COLivSg6wZ/vWYJrRmelNYOx5O zoBqt3bA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rDIjU-00DmLA-07; Wed, 13 Dec 2023 06:28:36 +0000 Date: Tue, 12 Dec 2023 22:28:35 -0800 From: Luis Chamberlain To: Palmer Dabbelt , Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: alexghiti@rivosinc.com, lkp@intel.com, linux-mm@kvack.org, linux@weissschuh.net, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev Subject: Re: [PATCH -next] drivers: perf: Fix build error by adding const to ctl_table argument of handler Message-ID: References: <20231207083512.51792-1-alexghiti@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4491C20008 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: wx3j6zqiea5wj9qtuiknmqcjdok59jnf X-HE-Tag: 1702448919-241289 X-HE-Meta: U2FsdGVkX1/M5fcuB9ru0zRR9QCEfwtEU/j9wywub27t4RmUvBEyfwEbwpELNCbD6uL/ThV+1RR6uqd/Gg3ElvprCHUawt+RHKjnEJT06I2NzuDFUTq2y635W6f3lF8VmQYZ3HOuVW/m+EiMvLWuY+EGmg2fAHuFwhhSa7PWYTlo7fQmI5iXzeRPZvZGchsRVDcKuBMmPLyQ30vMyiUE9KoX1ziMr3ECGMiiKcJnPwqKUZeHKmUHc9Ump9+Wox/1PeLHLExwCgrRrDQ5MZexEX3ACkTHE2Ahq9G61nRaMYDDTlwFN+PJRVfwRYQlfYUBoyEAq5RVlxLBjc92ua4WAO9sT3r10QhldYNGzqB3WmWW+NsP3N5Dz76QNom9t0luFzSfr1akc6moGWQ1ZsJ3xasyakiNv0eUTQw24guyA0L4GzP7wx/YUVCtvg7q6JPlnI+7l/czdGy0yhcBX3OVsCN2hrqpYYxuzEJ1FCsRE4RHtt1TLMdeFgziDgQ/f+tEo9I44aaN6uAqymDOuOEaxA7X0IJj9s0qCKLAxpU9D9tMlJ+Fg/nGJ6dn83ALtRODyDTxCqxuDPHpOIagg5jLqnRgqEOt0KXvDnROMVdhVpBIZbLpirhXZnAg1nxeVXOwh9ig+kIGWQM5PovKo1SIPIZZW+QKX56jQJQnw35TQc5l3osekRNMBiVpJN7IiFgxt61t8KpOxnnEdYrB39ywZyko0FeSvlbqHcjWmEXUsFC0/OO19x52rFPGmwj4E1tEjRn21dpZQASVSd2HL3uoWRtmd0z/sMo3rHkBLydStJEQqb9kyX+LVtis6NkZTKvjT5RGVV6FmsRC0zVUKU4RnWhvhurHlYr+ApccsUqFXbB8Rp548CAaJ0JV31xECZ+rsAruY4Vd78pVPbiO9Zk+krqNVj+CeIvwS5iCuLeqqnbRBCPutdgpVWcW6IcMiEFPqNhJwhUoBoWMQlDUG9H /GGmOFga b8I2+rTJp05lVDwELq0+xBZl6KsoPgdigw4r2Vz9yKFCqG1aBrBhuhkve0dNxk7ewh90NXVxkm07XegMN2gwB90N+on+PokNaIWogbLvzgJb+qnD4a+EMgrS3s/L2FH6Vim3jUeDkM9NCzrndq2t0rrsspU+Fow5Cn2Hk7cB5RtAwZKPwclX9SOOyZr8C7So/uw+AGAkmgwCRWmBKpPkArfbZYNJeo85FAsOacEjreqD2LljAzs0jsXWECD8HrJ/UN6kG0ZX67QxFG/Ibquv3KBZTaEswc+8PgSwoOZRllsn52wpW5NJVrLvPUQY2OBvzyXQ9KV+EiRGiVShuSRbJKEvqOEijhCMnGp5xFsSbZeAX7QR5GTYwzDDF58HkofM16klXxjzXwsUuSRJpO1+Qdria97fOl559+9YY2ZJ2Ir0fQdpjphsQB3QCcg+c3Y3to9uTNbTKbZ0gkrFeO5Eg+8wc2ERy99zpi6f+tkJMmyFIuOl89Sh45Ojc6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 12, 2023 at 01:04:41PM -0800, Palmer Dabbelt wrote: > On Thu, 07 Dec 2023 00:35:12 PST (-0800), alexghiti@rivosinc.com wrote: > > The ctl_table argument of the proc_handler field was constified treewide > > but somehow missed the occurrence in the riscv pmu sbi driver, so add the > > const to fix the build error. > > > > Reported-by: kernel test robot > > Closes: https://lore.kernel.org/oe-kbuild-all/202312062242.RFPPozG9-lkp@intel.com/ > > Fixes: c8be9e66ca1e ("sysctl: treewide: constify the ctl_table argument of handlers") > > Signed-off-by: Alexandre Ghiti > > --- > > drivers/perf/riscv_pmu_sbi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/perf/riscv_pmu_sbi.c b/drivers/perf/riscv_pmu_sbi.c > > index 16acd4dcdb96..97e345f7d25d 100644 > > --- a/drivers/perf/riscv_pmu_sbi.c > > +++ b/drivers/perf/riscv_pmu_sbi.c > > @@ -986,7 +986,7 @@ static void riscv_pmu_update_counter_access(void *info) > > csr_write(CSR_SCOUNTEREN, 0x2); > > } > > > > -static int riscv_pmu_proc_user_access_handler(struct ctl_table *table, > > +static int riscv_pmu_proc_user_access_handler(const struct ctl_table *table, > > int write, void *buffer, > > size_t *lenp, loff_t *ppos) > > { > > Reviewed-by: Palmer Dabbelt > Acked-by: Palmer Dabbelt Same here, Thomas please fold into your series as you are working on a new series. Luis