From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B17B3C4332F for ; Wed, 13 Dec 2023 04:37:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EAB66B0461; Tue, 12 Dec 2023 23:37:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 19A2C6B0462; Tue, 12 Dec 2023 23:37:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 061F66B0463; Tue, 12 Dec 2023 23:37:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E90896B0461 for ; Tue, 12 Dec 2023 23:37:53 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C033D40916 for ; Wed, 13 Dec 2023 04:37:53 +0000 (UTC) X-FDA: 81560537226.05.A4EA440 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id B2240A0013 for ; Wed, 13 Dec 2023 04:37:51 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kDRgRotY; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702442272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iONKais+u1NSpiFMEhAO3HpUZJHMM2QwLL4fbRhsT/Q=; b=a5DgS0t1fgT2tB9gJlbktKE6ZZHr57KCbhC19uq3uML3u9PmmB6d8gZ9jLA3zazJlRrA1O OhnXPbiVlAA18obl9ciyq3PUqOZqCG3/yDiAxJqOomiC2ToX42674WoAPaHlheFT0Vfvoj sht/SDD+DIqOKoNsFIO7SHYkYDZrO/c= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kDRgRotY; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702442272; a=rsa-sha256; cv=none; b=N6HkdwAvjTXeI+48JWIUAw2wFUHcM4XmVZTKro+LtV/xOWvV2hqtFQSKYR0AhDCN0pJZNn SPO8VCpw5E6mMSeir/Z9yFivUHCo8af7sYiOgAwt5fweS4gj3ItOFy78G25QvHHriMhaYg orBARdctW+N+qebaM41AfvWxJbx7blo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=iONKais+u1NSpiFMEhAO3HpUZJHMM2QwLL4fbRhsT/Q=; b=kDRgRotYaBxlFruwbWSkk7hZek 3V1m7zmFj0wG7VlHMiUwEWMjnAYrUFO2ZjeTz5V6GqDHhBe6nEP/6WZyS7d0GsFpVtPk8UsO6bxe1 TRppQoVJXXTvNMc+uaQ9BevDmHIC5hyPtHhn5dEFOqMdeA1wMOCNmYCclbtOMWI8OxYhKXINaQ+Jt u0agR6Rsd2TjfAZrqjOR3jgWYwe3a2P75cIk+/v7rBNMY7FlON2Yqq22GSGOqWTWrt/vYJMAgrQ1r VaU+faVWCy3MhC0kpN/VV9Ev23nuL1b41u4rVWlwnEQCQtgfxxGKYuH2o97mUCYZjLNYt16XrK9Vq 3jaL+dyg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rDH0H-000iEC-Kc; Wed, 13 Dec 2023 04:37:49 +0000 Date: Wed, 13 Dec 2023 04:37:49 +0000 From: Matthew Wilcox To: Qu Wenruo Cc: Linux Memory Management List Subject: Re: Would it be possible to add FGP_FIXED_ORDER for __filemap_get_folio()? Message-ID: References: <96124b9e-edff-4cd3-9d03-dcabbb4ed141@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <96124b9e-edff-4cd3-9d03-dcabbb4ed141@suse.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B2240A0013 X-Stat-Signature: pbyxcbb6qit3dynq3bgy3xwqsgimifkx X-Rspam-User: X-HE-Tag: 1702442271-132182 X-HE-Meta: U2FsdGVkX1+Uso1NadDnxc7ESIC7EG03ndwUsXXXlV9Lj7x/XnstM12hmG+rYlbUDmITcC4tPSom8J+FHmve9sGgg5ycZ7L1DUwk37eRt0lDF5pPuEYXtjlrADrkIEa2nGHlz3pUUsInuJfe7TwiEd/IaazuFPqLDRoTtbuX3t7NK+WZeUjRphCK6ITFVn9o2x+PzAyAA2G6bBc6rTJhz+KWaO6FmbNpMiQXPWP7uRERC6QcNHcH+HeUcVckVb8Py8uMnOAIovH20ERi5Og5QDIyIjNswnRkOsaVDxNVsegGTas8HdxZjp0XCjlBR5UHFVRU0dCFOf+8vzup+gqTr4llj2mMCbR8b3c3ZfawZwqO1YHvq+t8QqXyaBdg/88tnF41SGY5QJxsBC4tmGJ4Y2Z2omI5w9L4OPaELwS7vPr8n6VAcQT8ynn/G/epm/pYRqtNox1KBmWcvUXsdIPFrMD0G7b11GjpIc6r/3aRgq94FUvS1fOHQbuV5KEFtKDBindU5GbtCwV6GdWcTtUaVtNXupUF02Bzs6lRCXow+0dF6V9Jsv4OcVyEqaWUiUjMIIExhR5Q83jzWDeFA/A5sQtWeGg9kiyqtF2k/Eqs+JyrC/TsDgWXpghKKWmRzuE/JwxRqv0Nsszo3rd+d4/jBwTEtTvZi4TQrW861xnGhyA/G8JzffmyHnrWfCNeIXGnkhA3BSLk7JDUROGH9cCNkeJ3FIefiNmmK4Txy1mAfj2Lf5xg3BsW0koDV0s5eZkJMbgI7C6x/KgP5/S3H2/5NyJg6TSdI9SgX7mDm6OtaRSAHlTtoysvkAK0SiD+l9sTWb9xxFeSLAzFmQGpPgDH5lfekuf4HqQ1eleoj+lcrConUbLu4C8moRUSFL5yA4spHTxgrpzfIl004CKFbCwfnaVyLXhYT2sZAdSlN47SxLBoB5S1bjTU6KwkqAxv+pSgCF1LvVSAMQsiA0krcjM R+QlLs0r FQyWwQeLVZlSCBOs+c+ZsM6rOdf1T3pk4gu4lylEFIMvBRpEarkKG121H3tSgobse3Is8rEsHsN8UdZ9NJhtf+a92Fjxci88YUh5gtF95El3TuHVnU0UCV8glJT6CnbvqMhazwzMVUXg8KaQHS3yikuDeinoVbTQW7HFPPyZ8WFog9WfPjy9sxfeFnfzs0I1eWQt5juiXa4wnbDf2BhF69u3uL7qervi7CawpLiZBV/tlejhk1Mcd+G9H2BBpY+qumYuT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 13, 2023 at 08:52:47AM +1030, Qu Wenruo wrote: > I'm recently converting btrfs (for now only metadata) to go larger (order > > 0) folios, and so far it looks pretty good (can already pass local fstests > runs). > > But to achieve that btrfs metadata is not utilizing __filemap_get_folio() at > all, but manually allocating larger folios, then attaching them to the > filemap. > > This is due to 2 factors: > > - We want fixed folio size > - We have our own fallback path > > The whole idea is go large or go bust, either we got a large folio > matching our request exactly, or we fall back to the old per-page > allocation (the cross-page handling infrastructure is here anyway). In the happy case, are all folios attached to the mapping of the same order? Or might you have one folio of eg, order-5 and another of order-2 because they're different types of metadata? I ask because we have patches out (not merged yet) that allow for setting min/max order, and what you're asking for sounds like it could be accommodated by that.