From: Matthew Wilcox <willy@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: Would it be possible to add FGP_FIXED_ORDER for __filemap_get_folio()?
Date: Wed, 13 Dec 2023 04:37:49 +0000 [thread overview]
Message-ID: <ZXk1Hbv1YHv3i+De@casper.infradead.org> (raw)
In-Reply-To: <96124b9e-edff-4cd3-9d03-dcabbb4ed141@suse.com>
On Wed, Dec 13, 2023 at 08:52:47AM +1030, Qu Wenruo wrote:
> I'm recently converting btrfs (for now only metadata) to go larger (order >
> 0) folios, and so far it looks pretty good (can already pass local fstests
> runs).
>
> But to achieve that btrfs metadata is not utilizing __filemap_get_folio() at
> all, but manually allocating larger folios, then attaching them to the
> filemap.
>
> This is due to 2 factors:
>
> - We want fixed folio size
> - We have our own fallback path
>
> The whole idea is go large or go bust, either we got a large folio
> matching our request exactly, or we fall back to the old per-page
> allocation (the cross-page handling infrastructure is here anyway).
In the happy case, are all folios attached to the mapping of the same
order? Or might you have one folio of eg, order-5 and another of
order-2 because they're different types of metadata?
I ask because we have patches out (not merged yet) that allow for
setting min/max order, and what you're asking for sounds like it could
be accommodated by that.
next prev parent reply other threads:[~2023-12-13 4:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 22:22 Qu Wenruo
2023-12-13 4:37 ` Matthew Wilcox [this message]
2023-12-13 10:03 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXk1Hbv1YHv3i+De@casper.infradead.org \
--to=willy@infradead.org \
--cc=linux-mm@kvack.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox