From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0BD0C4167D for ; Tue, 12 Dec 2023 17:32:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 156EC6B031A; Tue, 12 Dec 2023 12:32:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 106FB6B031B; Tue, 12 Dec 2023 12:32:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F114E6B031C; Tue, 12 Dec 2023 12:32:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E0A506B031A for ; Tue, 12 Dec 2023 12:32:11 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AC389A0A74 for ; Tue, 12 Dec 2023 17:32:11 +0000 (UTC) X-FDA: 81558859662.14.E3F1EBA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 0F047C0037 for ; Tue, 12 Dec 2023 17:32:07 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702402328; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kOPYTeT/Bd53F5cs8I1ekw4aizD+hP16cgFcdY+O5Mo=; b=Wckn7IcnpFWAxW3sGYRz4sKr1CVvd9/TX3V1JlGq3KPzexwgJzblk73H2+7CQE9ZcjJUt1 0IZJU8eUO/WiULa0XvjJMLxNNHzqzchoVpCf0Ch/VcoDZjHS0VD+SJ7u1u34gWfPWr1yNK SoeFDokyRr8HVq3mVMCNvX7OgRwlfQM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702402328; a=rsa-sha256; cv=none; b=U4Zbs9xceFP+21gxt7WqU5giPYhK5BoSHFLRXDrTniS+kdUyrxJJodcyOY3099q44skP1R vNZyDBsoDMEaFgDw56+JJDWsrhSjcuCP+wxxCtWr8IP+YcehjgB1RwXEQ4iSE+T3RWADdL Kzi7gIBWTR/M0jYAz1SRxIgV70bgC/Y= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F111A6184D; Tue, 12 Dec 2023 17:32:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95A85C433C7; Tue, 12 Dec 2023 17:32:01 +0000 (UTC) Date: Tue, 12 Dec 2023 17:31:59 +0000 From: Catalin Marinas To: ankita@nvidia.com Cc: jgg@nvidia.com, maz@kernel.org, oliver.upton@linux.dev, suzuki.poulose@arm.com, yuzenghui@huawei.com, will@kernel.org, alex.williamson@redhat.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, gshan@redhat.com, linux-mm@kvack.org, lpieralisi@kernel.org, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, mochs@nvidia.com, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/2] kvm: arm64: introduce new flag for non-cacheable IO memory Message-ID: References: <20231208164709.23101-1-ankita@nvidia.com> <20231208164709.23101-2-ankita@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231208164709.23101-2-ankita@nvidia.com> X-Stat-Signature: iq7i15owgy3cw5u9qa6noqzf84hfzebb X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0F047C0037 X-Rspam-User: X-HE-Tag: 1702402327-188619 X-HE-Meta: U2FsdGVkX18qBAf6SS2aR0oGsCmMttVrUjgAMTdk/AKhcplf5G+WYhXA2/55Ha8A5+bGk1+HhN3bTVa0KStMn1xTLiLxi26E+6ttVWlMFopVoyMeazbPJbPYOQEQUfEHD8bJcDr8yUNU1lga2hCuhrdzXpihxdx0/A/w3Oe5BWY8PqPOEnThsxxOeqVIuhhnHWemMJ1idOa+NKsPn3pi4iSB+0mxip5iKYgscI2KNSixXf+Ag+lSwRoOGRXBNXQhrGdFR3r3ohNPkcp9F8Cen0vn4Zk7W4fiIhjAwzd8gBOZAqzfRseqFoGE+9BXpuDd+tG/1Bl22RQ428dyHhxdTYN7NwRkp2HyGZL/on23KGEErjLL6JCrpTp+NZe0HGkiTiGBptCd61N7oUamG1ju8Dr5UdEGDRBw6lOvYbZeBbsiIqovC80NlgqZp+nGM+RnggTTtmyh9YWAnTmAtNYi3uCk+Z6/OpwnOxLobRbOwMb4tZMkEC146ZaO/TYCNgbIIfnuknjMinPRVMO3H4g25Q6wlUbTy4ONb3yygIPmMhcAL5dhWWsLuRJYPZi9nK4LmxR+FroGoeybx1RpB4aXtU4alp5ZOOaaeL51GGH4l2z5kHkcWFKK/ZSkgj2IdAJWhL4TVi4X3btkwI12TLvwuHndO333jP9W5RMDeIymtFAkY5pDNp+qJKJdmmoZnfg/q3ogxjrIV0wD6EkpggL2wZu3VfQlRYJi+eVZqWBv/WfN95kK0/oT+BsxTUx5OBMK8TjlpxyLbzaPsdUFjpVx7XWEc52GGzdyvYyoH4O3Igc07h2tVzA8oXgvqp3l63cQ7m6vuhj/OoNCYOzr+jD7Fvlpv1VFTIOcaILUczYKhNkW5LpU8ayMd61PEDBQl4D/oktacMx/bvgRIhqzIjVm6LbNbo/PnYEXTds/e4P5J+Lnf4Kz6AwAbj61kM5zFii3XC8oxlhE9guRhw11mYA D64GYTid PvEbeDvX/hXm5fR3otCR5/ag+PslPuaM0elyIjr6/NeUPEiCMW99TNVF0WBMEaDuuVrPO1B6K/MegL4Z09RxcdwkFUxlEepAQCeWrjSmX+tdzIce7S1twSA6QsmqGNbgBIcXhGtCknIkxAi/IEReuhT9vqVkWafO5wZMqTOpUnHCHF1FvOUq9e1qOw74MKEmuHBlfTx3zUs/YA1aE16P1bsWXBHF7383hy5kpsf5Y5X2IzsCqSITT2hJsIYo7mPpnIctjtaMpEnrpC5u0DquLdMqf6lx0JuoBBGz0FT6DRewcm6hbQEfHv4fQrFv2QXPRvE+8KRUBO3aBJGgZ+2tKvMtwhT+BJSmG18MTddA5qenSc1C2mDeqokfqSvRD9NNVRQ4vsT245f/FpOw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 08, 2023 at 10:17:08PM +0530, ankita@nvidia.com wrote: > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > index c651df904fe3..d4835d553c61 100644 > --- a/arch/arm64/kvm/hyp/pgtable.c > +++ b/arch/arm64/kvm/hyp/pgtable.c > @@ -718,10 +718,17 @@ static int stage2_set_prot_attr(struct kvm_pgtable *pgt, enum kvm_pgtable_prot p > kvm_pte_t *ptep) > { > bool device = prot & KVM_PGTABLE_PROT_DEVICE; > - kvm_pte_t attr = device ? KVM_S2_MEMATTR(pgt, DEVICE_nGnRE) : > - KVM_S2_MEMATTR(pgt, NORMAL); > + bool normal_nc = prot & KVM_PGTABLE_PROT_NORMAL_NC; > + kvm_pte_t attr; > u32 sh = KVM_PTE_LEAF_ATTR_LO_S2_SH_IS; > > + if (device) > + attr = KVM_S2_MEMATTR(pgt, DEVICE_nGnRE); > + else if (normal_nc) > + attr = KVM_S2_MEMATTR(pgt, NORMAL_NC); > + else > + attr = KVM_S2_MEMATTR(pgt, NORMAL); As Will said, maybe a WARN_ON_ONCE(device && normal_nc). It would fall back to device which I think is fine. Reviewed-by: Catalin Marinas