From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D67C4332F for ; Tue, 12 Dec 2023 07:46:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8F506B0292; Tue, 12 Dec 2023 02:46:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B18436B0293; Tue, 12 Dec 2023 02:46:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B8596B0294; Tue, 12 Dec 2023 02:46:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8780D6B0292 for ; Tue, 12 Dec 2023 02:46:46 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 55E22120578 for ; Tue, 12 Dec 2023 07:46:46 +0000 (UTC) X-FDA: 81557384412.03.D9416DD Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf04.hostedemail.com (Postfix) with ESMTP id 784344000F for ; Tue, 12 Dec 2023 07:46:44 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="Q2uTqN/M"; dmarc=none; spf=none (imf04.hostedemail.com: domain of BATV+6f90c2f2ff3264e7ff81+7415+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+6f90c2f2ff3264e7ff81+7415+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702367204; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J6zaba+ZbspiAFr2rLoUw0Ptxv3sCznX+1rQk4lFRlc=; b=2aCkDXo4NmKsUy3kSZNVs5KIsBO4IwKPkff1PL0EDJuymfRbcy6sxxlXSp8N6g1QTz4pDh a6G34riMtgwBxxl4kMnMjfulqE16SO7a4pN6Lk2uhcF6TQ+oPpGV75VN++CvLtzOtm23D2 HrIPg/wd+Jhm6ubgEohX9M2NiNwqqJ4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="Q2uTqN/M"; dmarc=none; spf=none (imf04.hostedemail.com: domain of BATV+6f90c2f2ff3264e7ff81+7415+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+6f90c2f2ff3264e7ff81+7415+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702367204; a=rsa-sha256; cv=none; b=8TJQfb0TrYiFEsHtqqJyhUDfuSkSsg//w6lIE3jhzLdAwCjiFK4zgmzDUrewUHZ42yCHm+ ed9q0ZxKwvpa4nhNxY1QYt6/ZUSBh1w3Xm8GdwM6DUZUnZXR/2YMbaBHkPQyjMqm9v8qgW /WSPocqo9VhUwaxgcwqEBoq2uUhtsSU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=J6zaba+ZbspiAFr2rLoUw0Ptxv3sCznX+1rQk4lFRlc=; b=Q2uTqN/MG8AV+qJ/pcL6OklThn w8Uyb/NKu9NzWDuS+QvzadqyZ3oENcv0mFAJDt27kI6CFb1Li2Irfbs/GGyLbUC6sg7HkfsG9OCbo eWNYx7ei6T9Bk4vAGAkAR8jG3ErhjKZ8o1o81LXnPWWsar2b+mZKqEPRjghnkNmlADH/f9Np3fIt5 qOf/sIQgfpKohW0GSK7V7aMbNWebHxu/cm7SKgdFsgBmMwItMjb6S7Y6Y6ydPy4hQQIcEDJq6q53b xPn/4J58MXAH/A+/veg2daBAnDFRiPHJ/P1ggPlgmihi084se87qDkuv46oCIH307vxuq3V49C9hf 20CIIhFQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rCxTV-00AxFB-1n; Tue, 12 Dec 2023 07:46:41 +0000 Date: Mon, 11 Dec 2023 23:46:41 -0800 From: Christoph Hellwig To: Matthew Wilcox Cc: David Howells , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara Subject: Re: [PATCH 00/12] Convert write_cache_pages() to an iterator Message-ID: References: <20230626173521.459345-1-willy@infradead.org> <3130123.1687863182@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 784344000F X-Stat-Signature: w47ganqt6h8tcscadtq6ex6u7q63qjo3 X-Rspam-User: X-HE-Tag: 1702367204-276658 X-HE-Meta: U2FsdGVkX1+/S4DRBXYao7lSSfinztS52bnnLjHlh75A3Bgq3M6Z+6V34EUevXRnFuEYfpuAl+N/LLPzEG20jgbvqRzGRht1CkAzSndlV7zmsUe2dnEcuXnQxvZcANUad23+BuNd8QYjudjEgfbCNRyfbFFRvvoIP08pEHeXobSNIfQd/oaNNELXF7ZEW9s/gELWRHf/oNCvqxCLcXZPXN6ELTiFfWy7Sj4nXmSOxUxsaD2D43rf+9cw5tc8TYYG8PinevrfcN9ZIDk38oxxlAt3mEd5lQKUv5U5qjE9v1MELAza172W72fWk0yu3pue8nUWL7D0p0bgydJ8DJ19MeJJFX3hfnXzqngb1H74kX7yxhcz7wCtG5cHF526OQvrSHeFWhlDbOew+AHYGq3gg74H3GMyraofG3H8aFyg7FKlvNVLm8BDLp6o1AWkchl7X4bwtKy34bcJLDDIgkPa+2K3vsigRIwyTzjeCyRKveyCuOzKm47+jNl69d+wVLMtJbEeay280lJWeH6EwrBA7ECw3Jn+R85k/NYwwnRnm2wT9bHNjBEc5dEr30/OINc5jj0KAxKRyhon9uJVt55dTlQZCDBvSDXxpty6k/nHcx1JuiTdCiRCNNAUBLcAoIoHtMn16R0EJkdaGQuYXDfONW9CpTQDpxBclsCHwQbe1aXSwpzXcK1l1alfq6dTqArSZXS0VF5GiDV39JnsFFyv5Gb1+AfOGk8QkxfbOmQmo/ai1COYAMEMUayLMhivMlgHT2VC7LdbwTekGisGdl+eP+KaWipef6hPP7rilj8nEJ7r/S+mM0HSdQbTCPo7UkbQBFLcliddOaYyOwPHz1Pr/0ED0/0tPGj8imA6GYXzTc53Cpbb7iq7d6fp7x16APjDUzsW+tSWQnlryFY5JQmlLtTBPy8qrY3JfljtuPmszfeWAq7m3rQbWjfR/5Ca1sLTCZNNOxZD/6GkN+7wGgV xV4d3nhH PP9QzjDezrhzyN6LgvDw5tcsF0to/htcfNVV/mJIAbJs0Fj3EeRuUZCFfsNiHJP9QPThloU4MEeuJm+eDbW/TSCoRF++pDw9GcAIA+NAHfTO4pAcE55XVHatZH5wMvv+yvJyJg/+QH4F6r1rk+Rw0e3iLrbeSI0u3Bg0vuRqH58Aa6KEwKhoGdRo3pdPf7kEkyRMiFjA1zwR3NqpYznwahdlvkyWkrAo0N/3jjAK9gCmx1pTG60g3vQO6ThxS//JhiqZqzYKRnw0iID9GaRm1gQAS2S5sqSwkltRWnwHyAw8pMUAzf0ArGVz1inC6W7gFeu4Omh4Qhuyjm111+pJFBFvawuBBcqIiwmhlNdLK6zv2d/J02KZGW6siaD9NYK/sYr4a4VUvOlKH2glIQN3APrgIc8YIMEAxM4uBDJelaVcF3nBiFqzrm1Y6k68VLaeGSh+z1suxB9GR5i3ZnOWVZeXo9M8Luvvkv4z4r02kZTtAOIQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 28, 2023 at 08:31:05PM +0100, Matthew Wilcox wrote: > On Tue, Jun 27, 2023 at 11:53:02AM +0100, David Howells wrote: > > Do you have this on a branch somewhere? > > I just pushed it out to https://git.infradead.org/users/willy/pagecache.git/shortlog/refs/heads/writeback-iter > > Running it through xfstests now. This includes one of Christoph's > suggestions, a build fix for Linus's tree, and a bugfix I noticed last > night, so it's not quite the same as the emails that were sent out in > this thread. I doubt it'll be what I send out for v2 either. So it turns out thіs version still applies fine and tests fine with latest mainline. I've put up a slight tweak here: http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/writeback-iter this moves and documents the new fields in struct writeback_control and drops the iomap patch for now as it has conflicts in the VFS tree in this merge window. Do you want me to send this version out, or do you want to take over or is there a good reason not to progress with it?