From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC097C4332F for ; Mon, 11 Dec 2023 18:57:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DC686B01AB; Mon, 11 Dec 2023 13:57:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 68C346B01AE; Mon, 11 Dec 2023 13:57:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 553066B01B1; Mon, 11 Dec 2023 13:57:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 395256B01AB for ; Mon, 11 Dec 2023 13:57:21 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 151E9A19C0 for ; Mon, 11 Dec 2023 18:57:21 +0000 (UTC) X-FDA: 81555445482.24.F7BF5E7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 6129740017 for ; Mon, 11 Dec 2023 18:57:18 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf01.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702321038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fq6G0s0SuJJDaT6vPSSTP+Uy12rFKoVzQyjqAyjCcAA=; b=IyZU9FW6s2ouaHssBEuyEEwc8ixzPUz7qoopa8f/9yIJUXAAl45re7IzNkNi6mJ2cBsixz tPFriY0XpGTll1HkL8abO7Shm2G8Rg7verh4ypmYWcap7dvZW5wCW7nqdowu/AXK4G6asS vVejKqNMHHN8Nq9cD0kY80q4zq8aMoQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf01.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702321038; a=rsa-sha256; cv=none; b=3hElp/dF2zEbmhGSlf8wxrzRkuBoySwpJYPl6cVJlUKYClkHpF9dTqrkQqOmrCDBLW07qT tekNN3EQr11dF88p505rnzmTO/eDdvn+noWTZaA4X9r3nGhgxDooJfxmYxHj5BcTm50ERY ysQjWTKdQpRdlJb3HLeBbG7YgXb3Ep8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7CDB86124D; Mon, 11 Dec 2023 18:57:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FA18C433C7; Mon, 11 Dec 2023 18:57:14 +0000 (UTC) Date: Mon, 11 Dec 2023 18:57:12 +0000 From: Catalin Marinas To: Joey Gouly Cc: linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com, broonie@kernel.org, dave.hansen@linux.intel.com, maz@kernel.org, oliver.upton@linux.dev, shuah@kernel.org, will@kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, James Morse , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH v3 17/25] arm64: enable POE and PIE to coexist Message-ID: References: <20231124163510.1835740-1-joey.gouly@arm.com> <20231124163510.1835740-18-joey.gouly@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231124163510.1835740-18-joey.gouly@arm.com> X-Rspamd-Queue-Id: 6129740017 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 4nictgewee7qzpjmiqj8wzg4s7nhccwz X-HE-Tag: 1702321038-82916 X-HE-Meta: U2FsdGVkX194vgTHYy6CO9X2s2VR0fU7BDwd1FlyniJF4z4jxmJ+HZN98H+13UVYAOe3IprH69ZliiXPpBl7wRppstbXGya/ASaOFkTso+XS8fRm3aJobZRTSLlQizrNkyJRmrWIf96EGBxK4KF4q1kvC+Xp58v/aYgBQK0kpES5MhuZeN6i+OmAfZ3GlOGVd5SPWHxMLew9kH23Lg5OqoIeBhL1X/5rLUu7wNqX3gDYrBmnXDZH3L7y8wq8kEwALpcTeR6KaO5tzflzNfV8I5Syo8+Ve2O/2Yz1rGlNzhq1L4n8Ueoab2O88YChvJf5Cuali+k5qh4PCGfqwa+N2LlyNa1/OxJuHF0JV+pvm+MUCH9zcYULxw5V9UMNOtro9xYICPTpj+DlKaUMZtYaYAVcjtTSrC7dRvgxpgRMA95xpMRJrjhfMEAsN8jnNS/nviw6M4plwQkj2mq7msO1TlKeTJbW2wlkqr19RFNDmwNraQNg0qX3/C471aOx4YHeLtec8hI8TmbpNlBUA/MurNpoMX1GWDz58lOAP1RqmTKfM5CbX3ts+BB0UCKmnFlWnVowuBaJuh5RkfmM3RSyNxBArIDd1j4XEKzOJOYjRNI95De6zgyakkrXYaaTgIKoDbhLvqwR1dp0170MH/js0cdsrWvsWB8jPFXLYYPqZ2U1ebxXrpxfnIKy0jxA5hmZ4SUt9IOAUmUg4ZdfO4bYKvFYC8nX39LhO/5SWUr5+bQLcGsxXQd4inmkhbE+9P+b2ORUiI3LwSup7MPCV+NWk0IkHzuQB36KTk1FwmbpedsXK+4xOguASemVtGcYfJ8lEEFxx6UjraJk7pufpofh1/5ZPIFNzi126lWxC9VN8OgjFXAptE8CJtujnwStXuzJqUAZ0XdxruId4BTavS1iHYAXxPchQXJJAk725MewxpTiMY6tzGJxJCriQ9ItxECGrxEucbg5L8I88D3QT8d OgZmnCaE wQjLOFovbl3M+bCsV+KypyHO2oS1ID8LbzRDAwniXM1ZRpmBWPrOzjwXtiu0iF905+wEdGUujgtAHI9Pn+zP//H3MfTVmUDV30yxZdWqQXae3Ijm1vlTkXdzZvI79jbnm2TG/gUcJoraPrhaBxmWKgjkn44FTu+NPyT9hOnikNhGwxoOSwwmArpJ2sWMcroJ7DF2GSwvXHpOIrAYnYeRiZ4Qnt+lbyj04QCL2wB3HkXinw1CTh36wgPQfbqmchU5ESYl6NH/XKUZqGiPUlOIhULnWOkmbhMFqUQwZM1HrKdglOSSXu7ymApLg/lc8G3mssZH3xOYS3Ku6B2Vdk7MJnLZ+un32fWu1CTPsY/OfS4XEInnZqPSj99QzEMQ2wk/PxUXcXS8KIwSZPAs4FQDV7ph5gZg7yzY4kc03j65liVQ8lvPNHAap3ucmnQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 24, 2023 at 04:35:02PM +0000, Joey Gouly wrote: > Set the EL0/userspace indirection encodings to be the overlay enabled > variants of the permissions. > > Signed-off-by: Joey Gouly > Cc: Catalin Marinas > Cc: Will Deacon > --- > arch/arm64/include/asm/pgtable-prot.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/include/asm/pgtable-prot.h b/arch/arm64/include/asm/pgtable-prot.h > index e9624f6326dd..3007208e04aa 100644 > --- a/arch/arm64/include/asm/pgtable-prot.h > +++ b/arch/arm64/include/asm/pgtable-prot.h > @@ -137,10 +137,10 @@ extern bool arm64_use_ng_mappings; > > #define PIE_E0 ( \ > PIRx_ELx_PERM(pte_pi_index(_PAGE_EXECONLY), PIE_X_O) | \ > - PIRx_ELx_PERM(pte_pi_index(_PAGE_READONLY_EXEC), PIE_RX) | \ > - PIRx_ELx_PERM(pte_pi_index(_PAGE_SHARED_EXEC), PIE_RWX) | \ > - PIRx_ELx_PERM(pte_pi_index(_PAGE_READONLY), PIE_R) | \ > - PIRx_ELx_PERM(pte_pi_index(_PAGE_SHARED), PIE_RW)) > + PIRx_ELx_PERM(pte_pi_index(_PAGE_READONLY_EXEC), PIE_RX_O) | \ > + PIRx_ELx_PERM(pte_pi_index(_PAGE_SHARED_EXEC), PIE_RWX_O) | \ > + PIRx_ELx_PERM(pte_pi_index(_PAGE_READONLY), PIE_R_O) | \ > + PIRx_ELx_PERM(pte_pi_index(_PAGE_SHARED), PIE_RW_O)) > > #define PIE_E1 ( \ > PIRx_ELx_PERM(pte_pi_index(_PAGE_EXECONLY), PIE_NONE_O) | \ Don't we need to do this for PIE_E1? Or we consider the futex (LDXR/STXR) accesses not checked by POE? That's fine by me if we go this route but we should document it. The alternative is to enable overlay variants in PIE_E1 but we need to reserve a POE key for the kernel to use. -- Catalin