From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74AD2C10F05 for ; Mon, 11 Dec 2023 17:00:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A52886B0182; Mon, 11 Dec 2023 12:00:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A01BD6B0183; Mon, 11 Dec 2023 12:00:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F0F86B0184; Mon, 11 Dec 2023 12:00:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7F6DA6B0182 for ; Mon, 11 Dec 2023 12:00:54 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3BB83160779 for ; Mon, 11 Dec 2023 17:00:54 +0000 (UTC) X-FDA: 81555152028.17.779AFD4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 262244002F for ; Mon, 11 Dec 2023 17:00:51 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="h/IzyEDX"; dmarc=none; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702314052; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XQL4KLYK46FBcvS2Q/hWsRZjCkcrPdKFGKmtrMsbgdc=; b=y1nvY8x3K79Dusk/tjLAxPNFJIVzy/JJgyTwhv2iJnp+rpXkIx6u3q10izr2UWkMoZE3RF 6DGERDZLqTqRwLhBzzfJR1dnrCJX4V5gluU9hl+NtvqhH5GGdWn5WN0tcqYGvCKiNRreYA d2Jr6SIbHxQO2EYDp+rSE8OgaZqqlMg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="h/IzyEDX"; dmarc=none; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702314052; a=rsa-sha256; cv=none; b=EZ8YZ0Mlv+5Oc15XBETewp/2AMu7A2aPgCEkrTZTMsHtja3Qm8eV59DC9LM+v18V4pGmHb z8C6yPW+6GedLDwFfNw05zVlFeFEETh4gI2Xy3EP6yAeIfBNRAc0vjDHFkFcymFDjMmp0B RdgsJpYgofgrkkTOtouAunSNnK9u3UI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XQL4KLYK46FBcvS2Q/hWsRZjCkcrPdKFGKmtrMsbgdc=; b=h/IzyEDXFu6U8tWkhAzL4uzmOt PM9PoWDLlm+5uSEnp9Ch6iGufZCzFHD7XntJ87pW50FC9PQ4B3ltyjcZMfevYhIKk7H6cHnbnscpI aQDHqgFgsPQWLm8aLLRwDdo3fM7NhVeuXBL/lBaHoPNYssz2RzDlKUUKjBD8RF/pRX6TTjlKJM+Ri CLcpGOWp3Qcs5dBM6LS1lh33zSokbjzTfXX0CaeyTi/wFKQZwv5WSrURfN7Zwm51gH6eG38Qb2LZU xIENm+1OIbEIHtkXBz7Cg8WD3stbmlhwFpOvAuIil6Ta9qevjE1wZ16eXlZnBlPXX+hhgar7nefby B2/s9q+A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rCje6-00924L-VK; Mon, 11 Dec 2023 17:00:43 +0000 Date: Mon, 11 Dec 2023 17:00:42 +0000 From: Matthew Wilcox To: Pasha Tatashin Cc: gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org, surenb@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, souravpanda@google.com Subject: Re: [PATCH] vmstat: don't auto expand the sysfs files Message-ID: References: <20231211154644.4103495-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231211154644.4103495-1-pasha.tatashin@soleen.com> X-Rspam-User: X-Stat-Signature: qysmocwerq3zxr385obywt41zfhkimxf X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 262244002F X-HE-Tag: 1702314051-72714 X-HE-Meta: U2FsdGVkX18ebi4DynFfVsi5RgqwaSbsSWyyHGbd7ypL1j9APSApLJPqJXZbnXBRer6BhLNUD/cP/6ex479Bisni1uWHHVO2ZzTKmHVpcDFqTBygM81eXlVO9/bZ2eCixCQCH/0+SKuleJw0mIWMcoeMT0uektmqbb0kmpwXQkenfnX+ybxkk8FL4tSlVG/p5yZoelogjslZkwk00RY8Go6i+0a+symYrHosin7d2k0/NjuhQy2ozGfnBS9T8G0DzdeBvUHSh3l5LHZham6hMM1HCPzWSX0aiW7pLI8YAHEKgh3MhNvERO0u3rN5dxKt2lDOatnU4C444PnwABQh68S89lR8TIMmxfip6Crx9MoCF+0cRwQ/Ulp3uj6p1QjT9SxyoZN/YOzUbuz0iXCtk4NNtcj150t3TeMy5LGSiZvcOttgTbtn2VktyosCPypIc4iXGgZkPncaAoG0NLK9xfLZ3rc/ndGcdGRyY9J9iGjMgrEpmmtaI4ejeI3x1kQ4TUXBlMzPUabzSbCeZ1YHBoyIAwkyuJN9nPRkNn1GqfEl/ThjKzrPlPkD9++Fap9hSH8evMM1dfs0brFYxyjBiM2foUNamOb1o0pPbixA+f6NijLmePV+xBl5QBlGUziuWOfHcJgrCrQmESweH46F88s34+ZWfSPzevy8+h4qxcWg3tHkgrzyemOV/U2zrvKWHfAOEptNSOki3ZprQoMliTBe4yoBdfs64zfgcTLxNKO8OFYUwCXqKGc0vT+4R64+T0N5gnbOeW3Pg82b8vOD8Gi8ZRLI1/B4dxN37SmDMd2MC+FLsQQylRUvb/mQmrf+BATcR03Qa9bD24cn3kYVF8KIhraIeNOQjjxGKpBEkvGDVXXftwSVSaPg2iGzxzOnG2MBY3QVZam9MP8WgmUXjG5SK0Bj+Xjinaf99r2+aGUay+qj5gJLqOaAYecllm2VnK2Lxh5+co3Kghwx+se q65Ro5BO ghbVqOZQfCUONhJQJ3o5IQFfM3U43KfNYEbxBDTz2e0GH5e3vrZY3DOtReNFWKqqLrYDz5axiDxnPOV9Qw6atbpY9C4rH3ybkveJ3w3aJMlxP7ay3CGV6E4MgWfg1BDMP8jQ2JwyADy4aU7c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 11, 2023 at 03:46:44PM +0000, Pasha Tatashin wrote: > +++ b/drivers/base/node.c > @@ -520,26 +520,34 @@ static ssize_t node_read_vmstat(struct device *dev, > int i; > int len = 0; > > - for (i = 0; i < NR_VM_ZONE_STAT_ITEMS; i++) > - len += sysfs_emit_at(buf, len, "%s %lu\n", > - zone_stat_name(i), > - sum_zone_node_page_state(nid, i)); > + for (i = 0; i < NR_VM_ZONE_STAT_ITEMS; i++) { > + if (vmstat_text[ZONE_STAT_NAME_IDX(i)].flags & VMSTAT_SHOW_SYSFS) { > + len += sysfs_emit_at(buf, len, "%s %lu\n", > + zone_stat_name(i), > + sum_zone_node_page_state(nid, i)); > + } > + } This seems overly complicated. Why not do: for (i = 0; i < NR_VM_ZONE_STAT_SYSFS_ITEMS; i++) and have assertions that this number doesn't change (and require people to add to the list after that point)?