From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31643C4167B for ; Mon, 11 Dec 2023 16:24:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBD266B0164; Mon, 11 Dec 2023 11:24:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B6D726B0166; Mon, 11 Dec 2023 11:24:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0C7E6B0167; Mon, 11 Dec 2023 11:24:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9052F6B0164 for ; Mon, 11 Dec 2023 11:24:22 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6A0FD1606E3 for ; Mon, 11 Dec 2023 16:24:22 +0000 (UTC) X-FDA: 81555059964.20.3BC43A7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id C60E240018 for ; Mon, 11 Dec 2023 16:24:20 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZQ3xLCeJ; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702311860; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6Kfb+cfmApiBpOgVhRA429I1tFY1BIkkOoH5lksrhgQ=; b=akq1i8ZhRydeEWwE47mzguLPVv3k7sIefKtYfNVSCeY0tTcnITEB4l+cHNRkxqvy0I7Vid iOwkCegS9RmhjoG9nSq8DK24vyB334M2iw7y8NjAJJ23T0CsZySs/5ApGAwHYEjOFMrodF waMlDy0P7lWHbPmQBw2LTRkH+XrCJIQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702311860; a=rsa-sha256; cv=none; b=baa80mWNNllaQ6KjBqLLE5RYD6pnCj50EThnbbyHnGZbHHld283QCPelVxv8fZ+IxgN4F7 9mn13KXIvul7ia1UMsJdSDjuuB0YgEcpKrpyoB4Hk//AQr7K8HRzw4pf0YF3nM7TxvKofk gyY4HCnymNalmClqHpuwPNAC19gcLAI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZQ3xLCeJ; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6Kfb+cfmApiBpOgVhRA429I1tFY1BIkkOoH5lksrhgQ=; b=ZQ3xLCeJZrEVazVZrCkgXWXzkI kGpyWTDaVl+aAVVpkqBACmte9aJqayXYMdFTpdeGqG6TZOLKYyKEbkXmWqNPd9bs6o+TRXnWAX8QA DT2Iuik5P1QUn8xnQagPP1TjbT2QLP7ausqM70sfkCkIO7m9msvKGP+yasmCBmCS9n7y/T/FFQ179 +OoNKUxLTvwH+toXCD+FRNvle7rkvCCLwBDarZPbdTkHDMXc+abv/0F/cyd1tf7zk00kNKRHCWPmN fbt/sAF2fYo7z4ADJYF7rMBT08z9NPUfF1RrH161A1XVg5QSIH5p6Qr9HvGm/eP1QYnFZ3slvboZ0 0ok1jx7A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rCj4m-0090QP-4E; Mon, 11 Dec 2023 16:24:12 +0000 Date: Mon, 11 Dec 2023 16:24:12 +0000 From: Matthew Wilcox To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Hugh Dickins , Ryan Roberts , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu , Muchun Song Subject: Re: [PATCH v1 01/39] mm/rmap: rename hugepage_add* to hugetlb_add* Message-ID: References: <20231211155652.131054-1-david@redhat.com> <20231211155652.131054-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231211155652.131054-2-david@redhat.com> X-Rspamd-Queue-Id: C60E240018 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 5jkbui1pejmidz915m3g81qz5k5k6twg X-HE-Tag: 1702311860-994040 X-HE-Meta: U2FsdGVkX19eBnybsrJLCCfkrQ78MaYC6qOXeaWjoBKe+czxXktd1gPnVhbh9/nlYRB2g3LiaTTHPbOa5+fFeP11W3yS5in4upLWniXuLDsb3LBVv0XM0++Oao7t7eQ1NsXmr7xwhNUsKGMGfAseI3F2hMa/b/lz2/3qWqjC6OakFG35N6REQMsCFSkoBfDCo4PgnyZeTUzTROq94ZrtTV4I8eKwoUxt9oiYgCQgmHv26htqlZS5pUXZLacASq+g5qgeDBqbDlyIjXPRAmri1kA8key/tk+4+SuaypHX025wiQKB11YqK7SrsXSS/LlmJk6IOQM816/brgnCVWzZmDmFpM/53zbFSzDoEXpMdvfayKK2/TaWjU0Jn2uF9mIiTzMWP5yqZh96hcWlm7GBemHNTStFWFF+yq21J2bvLtji5BjGhG43rdUYE82a4V68oNRsvuBwi55nwtG1/pE8N/whCwELE3PFwhTRLEEe81t3duL80qkpgCrn5c1QZSg//FYOlv8E0rz0zCXV39UCn4YBAFwadqNAsApeeyyU8O7gy7l4yUQ7MC3qQeI80ZZbKOOYP0wT1lfMT+0YEAvzXipCYSDGC/XhssJua+MPe+rSbFJBhgObXXG9oy23thFu23D3cT2bX19WSSRGIYyZVsxZP0/S4Y+d9bYuvLBCV96yIQBudrQRau7myLHk5HtTHS+7ov8JgO9jGUJTqqxFiy/RK3akbVU+TxuA84gQUYEoIXHyjRAFPyhr47KhaiGz12TZBUTgZSoRno6ZcloA4ZdXOITDNo44x45yRYKstM/EnHwSStRCpVdZ1Hy/Qe8oiSEuPzsg+mNdlerf2HgbPjn+gmDm9HAOiMcAWiPkPqYBESHp8g++KpiOpsXlNWMEJI3AAQh8QlJ9rm3nge5dhbTn/ACSEqwJZGXGNVk4JtAiqDijpae+gGEnagOhZsCIQ1YPdjr7Snuf04PV/35 86wu/oZc xvXzL/CVxRJ65SzhP7bmXXeFVSZLDFgfSMMVY9tHiBvUWqc7vpYuj0+EkbSkAvKq1WJ8/f9wMCDXTZ6OUKUY8c+W//bpeqUtRhaBQ4Yde+5wo/kWNhp+zo22qgTexVfXREAKG2MsHkQIaV4TIWDQmGuRxb4eTYAOmgUrEgrhKXzuTuYUHnVQ9Ra5p9jPNp33I49WyLtj7HJwtrS1fH5jprCzFecOAx+ZnBfeIja0HWonUyTHAMIXawmvxbD2jL655MeqT2CsWLRCEXdaiNncHNsARPP3OoBIm6+SQf8INrHqClcwi9ohnWedC30H42x8OTQyrAoWRDWchB/4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 11, 2023 at 04:56:14PM +0100, David Hildenbrand wrote: > Let's just call it "hugetlb_". > > Yes, it's all already inconsistent and confusing because we have a lot > of "hugepage_" functions for legacy reasons. But "hugetlb" cannot possibly > be confused with transparent huge pages, and it matches "hugetlb.c" and > "folio_test_hugetlb()". So let's minimize confusion in rmap code. > > Reviewed-by: Muchun Song > Signed-off-by: David Hildenbrand Reviewed-by: Matthew Wilcox (Oracle)