From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD769C4167B for ; Sat, 9 Dec 2023 01:44:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4887C6B0080; Fri, 8 Dec 2023 20:44:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 438B86B0081; Fri, 8 Dec 2023 20:44:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 301026B0082; Fri, 8 Dec 2023 20:44:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1A8466B0080 for ; Fri, 8 Dec 2023 20:44:26 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D87B5C02A1 for ; Sat, 9 Dec 2023 01:44:25 +0000 (UTC) X-FDA: 81545584890.29.FAA8DDA Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) by imf25.hostedemail.com (Postfix) with ESMTP id C4410A0008 for ; Sat, 9 Dec 2023 01:44:23 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wzRy6s8v; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702086264; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dEa8QaNsjYl+s8o0gsHyRZ4RaaNqT3abDhzMXeL0qdo=; b=Kjcdc1njKn/W8dj1Aq9KqRaHiwAe2ahLkQtF/PmlPpSTAIIr51StNO18neZiQu+Exzbr2E UjnD4ZVxVBsG2ECWMhgyF6ga7WjM/97IB17RDPkrNRzHN54jqzrYBXAP/Ki1fjTYjIq3jK h3kJ87SoMmAoxWrrkjX28uzE0XW/rZo= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wzRy6s8v; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702086264; a=rsa-sha256; cv=none; b=dOpv/4DhkDiYHmJDbpwB98ky+U4hnp2m3CR0fmpgLsR2MTyFf3PAlc5iJvvrOP+l/FUwCv rYLktjB338VcdrVTG6V4ECQoM6SjK3AVs8BCIoF/spSdHoOal0BaIyDGtMeXCv29YW6Nu+ fMUyT8W1ff6vy1JF1dly04JnULGVu5c= Date: Fri, 8 Dec 2023 17:44:16 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1702086261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dEa8QaNsjYl+s8o0gsHyRZ4RaaNqT3abDhzMXeL0qdo=; b=wzRy6s8veFnUU5bJNgdMSFLnGRzIkZYdeFCe2HgzQ9TtGun5P8swPOMFlxqhzIaQBnIJc2 dN17ldR8uKRlAw68zDGPd6vFr3H6uDROlDA4T84AjubJVeqt25Zui9OB2yfilnrYcbEf3J +GTkozjJjnjywRbLMcbVBFA+/WO5le8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Kent Overstreet Cc: Dave Chinner , Qi Zheng , Michal Hocko , Muchun Song , Linux-MM , linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH 2/7] mm: shrinker: Add a .to_text() method for shrinkers Message-ID: References: <20231129231147.7msiocerq7phxnyu@moria.home.lan> <04f63966-af72-43ef-a65c-ff927064a3e4@bytedance.com> <20231130032149.ynap4ai47dj62fy3@moria.home.lan> <20231206191349.x52nm3ercxelh3dx@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231206191349.x52nm3ercxelh3dx@moria.home.lan> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C4410A0008 X-Stat-Signature: k5bm193ur8wpb364s36g4iwbx14ut5ub X-HE-Tag: 1702086263-412676 X-HE-Meta: U2FsdGVkX19LUNaXkXOyz4YfFR+0VMLyZwPYaqlzvQ+9+S7EIKECEySfce5ItdgV77kbOqGWNNIUm/KXzhkC0gvjBRoah5cbI2r5qjW8lqp69Ao3BGu5gjm33VfZw1hdevwlw7LliTMJ06f64VYejMFukBCSm5Es6TNfO/wrGgVO70Ho+s4o70ggzfyvA256EBckHTLpXVodzZIHoE7vUlVGkkx16LjMKhuJKnKjQqNwiUF+nD5CV1un81qfCSiRfrIPmbuOn3FrJB3wZhccMxAhnR3gj9sGFKoN9+XKTj7MlHoAYh+JXi9gyYkW6klS1QgiPdrfd1isO+TuBa/tiLd//iVyZwGOddcc78EHLiyV69Wgg3wzL7cTktgDGrc/XahHvLyK+hfK1pIWYHLhYCCGMckcJab55Bp77A3kNOoj+9DBfmDJVToDA6ekCJION0kzQcUqPZk+6InGlHrAMLwbnwxp/xxSadlEopm5D5/RXTh6/z4hOsfvZmspu77PgAMROxO6GghaElaUhrgqOyXjVYwMGifB6ibNDDI6e9AYPdWkRE10z/zu9x1cG8kmNKiBdZPFQrX5uZnoMlKBnczQeQbipDFACI+ZeJfRLotXBaQyuQdhf46DrqJYf9U1VxTy6Q1C+6ZbyoTviGvvLIejDleLuwF/SONsIrTyrKu/gC7CVYgj//6FJfSi/KjaLY1iutEu4OPGzsSQep2NbwS8dzgQY8tgdUUne6L/ROwgbKbkeUf29Gc/DDJPrEQ3l5puSbM9XO8iA13kVRcmk1B5Dj3v4V1FQUu92Fj5hqlTl4lOMx0lMncH9FCKlow5w0BAdZHXZUjY8rn7oFvcJHOgu+OUlJ2tvxxAnjnhQv6PhMt6xAK6fDNB7bgkJhvi5Gy138yqseSeAf2AdQQ3tPuv4hzRsssdJS1ciYR9DFM2wdlnBol7Od2pIyuKTxK0B7moCoKUvVHV+Qbvk3w THJ/83Pg BCh/O+Ku4Sgpv77uL9SUPu9An8Rhm5MNjqQouhIuVUzvHm1gjkXhl0+j/gTMBauQjNs1I5SmywqsU66myYjbhc1oxQAso/MnvYn2vGDoeC0m8GPo5yeucjL6ttWqF9Jm/JyXnItZJLnBLkBs7xx3IQBFkZvOVnNKtCCk/AqZorgMREer7TyXEp3herw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 06, 2023 at 02:13:49PM -0500, Kent Overstreet wrote: 0;95;0c> On Wed, Dec 06, 2023 at 07:16:04PM +1100, Dave Chinner wrote: > > On Fri, Dec 01, 2023 at 12:01:33PM -0800, Roman Gushchin wrote: > > > What would be the proper solution to this problem from your point of view? > > > What functionality/API mm can provide to make the life of fs developers > > > better here? > > > > What can we do better? > > > > The first thing we can do better that comes to mind is to merge > > Kent's patches that allow the shrinker owner to output debug > > information when requested by the infrastructure. > > > > Then we - the shrinker implementers - have some control of our own > > destiny. We can add whatever we need to solve shrinker and OOM > > problems realted to our shrinkers not doing the right thing. > > > > But without that callout from the infrastructure and the > > infrastructure to drive it at appropriate times, we will make zero > > progress improving the situation. > > > > Yes, the code may not be perfect and, yes, it may not be useful to > > mm developers, but for the people who have to debug shrinker related > > problems in production systems we need all the help we can get. We > > certainly don't care if it isn't perfect, just having something we > > can partially tailor to our iindividual needs is far, far better > > than the current situation of nothing at all... > > Of course if mm people don't want it I've got better things to do than > fight uphill battles just to get some reviewed-by tags. Real high > quality review feedback in this thread. (ignoring an attack towards all mm people, sigh) Kent, I think extending the shrinker debugfs interface is useful. And in this context there is no need to limit the output to 10 items. Also most of disagreements will vanish (sorry, if I missed something, but looks like all concerns are related to the oom part). Will it work for you? If yes, would you be able to drop the oom part (at least for now) and resend the patchset? Thanks!