From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16A2FC4167B for ; Fri, 8 Dec 2023 00:12:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A47EC6B006E; Thu, 7 Dec 2023 19:12:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F7CC6B0078; Thu, 7 Dec 2023 19:12:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 899616B007B; Thu, 7 Dec 2023 19:12:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7A9D36B0078 for ; Thu, 7 Dec 2023 19:12:14 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 66A291C0947 for ; Fri, 8 Dec 2023 00:12:13 +0000 (UTC) X-FDA: 81541723746.26.EC3CC38 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2066.outbound.protection.outlook.com [40.107.92.66]) by imf24.hostedemail.com (Postfix) with ESMTP id B231118000D for ; Fri, 8 Dec 2023 00:12:10 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=memverge.com header.s=selector2 header.b=r8VE0l9c; spf=pass (imf24.hostedemail.com: domain of gregory.price@memverge.com designates 40.107.92.66 as permitted sender) smtp.mailfrom=gregory.price@memverge.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=memverge.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1701994330; a=rsa-sha256; cv=pass; b=UI5PJuaIUrPChmo+a9CgEeRtfT0EruIKZegFatWJL4Kggd7bzizXLtf5alD/ylRmi5SJ3F tn9rP6nkHDYFUYZncW03rCvf+bykyrdzoSn1ufaPu8pZojoZ1XDPdZMu17IHPEs+TS1Xj6 J3gwJsI1N2gwLPyv62q8zoBaxqG3fjE= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=memverge.com header.s=selector2 header.b=r8VE0l9c; spf=pass (imf24.hostedemail.com: domain of gregory.price@memverge.com designates 40.107.92.66 as permitted sender) smtp.mailfrom=gregory.price@memverge.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=memverge.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701994330; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=naCROcZwFJyDfAQcKuCqlnhY3Re9LTbXdGrG6K0rweM=; b=dldPGvu8elIVQp8x2CSeWv+SitqwE0hbg7s36DlLysH/gr+YjWommNVmIHIliu+9sM8KM4 nwAULjLLmFPVOwRtXSU8kUX6Cy4vawGYt0Oa+oc6/E3IQFNfwECysCQ3xZ7J0ciiJWb3sG veONiQEDjjHCP+brAcJi5C6MBbRr0zc= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OdfCFRCUOMRakhgtfCwgH8ilG7fq138W6k8AiTGr7wuExSME1LJka/Qiy2UYd+1C1Stib+BKAG971VqyTEuFxjhFJNVDkmVwuZG6z4fmwW35XA9DEoKoe4WizWGLen4lISMp4sQ+aBEb66PO89ttC5LttXNCm0sHl5LFQUhQAcdGtH/k+iW7ZcyN9gfFkv84hzm4/Y4cG/A+ZzRfi3CZrSh8XxTizpOeNOJzRW96smMN0XCvdyY+OmcPuUJCG6A+p9Lf7sI/dmmMAdPEvMPVvAMsR/jqk7vnJzOMcYS36+8kOmXU/QnoBLYy742d4O+ZRvAmXEv1k2Tq9HZZ5nplJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=naCROcZwFJyDfAQcKuCqlnhY3Re9LTbXdGrG6K0rweM=; b=Hx1kRX80fKddb2hP+FOsdW+8q9QvU5lYoJ9QJr5SVbgJYAr7y7/Li/AcqRheyNIZGOfAF1AeOwcqk8j6ftOAz55yhsLMLHUDZw+Vu3YR3lUUWrmbmeILxGDHhLdD81hcWzbTO/IyfD1ykyWFOfWdpX8rRqXAeTnpQKPw07fMctbwfdKHSv0UhNfb3g1xRizFh0YOkieHuIsJbPgkusn5T508smgZLF8OvZls1ojRqiQkW8NZZhWRp/FrICaupiCZyMEr2aV1YYHF8t2zKB79rUa8T3aC1vT9Y0yfo13+6JXL1Pnw7WinfOOiMGbueOIiPSV5KGgGddyAL7MD1zwuyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=memverge.com; dmarc=pass action=none header.from=memverge.com; dkim=pass header.d=memverge.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=memverge.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=naCROcZwFJyDfAQcKuCqlnhY3Re9LTbXdGrG6K0rweM=; b=r8VE0l9cVFEC/bXdYRLK6hxkywI5XFh27aXIDOMnet7Xbt9c7RrMltBIt6Wrpd8fcHJ0arlsB84rA7caEjZ/Jfe4bWsTOYrf1yR/tEwnixOpGOXil8AbcuGZJt1uHiSBES+/q5lHJNgbofbOfdnlKpzWvmImq8PCDvahYij1K4U= Received: from SJ0PR17MB5512.namprd17.prod.outlook.com (2603:10b6:a03:394::19) by SJ0PR17MB5843.namprd17.prod.outlook.com (2603:10b6:a03:40e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.27; Fri, 8 Dec 2023 00:12:05 +0000 Received: from SJ0PR17MB5512.namprd17.prod.outlook.com ([fe80::381c:7f11:1028:15f4]) by SJ0PR17MB5512.namprd17.prod.outlook.com ([fe80::381c:7f11:1028:15f4%5]) with mapi id 15.20.7068.027; Fri, 8 Dec 2023 00:12:05 +0000 Date: Thu, 7 Dec 2023 19:11:59 -0500 From: Gregory Price To: Gregory Price , linux-mm@kvack.org, jgroves@micron.com, ravis.opensrc@micron.com, sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, arnd@arndb.de, tglx@linutronix.de, luto@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, mhocko@kernel.org, tj@kernel.org, ying.huang@intel.com, corbet@lwn.net, rakie.kim@sk.com, hyeongtak.ji@sk.com, honggyu.kim@sk.com, vtavarespetr@micron.com, peterz@infradead.org Subject: Re: [RFC PATCH 01/11] mm/mempolicy: implement the sysfs-based weighted_interleave interface Message-ID: References: <20231207002759.51418-1-gregory.price@memverge.com> <20231207002759.51418-2-gregory.price@memverge.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SJ0PR03CA0235.namprd03.prod.outlook.com (2603:10b6:a03:39f::30) To SJ0PR17MB5512.namprd17.prod.outlook.com (2603:10b6:a03:394::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR17MB5512:EE_|SJ0PR17MB5843:EE_ X-MS-Office365-Filtering-Correlation-Id: efd1d4a4-66d9-4f90-627f-08dbf7824f4c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t3Duk6XKpZ4l7zsZ46tI39m5PyVKQYpIwEn7vT4uyNOfDHnPYz+K4Bk9MLxsNEqz7yEFK3A0jAlpLu5opcglWT6GLQP9JPGeC+civkovDBviCFptMgUc7y8myQ2xgbNUKErioD9WzXj0rskxPX2Zcgr+XGZZ65JbfgBRkj2Zmass3zUQwbATNwHXyShgBli3mBo0LXg/n7eHripRi6XwAjHAqp/CwI3lL9+PconBh2CCaurUcDB1yQbK1iQD8t90Qn2LgWSB9sdzmTegNJa9owxfvHMPKd0PzlPGYBnub8T15LnPTMuKL+Ojj23K6CcMH4FqZYDtnlOPS1KVRvB4X4Q4BYXr0voGYflyS3ZNNZKimpt+0pZS+7wMs+4y8obx8dOu+F3L3Mfx4jZuW6z7ZakDExEqjo4g2iDTOkYrHhamfQTe/PwwlkmdaownPODMP6vBqd4c/BV6EVCLSRt8Hrk2CL0oeiBI+yIdI7HwINe23FRCU2zj3HAoIwAmGVeN63lhFDbBF+qP8SN2cucAbmaHMGL8vF4MW7pfhD9fc8B5nMXlf61d3G0LUKfjnT4OAlbprCER3p+QiySsWVP8mr97QE9ycbQQfF4QaWuPrR7DZtwCSRmr9RE/Msj3vv7Y X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR17MB5512.namprd17.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(396003)(39840400004)(346002)(376002)(366004)(230922051799003)(451199024)(186009)(64100799003)(1800799012)(41300700001)(921008)(36756003)(5660300002)(2906002)(7416002)(7406005)(83380400001)(6666004)(6506007)(26005)(38100700002)(2616005)(6512007)(478600001)(6486002)(66476007)(66946007)(66556008)(44832011)(8936002)(8676002)(86362001)(316002)(16393002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6kM1oHoIff6eXahaQ1lELhOknww9FIYINdzojy/W0zzEc5mqwbLRZuTOf6+1?= =?us-ascii?Q?aDr2ksgtXpEAFCvWL+dfvZuuC9iaJVqdIr8yhDhZ9Y/MpCZX4JBswwYRvaFN?= =?us-ascii?Q?GhMTkxdCaQyF/ZVp63UhU4/jpINPXA+lgI615CY4yHLl2qKLexDn/F0JLPzf?= =?us-ascii?Q?qfcMooDw5/dZ3d1SgdgaD30Pvvj4CbJroNBlFZJ4B+ypbb8w5cegACwApK1z?= =?us-ascii?Q?uzGBHaBMxd9Q/QEnKAiMT3YZlFVslLQWPtf46j1X2ebT0mCodZVpcOa+SqMT?= =?us-ascii?Q?yTsKKO11fySOm5yrJMNgKHR+gXZLBvClwDobY4BCX2xrSRYEzw9sAEL58Nig?= =?us-ascii?Q?5uZEzWZXVYOOJDVrF+srCorBZ4BCuZ4pbarVEZ8oM/e5gyLEeUkdDlGeRagH?= =?us-ascii?Q?IEXL2+cPpESiv5fZZ8RM5n1AHv61HHHSI7+mkB81brDLaHgMZgVJjPab37hK?= =?us-ascii?Q?1EwAAuGAZEWGAQxm7/3XwwpMWmV9jUMAtIBNa53nnU+7anvM3968CcLVFPaF?= =?us-ascii?Q?IhWVPEJOIWQLaDhuMItCzKX92EHw2QseV/hDMF0c6RKvSPOlTScWyEIPAuCz?= =?us-ascii?Q?aZ173fSGJeurU3133bNj0yunnGBc42UdDKfQuqp5AVbZK7hMW6ZheUT/3q62?= =?us-ascii?Q?dIo2nJ06XGYYf1FmzxoqP+UL92wQ9khl+LvKuo32qpJnpLKeB71VHXW3nXAK?= =?us-ascii?Q?HdpoP+vvH0jBQBTDqqJ16A47Pkh/j7DtCvit2+kpseTg8bjYI8BG9x3EWTfV?= =?us-ascii?Q?RaRSmBrETQiZpJnAE9Y3vFXSXl5prbZkPh4oRIUu9lvNqfYvuYzVvbFZ8mMt?= =?us-ascii?Q?xaoSrnMPpqaDzLynbxFEDmxc6oATfDtvMo19Pkw6cTrRPmF7hMyvb4oRyPv6?= =?us-ascii?Q?a5OM4a9qN4fqx0+FI2pyUJXapmNbMz84p6jjHeenIawkIqBnpVCjVDnsxgmW?= =?us-ascii?Q?XYzWDqaVNuzNVmb13Zr1nPOX8WB5wT9zuDxFUJVIOsaJulX+tjYrzZDHM4JJ?= =?us-ascii?Q?GJ/q8I8EpxG9960lKL3UKPi9FVpd5oI8AnLaWNb8XrE9Bt7YSXX/sMXEiBUe?= =?us-ascii?Q?mtiY2TKfRGfQKKfsy86nErka166e97THnFCaz+OQVXGxWaj8JfWwq+DVzHRB?= =?us-ascii?Q?RnrDVZDOpm2BCmd++Ag+mdFs4s+UYy8DzAFVNSfwAu3tpmaQdTpue8+xq7C9?= =?us-ascii?Q?acq7KWawGLyJGKFICLlNQL4Eq2pafcGMRPHR58B62RIhVDQiOrkcF68ko4VS?= =?us-ascii?Q?rpBx6xkfUCF1V31G16KOLNiKaE09W4OLKbyLhBipZejOO8+p9d7eUjjheH93?= =?us-ascii?Q?7LWwDQWCFrGN3CBn+M1Nk+OmmktPYE0SFuWmvetwqwiCH7Vv3GiBH8evBHaf?= =?us-ascii?Q?QwJx0/bnhlRTM1fjFdSh6IMdpzlHxaZqcoBUOk60kGcRL5mFmrxC5C/yiCJU?= =?us-ascii?Q?RH5gvicy6Lbyd4ZpVEXsvC0PWaKgZgNoQjzlpkUTm4qGUe+rymA1A6OsfvfX?= =?us-ascii?Q?nMyJLMfXiqDjXuDspMiO4P2mtPKV0VwfYFXYnPHOjQXDWz3nHX6TuA9td92i?= =?us-ascii?Q?qRpUrQW5xnHf/sqFdkxyDnzjt/NaB/1Fl5jLrmG7sz91cT7iAh3rFWIskOlQ?= =?us-ascii?Q?JQ=3D=3D?= X-OriginatorOrg: memverge.com X-MS-Exchange-CrossTenant-Network-Message-Id: efd1d4a4-66d9-4f90-627f-08dbf7824f4c X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2023 00:12:05.3240 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p+aHLrGHdKXqRCL4AufnaHHvk+iXpIjGJaodIPDN7Mfdnv14Mrnepe0YnoXRC1aCwnUGuHwYgkpM1jMU1voi30GYtLH7m5z9F3mMIsCTys0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR17MB5843 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B231118000D X-Stat-Signature: zj58f9bha5nftndydef1dghacaphyrk6 X-Rspam-User: X-HE-Tag: 1701994330-561892 X-HE-Meta: U2FsdGVkX18F+hfaiYs1Q8cFToMXBnYWw0p4544M0X5tagLfjJauaBY2iRcnbv9TdLQo+pKkzsC9Ik1V6o57C3LPa3uRSYXSzoTyykSNT4+Dpd2nBoM72Zd3HOP1PP20SlmrWhMe8Or0YJlD5BCb+HX8HkoiwYGFPaYpF+Wc10Z1eocCb0gSNRe6eTcopTqT2j0lR95J8msk5MW8fd8VesHFA1k7Yse9t3OEMtqYqNd2QySDHhbW2oqWm710K1GkndVegd6r0Uj4Y65j6Wek7YYBt5++jumXMuq4iS1elggZLQxERJJGPsWbni6uOgWZHiYV731H9DTGYbKhY3t5euo8lG9J1jZ+VPsyo628i+7vjSVwma2Gu7MLeuagse0/krXs11Jt0p288z8h6i2F0m8DxDf+9Z+1RiI/e+u/g64eR637gawKgRRUnAMOVRfUBShu9RIzIjMlg4AxKx47zK+bwQk9hVl0RB4vfnTNRIv9BpfUZdj1X4W0VWPIPOJqm2XvGTnJg4tlk5pSXsYvsx3FAholH09eXVj3PeRmTVWYUlz8BSH3cNQwn83cu4FrF727R7Nh15JChGoSx/3DcJ+GuwgDEICGz2FP3/g4AVMB7nxDyRZsZUr/ohZ4zbrazUIx0XpnnDKMvOm0rgWj7h1oCNpbvGL6ikVzV6wHbMCxZs1GxWjzXq/GYt3LyNkXx4ZeHnAq01hB3bXqd7IaeAfe6DI3FhH1e0OiOt6xNAVZxFJhfHjyFM8Ns1nRe6BlSXBX2mdY18TxM3bTVPKK6xM9Tu15OOwnM6U2EBIE65cHGg/UZhZ9ZbJR/7jlpustFpH2VtRH3nBVPpGku+K6apqWX+Mg5i9Q0+YGxH0DPfD1sX49vgLXT5P+FgoDdJ69YCflDtpS3Dv51bCumeq09FKtS4Q3MIJj3fcpp/SgLPT2Uf1PvSw+ZPxWXUaV0xLSTf4P44Ncg5yTNgN1ZaS p/MxdBI/ 11Rn0KfDwVof4xrCKE7vS12QuTINz3KYSYiV1mIiaKo9p6sU9mQ5JpSbUYXVeTlZBrj+ARDL3ASyyA0fIhkDB1ti/pDdL0ynVwHA5DL7nbqSjps+l4RXiiuTkyPNdn5mYxaEt2zdg5uDz7iV2MAgF9zCf4uH8kyyzzOWjL0f4SWLTGBWGSaUuiHMLsSZfvx4v5fLFV12EInJz59ltSKBbu+oBizuy8XaT40h+CmfNXZM7/F+gegMjEqeADjM5DTZT6VCp5fzamd0YhgJK319Zai3wpTjE13+y8bZ7ujfW2PzBqd+5ANvjWH1nCA7fm9NXRIYISgfYOipndCCuuXUug5LJOrRU2dMolSQ8UV7l9AQBALO96g9nS2DlXmK/S05wiYPNMeVwRh9CbKzEEtmPA+aObrU9xvx3SAsBlAKkKcJP4Lk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 07, 2023 at 01:56:07PM -0800, Davidlohr Bueso wrote: > On Wed, 06 Dec 2023, Gregory Price wrote: > > + > > +What: /sys/kernel/mm/mempolicy/weighted_interleave/nodeN/ > > +Date: December 2023 > > +Contact: Linux memory management mailing list > > +Description: Configuration interface for accesses initiated from nodeN > > + > > + The directory to configure access initiator weights for nodeN. > > + > > + Possible numa nodes which have not been marked as a CPU node > > + at boot will not have a nodeN directory made for them at boot. > > This could be better rephrased without the negation. ie: > > "Only numa nodes with CPUs (compute) will have a nodeN directory." > I thought documentation was supposed to be as confusing as possible. lol I'll update it. reading it now, this is awful. > > + Hotplug for CPU nodes is not supported. > > Can this even happen? Hot-adding a previously offlined CPU won't change/add a > new numa node. So just rm the line altogether? > I... have no idea. In that sense, aye aye! > > +static ssize_t node_weight_show(struct kobject *kobj, > > + struct kobj_attribute *attr, char *buf) > > + > > +static ssize_t node_weight_store(struct kobject *kobj, > > + struct kobj_attribute *attr, > > + const char *buf, size_t count) > > iw_table will need some (basic) form of serialization. > originally the SKH group recommended a serialized "N*W,N*W,..." format, but this doesn't work for a matrix. Possibly i could add `N-M*W,...;N-M*W,...` and add a nodeN/weightlist interface that lets you acquire the whole iw_table for one or more nodes. Might be a nice extension. I figured there is an aversion to multi-value sysfs files, so I reverted back to a one-file-one-value file. If there is a preference for the fully serialized methods, I'll happily add those. Easy enough and I already have the code to parse it. ~Gregory