From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0169DC4167B for ; Thu, 7 Dec 2023 14:08:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CF686B0075; Thu, 7 Dec 2023 09:08:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 87F816B0088; Thu, 7 Dec 2023 09:08:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76E576B0089; Thu, 7 Dec 2023 09:08:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 68D796B0075 for ; Thu, 7 Dec 2023 09:08:42 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 331CCA0F7E for ; Thu, 7 Dec 2023 14:08:42 +0000 (UTC) X-FDA: 81540202884.07.E49772E Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf12.hostedemail.com (Postfix) with ESMTP id 3A4CB40029 for ; Thu, 7 Dec 2023 14:08:39 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf12.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701958120; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zatKX5PMF2CFxL7bSawdP7ODyUNu2f1qUuA7DsJwb10=; b=XKPFq3sXpXyQaxLErPci5kBj8XIx3YvrN0AbLvx1oAeilDN/zfOBL1N2kETbq+uaiEP64n haHOMDDLg1W4HqY9maGdRNwzhLfABC3nrYWz/PVJIXYJtgNHgTDAnzEwdAUWmfoIR0IzNx OpPfpNepQi4XELlHtIRkISe3RAOFeDs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf12.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701958120; a=rsa-sha256; cv=none; b=la/8wx5vztmrPGuGInxGkq/k10X80YJpunbIEZiYLxuesjSluEthoIcgKTuWVGGcvc83Vs ZSQJ1wye3z+XLDgbT0NY54JF5Zpi4EcLsd/JpdKLubmqdASj0/AIpaoz73WpZkkqZOTxwU xKKHyoBelgIqQDSDJviqCFK05H42xmM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6BFEECE23DA; Thu, 7 Dec 2023 14:08:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D40BC433C7; Thu, 7 Dec 2023 14:08:32 +0000 (UTC) Date: Thu, 7 Dec 2023 14:08:29 +0000 From: Catalin Marinas To: Joey Gouly Cc: linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com, broonie@kernel.org, dave.hansen@linux.intel.com, maz@kernel.org, oliver.upton@linux.dev, shuah@kernel.org, will@kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, James Morse , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH v3 07/25] arm64: enable the Permission Overlay Extension for EL0 Message-ID: References: <20231124163510.1835740-1-joey.gouly@arm.com> <20231124163510.1835740-8-joey.gouly@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231124163510.1835740-8-joey.gouly@arm.com> X-Rspam-User: X-Stat-Signature: d7jh8wbw3q4mmek7udyynsmeptrq3xrz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3A4CB40029 X-HE-Tag: 1701958119-518797 X-HE-Meta: U2FsdGVkX18IqHsGh9LDZuf/josBmaKPe1EhpksRXU6YFSaoItvuex6AOBUYYSiAHkybGHM7HjmFw0gjBe6VSINwI9k42y9u5WIAhJitkWVsEhAEnmRT7ZXYuCsxAEF3b27eBnNX4j3XGwSa2w6uWOqDL86QNbaQCv92a/K37lcv73pZlHi16xI+wCGAyZC3VBdJUqnu4vwKJKgIkRTJ1JOXzkROLC6USG0Xc+GkaqE6my24UpxIdcwUY40Iw70CW0ObEL29KNf9G1gkDw0vz6wnPw3yEt8sfqm2wVPoWWnsA9cFPqq7BtQ/A5nUTgVSpGD3ncYpwP9dwOIjwT3GrDRllO5UKZSqgoi0kh/eejj0A/u5ZXI6npozkRAuv5BUXvbAQH9j2Pt2UHzgGtNQoDO2DrQbnG7xVYgpVu4ysmuFivPqBhvEinVIGDf8RiTGCH4iF/0JYWMVrtSg60LAuURM6cGeLwHem33XhIbqLvn4kIzn+zUiB9yDrooX2zsz7XCBBNbw0VRL1d5bKnBUTT4bR5cfHE0GCUD1xRLFpcV2QiWn59oN6UuMyFyTDRLXhhese3jtlzfzuCcQsT3Fk2xyMoblhxy3DkW60Ijofeti/jh0n2DNoeK28jVKZmvEj1UlPMC74RX/Ycn268Uy9KHonc9pocZX6jWYpTogt3BABAHVcZhxYjLE/3+0QS6l8iZJoR4/UH4ZKdwBzwg0WaPCwL8EtymNLgIZxA8GPsdo+KZ05b35M4GkxdFAt8E3THLfrG5VAe8boG5P3h5cMXHmd/WFw4YPH1j9FsFJXed8yEFyW5R22vAaAabHBIZo3iCAGI/x/ezufAEdA6k8BAIVsVulcoSCZJaZFrzRQ6eNrCeSvjca7l50RmD6Qz/i8rhbop7B05E+Co35dDDciaVt2DlotSe53Gg8HszU4C4QoDfV6vfrin9wCUlvJIz1LZSZ4eZ8ld42f+Ytr3D AqsXLaGW leWnca93gFjfx/INIO+twuWnukjPxn76qgUZdJzWH5Ey7X/THcTLQ8ipoGEeZaratZrwfHh4WTXrjMZ3EFVFP+lCsdzIDvvzqHE/vjtVW2j430BszwHuO0O0Ea9pjc5yLP+RkMp8ZSDHT2WP/KtzDdVWLftfOB7ZeRs9+8kHLPIpeLIFkWDwd1vj74dgVJrAH7aNV81AMzZOX2e+Mrv5h+JzZB2k6hBHtkmTQlo/3nqMn8wwMr7cr0CQIT1jFEP4nDRNWWzGk3Zzq37A8VOn58t4PTG87+3mxz59PY6xo6JYWMzX9UF/ExPWX3LCNYKbTMJiM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 24, 2023 at 04:34:52PM +0000, Joey Gouly wrote: > +#ifdef CONFIG_ARM64_POE > +static void cpu_enable_poe(const struct arm64_cpu_capabilities *__unused) > +{ > + sysreg_clear_set(REG_TCR2_EL1, 0, TCR2_EL1x_E0POE); > + sysreg_clear_set(CPACR_EL1, 0, CPACR_ELx_E0POE); > +} > +#endif Don't we need the TCR2_EL1x.POE bit (for EL1) enabled as well? I'm thinking of the LDXR/STXR instructions accessing user memory (the futex code). -- Catalin