From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ADE6C4167B for ; Thu, 7 Dec 2023 05:46:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9CBD6B0071; Thu, 7 Dec 2023 00:46:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D4B866B0083; Thu, 7 Dec 2023 00:46:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C13756B0089; Thu, 7 Dec 2023 00:46:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AE9B46B0071 for ; Thu, 7 Dec 2023 00:46:55 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 80B1B1401A6 for ; Thu, 7 Dec 2023 05:46:55 +0000 (UTC) X-FDA: 81538938390.19.ECE52F5 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf02.hostedemail.com (Postfix) with ESMTP id BFBC180008 for ; Thu, 7 Dec 2023 05:46:53 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf02.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701928013; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=egxxoHFyDqeCA/LxlDg8JyWMVYkStRh8cbZHikRDbS0=; b=PCLneHNsTewTt4BlGxSo8+Sb1IY7LIB4zgG31Tw1PvT1CyJkX/0FhVKTEsYW3VkD3RBs2u Z//pNC3cZzDoAD7YTcQGv8sxxuuYE5GtVUNCpi0B3kCdd5YORYTTIKdnV5ZnrrmC+h6DxQ KDOcg0AkLGYpHfZd0gLE98DwrcxDs2g= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf02.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701928013; a=rsa-sha256; cv=none; b=2hqqgIp5lC4Bxjm6g3mHuwACcn1v/S14quhcPmCtM5ArDqeK86u+i9VBCRxdgFDsJVMyoR nJ6A1cab6YTUiDRXKaLha03ZqNClpgxQLeaFBEUFm9pKvkTNmNjnODy7ND8yVd4KbHkJJq NSHpsEjkAhRRr7RIjGPQU678q/3ZXiY= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1ce28faa92dso3724185ad.2 for ; Wed, 06 Dec 2023 21:46:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701928012; x=1702532812; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=egxxoHFyDqeCA/LxlDg8JyWMVYkStRh8cbZHikRDbS0=; b=tvltjvfKrtSOVXktjrkYLvOPoy7nEL2l0sAlXq/w0//nIal0NX0raZkgYcrJv6c8+q WrNRMAwOzf4XDBeTbScB0JD1G93nbzXbHPm4wtdqJr8WvgxVcFnYLBXkFZeueUmBcbFH rdD7r8NL28PO5ZZYcFzVwTeLfeD3tmzmOmUh8jcWyEFNnNCNKhaGBIlzijhwbMwSe89G abmkyp/WJHY5b6gKaeT1v5LY1Ms3MRqiuf1kozA1kN+9NN8LEJBs+fZ/HpumubynWSb9 NJ7d29y6OCeTWBQE736shBqhKZzPC0Pi/BEy6pPI/rTXpZu3US37xyJWrSMaJxeLXu4P kNog== X-Gm-Message-State: AOJu0YxvqDmUwceJZ5/aoS+TpiVJgVIXhMoMPTBBN240tlbQE9qcOqQa zc2jimOrSrSeyYeiG7ZsLH8= X-Google-Smtp-Source: AGHT+IF6vXYcdw6GXClAOhugyGgBVtuMtwXIfwxdWqT56yjqXEpfSXOgZ2/KtLitjpsLVgMAz5ioAA== X-Received: by 2002:a17:902:c101:b0:1d0:8afd:b28c with SMTP id 1-20020a170902c10100b001d08afdb28cmr1453916pli.92.1701928012478; Wed, 06 Dec 2023 21:46:52 -0800 (PST) Received: from snowbird ([136.25.84.107]) by smtp.gmail.com with ESMTPSA id x5-20020a170902ea8500b001d08e080042sm431944plb.43.2023.12.06.21.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 21:46:51 -0800 (PST) Date: Wed, 6 Dec 2023 21:46:48 -0800 From: Dennis Zhou To: Tejun Heo , Alexandre Ghiti Cc: Alexandre Ghiti , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Arnd Bergmann , Christoph Lameter , Andrew Morton , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/2] riscv: Enable percpu page first chunk allocator Message-ID: References: <20231110140721.114235-1-alexghiti@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BFBC180008 X-Stat-Signature: exkos6oxjf6fkkc3hpbnbi73a87n4ufb X-Rspam-User: X-HE-Tag: 1701928013-383615 X-HE-Meta: U2FsdGVkX18wZRnCSAm1Mpr/GEhH8TcW9kkZjFOILqSV4SrnYHnCXomneri9jS1EWaM1V89IloPKg1kgv5VzXDKJpuHqYaHkQ2Stj8ot4e/nkxAecjJP++IcNpYbJpAP60MxMTrxFWgNVAVPer7TEmgSWVxQfXYzuebhiYAbXxkaJtzXQ+2yBuvR5VgZTuQEFTi//N3x2T+LI3cJ0hQAh+dnn58jvAXwF8nKAJSpy/ZWjbvon97zCP6dIxgPLn7Y4PoX53mDpZbXsVnwGXZKOwiBIAHAuF4GSYak7NqQjCHsm+8mL+0ULyU5reCXb8jcL1bskl0U7un56T3cL/0A3f2iIuLVld0u8DpqI5JsouyqtkH+bra+x7A2UvDupuKVXK/4xb/fFv1PeiWdIWdr2dS/6Gs7R2/Rr9unNaZEmHDsvHJuXFuDtYULHythC19LL70uJ+SiEBGIJyX1G9P6bsW48rp9JU2YR1OYDsl3N4Vvk/YMbWcN2Mf82y9yXoSHoSvvLzVyhQFanDmcmMhBAV5gfAXzYvGYCLt9r+UcBZMB/Bht/sZrA+XMa+GOezksU4SruEciZqWPRZX/92EmF9o7hr/s4GEsIVa0OBjOsqeJYrzmS6e5sMqtLmACvY7j/wX5av8pdRUA7m085Re8tduXbnE2T0joInoJff8cRRyOrqlgfe6kjM/lM4syHCBvNT4z5veQN6S+gUmvzHNbjlePsM3d2Q3iLpdyutC/5MNx3MuPPRPew+uYCDmlW0+VGcGITBU93Ycj3HabYws5cz8Ctrlp8CDMgHe0WlrrYKroN/WL62Wk3xmuSlCeUtC1dLH1goho6/3Rol6K2fyfqGKSfj6RMcosI3oZEaqTYJ+lTEdTOaKETceqnUuLoBE/LLNGZJRZqbSRyd3CfLP/FVngFEMUCw0bRr4qRnkrkInsOm++bFR3ni0xj8nHFjP2KCrDCnQnP1JiP4qsIIG vJfEMS+K 1+v3d0Ghf6XPylmM/dlouBfgii8uYnKv1H/Ev3n4o/d0UkZpafrnhMi9sVd/BxZceKg1f4ugjIbMUZ5LuVde5WpGwdnu5CbbNftyNXmXqweGF1RFS1z4YJlzB+JkufGJod8EaICnEc3Nh9iWEjgp1SpCQJ70jREfG1Gci9V3zd4foNd+NUmPEjkshH9bNfO+G6GPepnhkWLK9h4HggZCgZroYlEjfVg3eWrdRIvhYDP7k+ruCykfadiVI2bC1sdNQMB4U1ffNhkN4HyTlE8W1Y+PDnHyu99SmU+ex0+jQSDz0E4bKN52dhCS7lLzbVTAAJNTMSG/sEsJ4xWZD7WLwyLfdgfPwFJ4eQ3B2P/sBjl5R3NiS0shXXJcQLl13xXH39ZKm81Hze5FxOT5/E0C5eBd3CAeiT6rZq25/ekgDXeTM5umgxQ6ulVnx1dypMYZeiga7pT1dn3gYOTtB4WAfOEXD7rxjO91c56slqRLnfNS+wVUkGYa/yqOyCK9grz5aaCuwA5QcnJJdMY76Aa66QnzQP1579mdqWEfsrdPSPiPEVDc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Wed, Dec 06, 2023 at 09:00:27AM -1000, Tejun Heo wrote: > On Wed, Dec 06, 2023 at 11:08:20AM +0100, Alexandre Ghiti wrote: > > Hi Tejun, > > > > On 10/11/2023 15:07, Alexandre Ghiti wrote: > > > While working with pcpu variables, I noticed that riscv did not support > > > first chunk allocation in the vmalloc area which may be needed as a fallback > > > in case of a sparse NUMA configuration. > > > > > > patch 1 starts by introducing a new function flush_cache_vmap_early() which > > > is needed since a new vmalloc mapping is established and directly accessed: > > > on riscv, this would likely fail in case of a reordered access or if the > > > uarch caches invalid entries in TLB. > > > > > > patch 2 simply enables the page percpu first chunk allocator in riscv. > > > > > > Alexandre Ghiti (2): > > > mm: Introduce flush_cache_vmap_early() and its riscv implementation > > > riscv: Enable pcpu page first chunk allocator > > > > > > arch/riscv/Kconfig | 2 ++ > > > arch/riscv/include/asm/cacheflush.h | 3 ++- > > > arch/riscv/include/asm/tlbflush.h | 2 ++ > > > arch/riscv/mm/kasan_init.c | 8 ++++++++ > > > arch/riscv/mm/tlbflush.c | 5 +++++ > > > include/asm-generic/cacheflush.h | 6 ++++++ > > > mm/percpu.c | 8 +------- > > > 7 files changed, 26 insertions(+), 8 deletions(-) > > > > > > > Any feedback regarding this? > > On cursory look, it looked fine to me but Dennis is maintaining the percpu > tree now. Dennis? > Ah I wasn't sure at the time if we needed this to go through percpu vs risc v. I need to poke tglx and potentially pull some more stuff so I can take it. I regrettably got both the covid and flu vaccines today and feel like a truck hit me. I'll review this tomorrow and make sure it's taken care of for the next merge window. Thanks, Dennis > Thanks. > > -- > tejun