From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED9C4C4167B for ; Thu, 7 Dec 2023 01:11:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B0B36B00A7; Wed, 6 Dec 2023 20:11:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6604E6B00A8; Wed, 6 Dec 2023 20:11:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DA816B00A9; Wed, 6 Dec 2023 20:11:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 38B7C6B00A7 for ; Wed, 6 Dec 2023 20:11:22 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 07576A02C9 for ; Thu, 7 Dec 2023 01:11:22 +0000 (UTC) X-FDA: 81538244004.08.8A6AE8C Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) by imf24.hostedemail.com (Postfix) with ESMTP id 3B62B180020 for ; Thu, 7 Dec 2023 01:11:19 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JRp4I4cJ; spf=pass (imf24.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.161.54 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701911479; a=rsa-sha256; cv=none; b=yAuQRpaikb5QTty+emMKucxl4j3obRzTf7dxX/OZokwCWaIfahkLg5ApNc3YOk/hGY6HYD L0xgfssqiIQM89p/KBmEQmBIGBlQe4fftw+Vc6vGctsuhksDERN8iFQ0tvnFwcOX8KXY7/ PZ/bKVtKtIF6aiG6U2UjoRRBmLuW7wc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JRp4I4cJ; spf=pass (imf24.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.161.54 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701911479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O2iQ4GZaNaP4TLuVf9scG6OMfAEhFr0GcB530VPLhoU=; b=kfMD06SStsdZnyo3PptJsyR6to6IFv56+dIqNVpHWanhmmI03EeujZ9FsCDPlEJjKnpWuY rLNldY/oKpN0wJS0bAUJIaOayppHcgDmk6huJTzQu5nD/4/bcUsuC9aGVHIg7Au+StnJPy wR2tlPu7b5u6bCviKG7VUyeBVmt0XR4= Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-58a7d13b00bso84801eaf.1 for ; Wed, 06 Dec 2023 17:11:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701911478; x=1702516278; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O2iQ4GZaNaP4TLuVf9scG6OMfAEhFr0GcB530VPLhoU=; b=JRp4I4cJOHcK90tVK7GOIHcY5sYyAy4CSpwOlwzaViKrC47yMkaSlPn7BtvYTeJLvX fQfK0Dt9jHcMeiiA+BxvwzGaROUiqPzA3wm9qBkcgDBUOraAj9WHXU/PebGoL/MVk0Yv vQnpCtbodFqT4+Nn3rJWDvfz0PVnNeOWLMvTjVGIGiKvlWp4KBGsO5DPUkJbCChcQDEY L5Yv4Nlnpf+C10FF88gnkL68Dm9uq1CB2/Dav9FcClvwtf1JkCK+q40amHIt0tjADQ68 sEtZc2CGz+qpDhnX8KBnapl6OQRP+S+xY+q5crWt89e5W8OCT/COINgTXbouK5jnJWPr mISA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701911478; x=1702516278; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O2iQ4GZaNaP4TLuVf9scG6OMfAEhFr0GcB530VPLhoU=; b=WdhSlOzQd1edvh8AKTW8DoRrxEtTD04ENnvIDURhGukW5z4TTHpVGIZuY60rxITm2D PpZ3wt1/ah3kW1rCPjrcxxGoPEHzhJIloedR6aTe1suM4Q741eei7WXS3SeVkwkqYDMN TGoI3pbJZQ4usEYcaQi/fl6rZiPJMsSEaek9k4vlHMY5DFrE264TuwWG+tNigpU3suAe bs2gn5/l83XMqy8A6AtjNkC71qJO036vLOOxJvntaS0Fu3SOnQxfFNbHa6qUv6wdCFU7 cUUcWkKgIimwhR5DtWZIu046r7RiAm29SPrhb2llA3NqZAoAYFQevybuE4dIzm1oDags Bv4g== X-Gm-Message-State: AOJu0Yx8QaFA4DcbizUIcd83+Q5s1QR6ak4SsTJR2TdSLFz2a6DR03ty 32J/2IV+XJjocg+kvVCk64gqAf6LztNd6Q== X-Google-Smtp-Source: AGHT+IGc9dkQ2KVuG2CkWKzx9T1jI0zfnEUmwYynupuHvD497P297MjLlX6Fmpv412ssI2djQI620w== X-Received: by 2002:a05:6358:4320:b0:16e:27b5:3b25 with SMTP id r32-20020a056358432000b0016e27b53b25mr1981299rwc.31.1701911478109; Wed, 06 Dec 2023 17:11:18 -0800 (PST) Received: from localhost.localdomain ([1.245.180.67]) by smtp.gmail.com with ESMTPSA id p2-20020aa78602000000b006be5af77f06sm141705pfn.2.2023.12.06.17.11.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 17:11:17 -0800 (PST) Date: Thu, 7 Dec 2023 10:11:02 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Roman Gushchin , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 15/21] mm/slab: move struct kmem_cache_node from slab.h to slub.c Message-ID: References: <20231120-slab-remove-slab-v2-0-9c9c70177183@suse.cz> <20231120-slab-remove-slab-v2-15-9c9c70177183@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231120-slab-remove-slab-v2-15-9c9c70177183@suse.cz> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3B62B180020 X-Stat-Signature: 1f3cptgwn5jpocj9zgpacks81yqjojiu X-Rspam-User: X-HE-Tag: 1701911479-881308 X-HE-Meta: U2FsdGVkX1/4UqmIz/Uco6bckMjo/4aut800gc+VgOyadTUJz1nKb0Fv609m4Mg3LXMICDg4QreQjXeRW5DUUN+lUkhc6NTCW4SueUoW6LNrNrvnQd4P99eccURzfywupSUvdkDaxtUobM2Xa/tv52TPjFpRKw2DAEUl/RG9BpOzEMNsVYIQrjL+D3Leu5fU4NrPp+KzF1RH1YirAPIACsTn+N8+TXIuo0xSJMSmJtUWMGHiwaBOxXPCVeJACiT8uU3m7Ehv/JxKUaiJdkA8kHdzKI77welibAW1OU9LBi6wmqPiMkdBZwOLoOItir/oSrswJnlhFZN0N8FQ4zjqguRvaHqJ1QJSe0op68Y9QLmqHI/oT0TqY471J6GiDGiMQEGeun97xoDc5ZYqHHCUjqvOZmcbp+MNkcd5zBBeJY7JHkGmbtId4j6oy3/zAVxJqtnrkA6eoGAPBPmePzfQ7num8Y8e3D/az2UIHlsr6UYa7hN0+ZPPD5yV0F+ImMu7gLLvF3sxbruDGtYz5KI+INqzugAJIOFjisw4unOmFu+Lej2uWwEFOJuJQJsrAM6lw5sNvcvZeGcOgsasepjc/1W9MhT9BrLHH/X/H2Ue39TmNRDX6oLN7ErFP1PkU5D9Z6pJW9tlWLlK8BBNprHuPNrb2e9ifkbSdshtqCcmzg6uoaJ6Q7JQp5TmTQGyq4QgxNLMP60sswTmoy7BkiqC8PfGtezp43PKSX1oJVHqRZv8o19nCZZ0WDkuVwlpiqu6Ij9yJ3AIjSj4bk+LU/Oc8iZKaNJ1V/EQjuFBLDM3gCNHhupFMqdfZM5pF2rTgH1EPtecwaxnn10usP1L5/0KviGgzqKgSZG+G5l7s8GgROvSplpzF7fBM6hRzMMOrgoqITRbJzC+UNHMPLjhecHd8mC4W5vRDUWvb8B/VNJbkCUuJ4+gSkB7AhByW57czP7RYpOIHEZ2ooRwaoiKlqj QEjyy/sz 9x+jrKC12f1FmJ9TfcBGO0Fjqhm3qRvcg9k7jp/0pxirDLfLF3hIQTgFB1IBt0ynEX39muOHsSeXNhjNgf1oAxTrrySd0xcwMGBsrnXgGKr59YFc2vLzYHrd916apbMiNEQnmUlcpdfZcryRwmB/HLEZPVHVOKXNnSXjMirxpFjSl8vaGyYi3EghTtEA/ZUSZmjNnQNATqGpBRWbOG4yRp9lkr1OyxhFp/jMCYpFO+GP6AueCJKMxqFDm/UCaKmoRGrVrWAgA6LEmd4oYOtDKS5onr7hspEBFlMhFhCpVPiS+pfKClc/OXrZgHgv3anpCgMqPoouRRXT99//ERMILi6Nmv0UzTnfUKexhVKY5jhYnSYRn/GaZwobnghsQzG86rb9eUxcpykh6J3PJLBy35cBEb2wtbEr3Dy+DUKRNiww/n1stX9L9ZetwgdE3QPYNSnq+kX+DLeEs9gKQ9UabN9kxrItBXQY8Br/DLT6C4M2LP03UcI02nvTbMZ2kFaI55TUl/o2dMxb+PMe0O5LVRfP/EDiIEkjKBy/PhaOwoALUyS/FxB48JnwKjPaI+eUmEUb6KJ3N3yxQm8KM5BBV+MbbQnDbwqcE5podfG/7GS0ml4FBNiMI3dBoAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 20, 2023 at 07:34:26PM +0100, Vlastimil Babka wrote: > The declaration and associated helpers are not used anywhere else > anymore. > > Reviewed-by: Kees Cook > Signed-off-by: Vlastimil Babka > --- > mm/slab.h | 29 ----------------------------- > mm/slub.c | 27 +++++++++++++++++++++++++++ > 2 files changed, 27 insertions(+), 29 deletions(-) > > diff --git a/mm/slab.h b/mm/slab.h > index a81ef7c9282d..5ae6a978e9c2 100644 > --- a/mm/slab.h > +++ b/mm/slab.h > @@ -588,35 +588,6 @@ static inline size_t slab_ksize(const struct kmem_cache *s) > return s->size; > } > > - > -/* > - * The slab lists for all objects. > - */ > -struct kmem_cache_node { > - spinlock_t list_lock; > - unsigned long nr_partial; > - struct list_head partial; > -#ifdef CONFIG_SLUB_DEBUG > - atomic_long_t nr_slabs; > - atomic_long_t total_objects; > - struct list_head full; > -#endif > -}; > - > -static inline struct kmem_cache_node *get_node(struct kmem_cache *s, int node) > -{ > - return s->node[node]; > -} > - > -/* > - * Iterator over all nodes. The body will be executed for each node that has > - * a kmem_cache_node structure allocated (which is true for all online nodes) > - */ > -#define for_each_kmem_cache_node(__s, __node, __n) \ > - for (__node = 0; __node < nr_node_ids; __node++) \ > - if ((__n = get_node(__s, __node))) > - > - > #ifdef CONFIG_SLUB_DEBUG > void dump_unreclaimable_slab(void); > #else > diff --git a/mm/slub.c b/mm/slub.c > index 844e0beb84ee..cc801f8258fe 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -396,6 +396,33 @@ static inline void stat(const struct kmem_cache *s, enum stat_item si) > #endif > } > > +/* > + * The slab lists for all objects. > + */ > +struct kmem_cache_node { > + spinlock_t list_lock; > + unsigned long nr_partial; > + struct list_head partial; > +#ifdef CONFIG_SLUB_DEBUG > + atomic_long_t nr_slabs; > + atomic_long_t total_objects; > + struct list_head full; > +#endif > +}; > + > +static inline struct kmem_cache_node *get_node(struct kmem_cache *s, int node) > +{ > + return s->node[node]; > +} > + > +/* > + * Iterator over all nodes. The body will be executed for each node that has > + * a kmem_cache_node structure allocated (which is true for all online nodes) > + */ > +#define for_each_kmem_cache_node(__s, __node, __n) \ > + for (__node = 0; __node < nr_node_ids; __node++) \ > + if ((__n = get_node(__s, __node))) > + > /* > * Tracks for which NUMA nodes we have kmem_cache_nodes allocated. > * Corresponds to node_state[N_NORMAL_MEMORY], but can temporarily > > -- Looks good to me, Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > 2.42.1 > >