From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAC69C4167B for ; Thu, 7 Dec 2023 00:30:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 755546B0099; Wed, 6 Dec 2023 19:30:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 704B16B009C; Wed, 6 Dec 2023 19:30:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A5A26B009D; Wed, 6 Dec 2023 19:30:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 41D016B0099 for ; Wed, 6 Dec 2023 19:30:35 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1CB15120215 for ; Thu, 7 Dec 2023 00:30:35 +0000 (UTC) X-FDA: 81538141230.07.C36965C Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf09.hostedemail.com (Postfix) with ESMTP id BDCB514000D for ; Thu, 7 Dec 2023 00:30:31 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bKJ0nyKY; spf=pass (imf09.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701909031; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pUILdXO0fAmIum4i0LjaIhGHTq4M4euUAAZGlBJTfMI=; b=IN0MgKOsSs7sJL1ylNediN9Y6pA10qQiz86XKP9YWqltsbkNGsfXuJYNIyINy3M6PX3jb5 BBrM8pxRgeQC4vUSNWZ4sg2GteumWiO23xiI52PTqocatfeliJ7E5U9yQSDKE8IGTThc5S lsBgO3Ub3uOeSE2fesraiCe0IAtC6Oo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bKJ0nyKY; spf=pass (imf09.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701909031; a=rsa-sha256; cv=none; b=W068elcJ+MRTyhMRWlTHjlXM7cclY+i4cWwvKSJiZR5kHU6PVxupMUM8IysneZxObucXkP HzWBfHrdJvQv4oAxZoONVsTkU8/s84ooewYzqmjDXvsy09MLfbaey7mWrTlGDbAF2ACqs0 QKpKZgzfUF4eb5YhNzd/kFpKoehOZXQ= Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6cbd24d9557so78149b3a.1 for ; Wed, 06 Dec 2023 16:30:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701909030; x=1702513830; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pUILdXO0fAmIum4i0LjaIhGHTq4M4euUAAZGlBJTfMI=; b=bKJ0nyKYlTUo36P7hlwgbN4sbv4J2+GXbVc7u7M64tksedVC5+lWJLnwinA0yAGZns EZLQ/aeBux0doPuZk89E5exOCCScuw8RcdArlztTET8OikeNKuHeRpfSHpWWVG4illxy qGcjKNfm2UE/35vX6k1qWun8jDWLhrAYwJDq36+qw43HzA/HAWwaVUUC8PH2T+AV1GbK 0r35WUnU/ZeFE0CjQeSebj5dpMxXmvQkkjKLLr2Z2b76QoYOj9w+V7MJOXj2fzHH6xuQ FYThNQlHcDYtZEjk70XvSNVG8igz4ffYJuFuzmmsNJzZJroSyYU/3xtO6A7wqWST94y4 bHyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701909030; x=1702513830; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pUILdXO0fAmIum4i0LjaIhGHTq4M4euUAAZGlBJTfMI=; b=RheXMU9myIfI40qtenSf9SxiEp3PmrTi5JoU93o9Ui777NIDv2QymuhVoX4ZNjeVB5 b3pMKN/lX+AhssQ043AaG6ArKbcZ9pdxikXz4gWA7t3kISoieb8QxcNHs2Az9APO8DXo 3WjvgVEGFRrw11tlHaKfHUk0igj0FwiEgO+N+ymirU6OGqly9ZTv6fFptUewJdZHwjv0 AD5jPmxuHxRroKkuqI/WFwFn0gMjkqtL1MwVWKOwe7qfxuEIzafPQNwg8ZQsAyR25nZW MjP4LQHXp+9ds3UIjBeloUAigaqteOEu8xSwSf1/4qGdaWetC7drxdK5JJGAqf6YMpG1 FCIA== X-Gm-Message-State: AOJu0YyzeqG+parPNKibanS8jl6rsZnSTwCpgN2qLsVNRL+m0qgqw2HL 5M7vsL4BvTAqu3xCHstkkVs= X-Google-Smtp-Source: AGHT+IGNdRr4yYn8X8E8TUhLrtQlJNH4KI21LBAMZQqyY0t/4ywu4K0f2WjEAimk9RqDqbbbR0tJkQ== X-Received: by 2002:a05:6a00:3a1a:b0:68f:a92a:8509 with SMTP id fj26-20020a056a003a1a00b0068fa92a8509mr4897945pfb.7.1701909030344; Wed, 06 Dec 2023 16:30:30 -0800 (PST) Received: from localhost.localdomain ([1.245.180.67]) by smtp.gmail.com with ESMTPSA id n19-20020aa78a53000000b006ce7d0d2590sm120723pfa.0.2023.12.06.16.30.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 16:30:29 -0800 (PST) Date: Thu, 7 Dec 2023 09:30:15 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Roman Gushchin , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 12/21] mm/slab: consolidate includes in the internal mm/slab.h Message-ID: References: <20231120-slab-remove-slab-v2-0-9c9c70177183@suse.cz> <20231120-slab-remove-slab-v2-12-9c9c70177183@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231120-slab-remove-slab-v2-12-9c9c70177183@suse.cz> X-Rspamd-Queue-Id: BDCB514000D X-Rspam-User: X-Stat-Signature: 7hx9c78rxjmhsxpctiqwb3mdaixo49b9 X-Rspamd-Server: rspam01 X-HE-Tag: 1701909031-81946 X-HE-Meta: U2FsdGVkX1/dvsCEDrthGtXhUc3chY2IUFgKyxIiLd2VV4wBp4MaUPIjkD/ZIypRRvWv4pV+3kx3FwKApGe7gNyurbkdvf2sJoPgSpOWRVUUe2/g0yEuvR34jt2WRy2hJVSgXMCRj0Uo6oFNafGmYTNT2WQlzJWbw/aR0iQogPQNuxlVZaB9k/cncDuDW2ghykKT6srWBkbu7//84H3yd2oCNCkzMXoLmj2fyHFO2Ko/RoRDKD2gH4dMVfR740hz7T4lVrS9CCDfMpYTVWiq9vFnh3PXOYXzJwYCLGBJHI9nDHzLFEOL65OWHuK13BH8kYD7+EYoDWoDczEEXGTrF9wW1Ivq/s5QwDVYMVOQSUWlfu/3sPK4d9usw5787ZGBh0+mRbc5dfY0seBfsdDx0OkyKMYRrzWnjLD6T1UeZRM5GbSMOZp/rERbFTfN0yB02bQFemo4dbYHoPJWQPe0HeP7ZXV5L6+Gzmw4L0Wi0ahpNBuAJ/a4A8LOnlmGDjVYg1liksC8I8rbGRIjO4MR8ys3rOHvwgTm4KiyR5F1pfnJBedzNAonl3TFGiWGrUDZmMWBDr16c5vVH7AlZSLPIz6dL0g0WS4RM0qAvDskWHVmNuEhScaIRHLKoA1BwVCdjHElin28QL1kfJB+gCdUmMBXRrDYenUCgzSOO0RsqVewUwZAqqNS7tHJZvzTSOrdRWxtreAISMYsNH/vK9FdTE83+zAru1IpVozQMMZvM0pVQxuTHX3LhK4JbIyY+FxVeUtVE8HwWHZgod7bi/ASzk0cFBB3xnYqG6aeDtRXPnwnlT3HgVbu9mIHatzC3ad5TgwPtpms+B42T9kCXjS3YyW4A7br+JTyB5VKXE5/+m41Y2l8yltYFdyu799sj6Wjc7hZGdZklcrjjwBg8B5xeioyjY2zdyGBE1oOUmuI6btDBQPR7Xs9e9gNyKY1dsKw7i0r/OxSD/lYVZOq8Gm 8wycLOkK wWW9gdRuITlFLMSBsMGQ8D+EieH2Z5VMuLMG2zRxTzs2VAiAaw5sZjIZ3q+Ca9PcpRClPl1WOZglH1ohE8qBg0Nu1bnelGBTe0KbOjmHWcyTn3RZy9ciVjbHaBzgcVNbQi7RWKbVQKq7+QDtIab76NX/iazVL3/aq5AAPylIpWN2OJoRWg8LLcZkTpij9r91yO6fW2Cy3KvPbJhAVQrhE9NlPcVUEoXgXkMdTamlHXYmAOSaC6u/zyDd+G3Fnj4uaScsB5he0G73j8fRULUQLT462Vjz2rv1fhwPz3U9JPOCf2s9pKOa/ja2V70sg/wBuDw0nxZmFY/1QZg0GuKm0nAXZz2x1NK2Q0bPRNdYV54/YoXOGTcGkys1i+/20ASXv16TvQwsQvFlVyfYw6t86hflkeH3V1xGx9miuFW6w18QZpq9NPRb3CSu9vDDuzoaGj5gPruVSOc2hC4/WbD/iyUSYJUbQu4VhlYgR32OVpGryE18T+iP6g6/qPD7Ye5t8TrQjrRa1L0thuto= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 20, 2023 at 07:34:23PM +0100, Vlastimil Babka wrote: > The #include's are scattered at several places of the file, but it does > not seem this is needed to prevent any include loops (anymore?) so > consolidate them at the top. Also move the misplaced kmem_cache_init() > declaration away from the top. > > Signed-off-by: Vlastimil Babka > --- > mm/slab.h | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/mm/slab.h b/mm/slab.h > index 3a8d13c099fa..1ac3a2f8d4c0 100644 > --- a/mm/slab.h > +++ b/mm/slab.h > @@ -1,10 +1,22 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > #ifndef MM_SLAB_H > #define MM_SLAB_H > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > /* > * Internal slab definitions > */ > -void __init kmem_cache_init(void); > > #ifdef CONFIG_64BIT > # ifdef system_has_cmpxchg128 > @@ -209,11 +221,6 @@ static inline size_t slab_size(const struct slab *slab) > return PAGE_SIZE << slab_order(slab); > } > > -#include > -#include > -#include > -#include > - > #ifdef CONFIG_SLUB_CPU_PARTIAL > #define slub_percpu_partial(c) ((c)->partial) > > @@ -347,14 +354,6 @@ static inline int objs_per_slab(const struct kmem_cache *cache, > return slab->objects; > } > > -#include > -#include > -#include > -#include > -#include > -#include > -#include > - > /* > * State of the slab allocator. > * > @@ -405,6 +404,7 @@ gfp_t kmalloc_fix_flags(gfp_t flags); > /* Functions provided by the slab allocators */ > int __kmem_cache_create(struct kmem_cache *, slab_flags_t flags); > > +void __init kmem_cache_init(void); > void __init new_kmalloc_cache(int idx, enum kmalloc_cache_type type, > slab_flags_t flags); > extern void create_boot_cache(struct kmem_cache *, const char *name, Looks good to me, Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > -- > 2.42.1 > >