From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1531EC10DCE for ; Wed, 6 Dec 2023 19:00:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5248C6B0071; Wed, 6 Dec 2023 14:00:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AC726B0075; Wed, 6 Dec 2023 14:00:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3265F6B0078; Wed, 6 Dec 2023 14:00:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1DEF66B0071 for ; Wed, 6 Dec 2023 14:00:33 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BBFA212017C for ; Wed, 6 Dec 2023 19:00:32 +0000 (UTC) X-FDA: 81537309504.14.079C3B3 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf02.hostedemail.com (Postfix) with ESMTP id B50898002A for ; Wed, 6 Dec 2023 19:00:30 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="R/8zgh81"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf02.hostedemail.com: domain of htejun@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701889230; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gzbohbzVePtQAWojGFBvS0mVM42OxJTLPxt60AU1LYc=; b=DPwSOap5Y/vPdOV2wUbYxn3Wo4mORCSY+r4YDiJkC0Y9sfSxBEmbiFmLrD4ZXMCOZ8Gwde M0cRP5TrPzPjMrkK62y6kix/FVOtrAtk4a0J1S/aVU1M49uNUFW1iUUvD2tggQF39zzNOY TF4FzHRNrmhkXvGPsmiAT0WFlMwmB/8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="R/8zgh81"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf02.hostedemail.com: domain of htejun@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701889230; a=rsa-sha256; cv=none; b=ySU0XtnexpZZro49aW87EyoQ8W8LbitAOMRaoTfbcllpmxbtSfPCaJCEWdQz49BJNGDmg5 tO69DONLELfqyw/3VAg06Jdb9Sen72zZgoY3ER4BWTXp0a0VTeqfmYG07mFV3i2b1HmfOE AwAOj/ojykFy7yag2ub+jEolBWzRHvo= Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-286ccf660fbso161099a91.0 for ; Wed, 06 Dec 2023 11:00:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701889229; x=1702494029; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=gzbohbzVePtQAWojGFBvS0mVM42OxJTLPxt60AU1LYc=; b=R/8zgh81MT88nauiVOV8QVOjHGE1dMrB2FljEo03f60dsiEF3+LfXfN/tlbx1z7GpN nDYT6NSRfPC9wj3O6K3hZS0zstUcgo9PosPMFxSr8UGvnUyyGEl9wQnMxUlAq10l1wxG 95ZJeN/nMJVOpWCg6LitYTutWN4uhaBwmLqLX+m+lT/scosdWvHQWcLCUV01XNr+UWEB y7wD/CtXN7T5Y2a4o818wiiwgvkk/B+wXNxwat5OnRp6QAJaJNbcgeaKCtXS1RZgEypd H9lwBAZfB6DWpCI+CjQP0pi4mi4J9Mh2f2V6BuIGlGLty+6M3Mauo0JAeMXLPQqqfCk5 Fi3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701889229; x=1702494029; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gzbohbzVePtQAWojGFBvS0mVM42OxJTLPxt60AU1LYc=; b=d3cgm42QphjB0SaAeKmoWp08qm+V/LQIm+LNXS7TGqODS5CWn+38I47keOw7LafyHa wf+JmR9mdj8ZF3UjwogSyWDC8oDuDEB+KgVzoWuHAogbHw2hRtyhaZvQrIon3sm9m8BI g5rH87lEP45mQIEL89G+zFE1rVlVDqW1GW+kgyVikrAjMlJcgOxUSE3IxdE9kUIdtQCx 2cSeNl5CXuvXPj/m2+aa3YLiHV1UuO9Or4PkHekHbG4XNolPleU3lQy7oHemmmWlrDOW dLMWt4rSUhTy4eXntVZJFt6oO9uQkjFwJupU6Pg5YDjL4b0MXRpkOL4ZGRkIicQncc7d pghw== X-Gm-Message-State: AOJu0YxRvV5K5eE8dUwnWcWUT3rN8HdU7yLdeha5yXynpdZNs/9eGviU 7iJYzpY66k5mkOST7uCAmbE= X-Google-Smtp-Source: AGHT+IGt2RkwoEJvnNo596uficEOJHOXr2g3TtQ4DOJL5NzM/DY50pjdwYSQUW8PI8sB4O4FfCwApg== X-Received: by 2002:a17:90b:38c5:b0:286:aded:d5de with SMTP id nn5-20020a17090b38c500b00286adedd5demr1064920pjb.15.1701889229200; Wed, 06 Dec 2023 11:00:29 -0800 (PST) Received: from localhost ([2620:10d:c090:400::4:27ef]) by smtp.gmail.com with ESMTPSA id w4-20020a1709027b8400b001d049cc4c9asm169921pll.7.2023.12.06.11.00.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 11:00:28 -0800 (PST) Date: Wed, 6 Dec 2023 09:00:27 -1000 From: Tejun Heo To: Alexandre Ghiti Cc: Alexandre Ghiti , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Arnd Bergmann , Dennis Zhou , Christoph Lameter , Andrew Morton , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/2] riscv: Enable percpu page first chunk allocator Message-ID: References: <20231110140721.114235-1-alexghiti@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: smb75juqk858aet39ykdj7qpcipmm4zc X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B50898002A X-HE-Tag: 1701889230-467280 X-HE-Meta: U2FsdGVkX18KpQG4Z4TOGAx4byfPg7yhm8ekFGRylAzqIj3xMFg1tz1SE0MlofDQebCfuS6lTrDLVvSsei2si65Jnixq9+TBYfh7ce9o9V6LOfoIG8EmV8frMB2041xUygJ/JDkEkAn1OgwQQbID8kJh1lYMk2lUBQIoCKQQ4TPZ1mIaAtRvWxx2bNfJj2Pu83TmQSuS0Ta7xjhAw0tngswUN+fwyceiLgcKVcPaIUWFkDeLAixJWFK7g2qPpeSYqfVpZ8ZmNWQmGvm332W2+LRDksCO2XGphxdsskrS8pW9FkeLY8LNglBokBncQ2bIGuixi07cdCPvLlAuStrbW/ruBXLTyFzGuopguihluoKIwT5DfYHuuSSih9u8hR88Nfcew7M6gjVaKYo326AzDMvaMa4B64LIlClIcpAJfFYaaHM6NILWJYwM6b5PK33LXn7107MEjUTEvl+WAEE/6M2yul2DXd/T2V4Y56BFtqBmL7ca4h/qNkyBWHsx4IHPz7SnARye5Xmm/dYrwMbLZlMQAWhikZ8cagk9XQWwihAf2VbLiVsetwFQBAV4zpzZabO9E0hORvQyC7ii9kWmLGslzQe5stAbQK5TkWnRYb+ozpu8fkt9eShUXI+ExeQnGlOPBbBcscLhUTn2rAG4M4g3IJpoYDT+v3ICVEqYl+9VVJX/6+CIMOlwQaumJMEFtTE71XI0pExPRA4MW4VCRCxASKVIOfC0lrJRUA2yzV65+FQD3OrEWbvB5bZDEHAYLSLBi+ge6JySVg8gTroMazL746Ffud1D9WILRcC2VjBszdTpUg6TC+/tCZb5oqGvxNV/kk4ar+iNvw1L+fSgee1ButrqHAax0ZpA65kzJYCJ93XMI29EKm6po8binN/HN1MA1fwpmreUM/DU1VYccgu9rH0j7SRdWSohrmudVEcybfBFRbAYTgp04bxUU6DzU9AIbIJkEplYfksfE6K 4Q+l2kY2 o/ELRRPYCvXIpL1hNpDSfaOURlGZXHXXtZHL9BiobpZYUL1ZWoRxnUm+wTsvtOYYfkrd7FMtFB4eVaZBHCbmkaW8Hh8i35OdCatIyw9U1dNDXQfhCCBozfzLUjwKRAONddnVq8X7rxo5sdBPzisPuBL1KE60a9mB0a1MUF4QMzyB9j7URlLFjxV9woKEShU68tpIJIZstdGWAVRfT/+brMNd89H+jlQXf4iN53LHb8O9GyUElaNlK3CQuDXbSGIUJPvYHUTApaa8uskEAcYAciDdQTZER1lHy8YlXa7LEDemsBBp2azU0Ws/KMR+gV1yT8eAe6XxL8/MDotdfmQzVZ1p3ILB7YJ7UhNnuFdtW23ja21Gs7BEI8JhwUdr7Gib20mtEpd0IydGcdGptODXu8yroZ5xAJvRveQ5KZuZoOoZEN0hYizuCedX9bIEIN4WJPOObZzlJxStIU2AUCz4Uqy8XUIhHIVzs12LUc/yoxFTvkSycZ4nMwKkrhGAa5xFdHGv8ecqB6Eq6QOk+kSoXe8rpyw1MCI2pVNQXLBES9DufHScQ2eUV6w6dygVxrDafCi3iIKpYOBMaOCCUGVETH21VWPXXAo5Shm2gpXPTrpp4GPNGNX1Y+N8Eih/d3rfZhRfEBgnprDYA4aTPGeQ9aAYGDuD+x9WfO43aOfBaBfHNo/UxyzXIiPU4Kw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 06, 2023 at 11:08:20AM +0100, Alexandre Ghiti wrote: > Hi Tejun, > > On 10/11/2023 15:07, Alexandre Ghiti wrote: > > While working with pcpu variables, I noticed that riscv did not support > > first chunk allocation in the vmalloc area which may be needed as a fallback > > in case of a sparse NUMA configuration. > > > > patch 1 starts by introducing a new function flush_cache_vmap_early() which > > is needed since a new vmalloc mapping is established and directly accessed: > > on riscv, this would likely fail in case of a reordered access or if the > > uarch caches invalid entries in TLB. > > > > patch 2 simply enables the page percpu first chunk allocator in riscv. > > > > Alexandre Ghiti (2): > > mm: Introduce flush_cache_vmap_early() and its riscv implementation > > riscv: Enable pcpu page first chunk allocator > > > > arch/riscv/Kconfig | 2 ++ > > arch/riscv/include/asm/cacheflush.h | 3 ++- > > arch/riscv/include/asm/tlbflush.h | 2 ++ > > arch/riscv/mm/kasan_init.c | 8 ++++++++ > > arch/riscv/mm/tlbflush.c | 5 +++++ > > include/asm-generic/cacheflush.h | 6 ++++++ > > mm/percpu.c | 8 +------- > > 7 files changed, 26 insertions(+), 8 deletions(-) > > > > Any feedback regarding this? On cursory look, it looked fine to me but Dennis is maintaining the percpu tree now. Dennis? Thanks. -- tejun