From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66FBDC4167B for ; Wed, 6 Dec 2023 08:28:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE35F6B0092; Wed, 6 Dec 2023 03:28:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E945A6B0093; Wed, 6 Dec 2023 03:28:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5B686B0095; Wed, 6 Dec 2023 03:28:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C74606B0092 for ; Wed, 6 Dec 2023 03:28:38 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9263D16013F for ; Wed, 6 Dec 2023 08:28:38 +0000 (UTC) X-FDA: 81535717116.08.CE25388 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf01.hostedemail.com (Postfix) with ESMTP id B5B3D4000D for ; Wed, 6 Dec 2023 08:28:36 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=V7ZVm5Ff; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701851316; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0OhTf7i4X5voZ/FZ2Ct3sZZmvFDR7n3hZqKxzvAgYhg=; b=QEGHq0D0aWhUHOsfohgFxBojmnaPbAD/mFHIqebB1KFDpWv4/FRcy0OdF7emMuXpTD/mw1 mPxYc8epdR6+IYfPUEqsODdBSAgOFo0X3qOj0EJKy20N/Le1OIu8Uqu4ALD+uspHUuRUYY Q86WYsTy5XMpzN1R0u9ju9my5KbaAXA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=V7ZVm5Ff; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701851316; a=rsa-sha256; cv=none; b=F9nO8s+zDKO2uEzlGsu+4H/ZBGKf0lCNXypGj+ja7bfkxz9vqYndyiXL/nza5JErIBTBX6 IHPdI8gBpFzpsfzbXN8jlKaf5lobWmoQHhkt73/pPGkyiIEuTC+vODIZEN/2TzdJ0tZKat e9PgClZlagQvSkl7ZO1erbY651xpb/Q= Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1cf7a8ab047so28451655ad.1 for ; Wed, 06 Dec 2023 00:28:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701851315; x=1702456115; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0OhTf7i4X5voZ/FZ2Ct3sZZmvFDR7n3hZqKxzvAgYhg=; b=V7ZVm5FfGgR5EtFGF6pAcoTjLVBqZAYA1kUj1G5pqSI5N/sRlDISAtie7q27QvD6Ar JZBhbWPFhDOMpR+qtjR5YzcRzhtIxnByUDDnep/9VTy+0oBoBBgct3CA7rEIrE6paGiD gfyzpwkFN2Wh7v5fMLYuvRds+n3MQ88Pe5bVv9HpySMR0erSOa2xoz/MOudjij5AJ2cA qTUVMUgSUD7VDZY016D3MLepsFZDKrESIdfP2mDVwVdAhID68SHrO1kYdKuAXm0TQ8wE sKWkR3JXYrKAlWFesR1ktgSqPYLTX3GKyEPBvKOJFXfTWk2OqonOPbd00oFCoi66lmt/ RASg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701851315; x=1702456115; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0OhTf7i4X5voZ/FZ2Ct3sZZmvFDR7n3hZqKxzvAgYhg=; b=Z0Jf0/+v+ptxLELaN0Cjqcp5iqTqW80Ljc550xAyvXTV28wSqMNxoq0Xar+Wf7/g0j ZMWQGnBXn6yJIpYY+mIP4jQqi9dVvR/tKigyzA0O4iG5d8Os8zMAytO3gmCVkZr1OinB YA9bb38DMH+aSUE7b0HwDCzZ9LmFgEZlhfhdrZ+fPX6byprLsYj3vaEPOqH00Nc7KBWw wURT+/OOeCwCZBIr9ialYkupRGU+ufH4JHF03H5BC+f+sBmo325CGkEfTLwT+5Vw2ur5 mSbHo6vfeYS6mpn/wfdtWHerqFBp+rCPEcvI7u4eEY8vVI28LXDl+urpZlIZiJL01ZIl tUfA== X-Gm-Message-State: AOJu0YzfP01i7izOmRi5bEadEQ2RN5GXEhRrsvHma9n/+rHUi+X9gk37 acIDKk/EzvbfjXDh6zRddPc= X-Google-Smtp-Source: AGHT+IFqRZUz1wHsOZhDAuhXNdehT7gk/BqvAG1rf2oPqt3ua1QklOCxKxn+QGSG4okcERsqIR4NEg== X-Received: by 2002:a17:902:7b84:b0:1d0:6ffd:836b with SMTP id w4-20020a1709027b8400b001d06ffd836bmr260600pll.118.1701851315542; Wed, 06 Dec 2023 00:28:35 -0800 (PST) Received: from localhost.localdomain ([1.245.180.67]) by smtp.gmail.com with ESMTPSA id w17-20020a170902e89100b001cfc2e0a82fsm11474978plg.26.2023.12.06.00.28.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 00:28:34 -0800 (PST) Date: Wed, 6 Dec 2023 17:28:18 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Roman Gushchin , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 06/21] cpu/hotplug: remove CPUHP_SLAB_PREPARE hooks Message-ID: References: <20231120-slab-remove-slab-v2-0-9c9c70177183@suse.cz> <20231120-slab-remove-slab-v2-6-9c9c70177183@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231120-slab-remove-slab-v2-6-9c9c70177183@suse.cz> X-Rspamd-Queue-Id: B5B3D4000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: u5c9yszht7ik7b7cs1nc1k1fi7k7mbze X-HE-Tag: 1701851316-957843 X-HE-Meta: U2FsdGVkX18PTScogAjLznfN+NLFqOz5hA8A4+1TPZcpC0ocGuiZXKpHTlNAJ4fGsRGlo1nuldML+9daUWunCrMgYFtGRae2S/g9IjunZUS693Q09yf+Qvu/cCK2/QnT+xllcPBRl2hKgPstDpg6M+BH9/mzTW3SpQ3v5CpmeHrJCz4QCLl8ThdPYPVJWHK0nEBllcV13f4RKp8/uPIxGnjJn94SHFNYMzIWraEdkYdXWaTTsQInAC590VpO5Ny88DaIRb9VoHqUccfRrGFzYGLKipZ4XYJh8Ai35sIsu68zLe36wAPa+W0+QpbrsWIz+mZwWj7iDBTSVVG0clkjulVCRhs/+cZT3g6j5Ap2oA9Revp1V91gnrg0Hwv5a54DCzMl/a79v0mja//QyzNcwsNj7cakeu0/MJ52b7KA0o2yYBXCGCxXU/uTGGHB2+sB+C6YJlAJ0g2f6FLuXLWS/4YZA7qYtpeL/7+os7NR2gCLDihc6LyQ1ffY16wxfb9APtYo6aLKD4iw7lQSmtEiwY3ZgIo0ajhLL6gqhT8Enh4PDh8e8RtO9A4ElBBk27GO67tZXSHlhijybEAF7G5EPtT20PSCfkeQl6LmDnyx3Egkoaj7bhLGXk9QwGDTkyP8klGXEvu05qgsU6gd8qVO3AAIBWoPmIeKWXPWT48raWvWIVQ9BESJHNNcAeC8VOsuKsmrmsXJ6erqGIQ9+n659dUdBs3G2fXelkkjouYz+3gpCIgMLpRmmTBd0Ms9C7EwbSO0FtnBHxwWN0Bw7pXxt5ZDRZxRIqHXEj71CIt5OMp5ZQHaCCv0MQgj0By7bSgNRVUBJSC94oOKoVhBVugec97Tgs0F+7iU/QkX8CQd6yF+UfhsmopnUNooiQS1TPxTiLaNUgLOklapC7NzTr3Ufk5iCRZe7Y6Z05CpzHhh4hEsNQapJpj4zb1BcUnCRWR1sgRAzSEIH95ce1xbaAT 5X8nQnKf ngkly80QQq55/ZRciev7rcTbTEcIYf7brpqDPZ7F/5zTP0bAdm42EW3E/Ll61ewOpF/e7l3SNVkgvpFjWoomswEbyiriSuYuiEywV2zG9ybsIGMBWJR7+W/YbEkIgej6R+BbJ5JeqXGV7qVWAXGMnLLhxvq8jrv63P6eDYXp50/E0w+cd+UjIK///WGb+QgJaVCuYhgcjob6wlACPEpJBWhO+wJJRRvCjcVyp9EmpMDHm2sOyTGN7qo28ju3UXq9yp9Vm6vFtJfrL0uamJEFtDNvS2JICoBwOPWTZUkh9PUMJscFNTLDVJjOAImL6nAbiVTd4nHWJXzxI+j6SRAunkNYPDndxkoVcAZO6RNllWoIf+zLR5WNE0Ix6fS7Vm353+rIynQi3zbfriSRmKvRzvAIOCncEXxef6Q6UxpxzOYXqKXbTIUZutRXD0hykX2K4lRh35lReGq+5nQCNWTDQKIlC4KpvpYL1TNu6P6lpPdw5N83LuG02Vup0BQEDg4eontdi9lgHA/W8/ahe6YJh0V9cV+50Cavw98vMTXPi0yf64Ea1pXbSu6+K9ti4WoM6aoDk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 20, 2023 at 07:34:17PM +0100, Vlastimil Babka wrote: > The CPUHP_SLAB_PREPARE hooks are only used by SLAB which is removed. > SLUB defines them as NULL, so we can remove those altogether. > > Signed-off-by: Vlastimil Babka > --- > include/linux/cpuhotplug.h | 1 - > include/linux/slab.h | 8 -------- > kernel/cpu.c | 5 ----- > 3 files changed, 14 deletions(-) > > diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h > index d305db70674b..07cb8f7030b6 100644 > --- a/include/linux/cpuhotplug.h > +++ b/include/linux/cpuhotplug.h > @@ -108,7 +108,6 @@ enum cpuhp_state { > CPUHP_X2APIC_PREPARE, > CPUHP_SMPCFD_PREPARE, > CPUHP_RELAY_PREPARE, > - CPUHP_SLAB_PREPARE, > CPUHP_MD_RAID5_PREPARE, > CPUHP_RCUTREE_PREP, > CPUHP_CPUIDLE_COUPLED_PREPARE, > diff --git a/include/linux/slab.h b/include/linux/slab.h > index d6d6ffeeb9a2..34e43cddc520 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -788,12 +788,4 @@ size_t kmalloc_size_roundup(size_t size); > > void __init kmem_cache_init_late(void); > > -#if defined(CONFIG_SMP) && defined(CONFIG_SLAB) > -int slab_prepare_cpu(unsigned int cpu); > -int slab_dead_cpu(unsigned int cpu); > -#else > -#define slab_prepare_cpu NULL > -#define slab_dead_cpu NULL > -#endif > - > #endif /* _LINUX_SLAB_H */ > diff --git a/kernel/cpu.c b/kernel/cpu.c > index 9e4c6780adde..530b026d95a1 100644 > --- a/kernel/cpu.c > +++ b/kernel/cpu.c > @@ -2125,11 +2125,6 @@ static struct cpuhp_step cpuhp_hp_states[] = { > .startup.single = relay_prepare_cpu, > .teardown.single = NULL, > }, > - [CPUHP_SLAB_PREPARE] = { > - .name = "slab:prepare", > - .startup.single = slab_prepare_cpu, > - .teardown.single = slab_dead_cpu, > - }, > [CPUHP_RCUTREE_PREP] = { > .name = "RCU/tree:prepare", > .startup.single = rcutree_prepare_cpu, Looks good to me, Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > -- > 2.42.1 > >