From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F898C4167B for ; Wed, 6 Dec 2023 08:13:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90CA36B0085; Wed, 6 Dec 2023 03:13:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BCB76B0087; Wed, 6 Dec 2023 03:13:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 785966B0088; Wed, 6 Dec 2023 03:13:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 69B096B0085 for ; Wed, 6 Dec 2023 03:13:17 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2682212013D for ; Wed, 6 Dec 2023 08:13:17 +0000 (UTC) X-FDA: 81535678434.13.8ED8185 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) by imf12.hostedemail.com (Postfix) with ESMTP id 6115240007 for ; Wed, 6 Dec 2023 08:13:15 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hbH3XFVz; spf=pass (imf12.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.167.178 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701850395; a=rsa-sha256; cv=none; b=BLA2REUURDQH9OUFWsOKFo81btpBqiQngDLoBmqXFZMhb4MIvjR67/VOcAnqps7I7YPW8L bzJnfx0zMvJrEHXkIpCuaqIYDSXqunBZp1Urc7T/ftEDP15kXDleVW+AHDaky6UPVGpYJ0 cGa+D9B/8qCmzUUwvUE6xw0b9IBnhlk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hbH3XFVz; spf=pass (imf12.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.167.178 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701850395; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZKizt4iTnV9cayPmYedMVcEI9nEBmDM8KpDsNPl1XzI=; b=vJ2xw2J0hZPRigavfUhZJ8ptduVD4iVfJAQ3iUTH27NhoHIbm2ZkkFYshsA9immNLB6jWf 57DTXoo69S31h+syNvnqn/DtVLT22N9aHHnmS+9f6ZqL1QEZc39107XsJFlgXQ35/FrP5I 9bwR5u+0njMhFJZKm13EWHywhvQgy70= Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3b844e3e817so3843639b6e.0 for ; Wed, 06 Dec 2023 00:13:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701850394; x=1702455194; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZKizt4iTnV9cayPmYedMVcEI9nEBmDM8KpDsNPl1XzI=; b=hbH3XFVz7bfgeNNqqr64XhO/sCYWMjrLvaHVq30wNWow77IlizPrjvl3Mp2rKLv7Et V1jNARqp5dcCRQZXr+q8pBiDiISwCVSkyJ1F3xOk/zt5sddqJ2n5TLi+BVPxUEUMS4TC eCnR+HKvsHBFxCzqQsLpE+aSG8U3K+TGIon5ZZ4wzKC3IoqCV4p40XgdOzX/WawCPzS9 ZTHuwij8GUeklqrK82yOmpsdo1y+CFB91OBOiWOpkE6IKwRroBXbpQzdtIo+HamUzJk9 aaNUaBARMuaHLFW5TJmTcaEEICcILw9CXy+1TkpDGyxH50BxGKo8mlaWyG07un3JuBPU vOzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701850394; x=1702455194; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZKizt4iTnV9cayPmYedMVcEI9nEBmDM8KpDsNPl1XzI=; b=C7q2nX8+pE2n0CV+QnFjd1X6AEqfKB7Rqot7XxvCR5sanxYjYdPFxcvbFkKLpqAkQ3 4pZt3ngNoFnjPMYMfCP+1ECPc12OwXBY6cboAEvBrll355bp2mVqB0OBDSOnJYUHyMFc OlOCneNTH//6O3VKfjBW4VMrteLECgReVW1dsk9QQ8hFwao1cmnvAmsdSCqPNI6XchZV fdNktCzj52BD33sTH8SJIKmbypckpW2I1GCzYYKQAbNYdB51DFZnzSKU6WLGOkd/Xjpw cPJ6SzOChNVCMgQAFMdQDQwhVXimIP4CEfE3turiSh2Zc457so32LZTDFu7coKFD88ca 4AEA== X-Gm-Message-State: AOJu0YxTJEfL4b3VvEIRSSyA1GNBgEbux2ULdpJuTJJiyeQ+X6gV6CyK AfaVR6j7uSKTR5l4VPwJwaw= X-Google-Smtp-Source: AGHT+IElRqPaTCMRS95WPb5zLIvYTqxmbJ/Yepyjh+gda++IHaQn/3mO1oXx/4ZEu1UGLiI+FuRVCA== X-Received: by 2002:a05:6808:2e4a:b0:3b8:b063:9b7b with SMTP id gp10-20020a0568082e4a00b003b8b0639b7bmr906780oib.109.1701850394310; Wed, 06 Dec 2023 00:13:14 -0800 (PST) Received: from localhost.localdomain ([1.245.180.67]) by smtp.gmail.com with ESMTPSA id p12-20020a62ab0c000000b006ce7c28be72sm1455066pff.118.2023.12.06.00.13.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 00:13:13 -0800 (PST) Date: Wed, 6 Dec 2023 17:12:58 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Roman Gushchin , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, linux-hardening@vger.kernel.org, Michal Hocko Subject: Re: [PATCH v2 05/21] mm/memcontrol: remove CONFIG_SLAB #ifdef guards Message-ID: References: <20231120-slab-remove-slab-v2-0-9c9c70177183@suse.cz> <20231120-slab-remove-slab-v2-5-9c9c70177183@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231120-slab-remove-slab-v2-5-9c9c70177183@suse.cz> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6115240007 X-Stat-Signature: 1ronur498tzggrk4sebn6j4fun5yhoox X-Rspam-User: X-HE-Tag: 1701850395-691261 X-HE-Meta: U2FsdGVkX1+M8HftP8oaCGkWkoYcwfbmIYxIwxWA95+12VTr/SJHDwY+VKPEwKOjl3p/9O8HqWu2NODC9usZPwmlOFwjkm3rwNBQVfdy6sHydnPHs+tqL+gtq4uvnLrBP9ttN4k4XmoKJrIwJuZO+Qh3lqOErFcxLSYq4OCck4WcOx8/HZ83nuWT6+awLMRBD89Ga48ZJ5VSJSXWmWnNpB88jPamLqRAug1ZgYtI3QhlZ4cmBgxFcvLzyS6FjFGJEkjBL9Pa/PBC7Bx8JYi4KuTlRIUgyJCTwYRTSePdoSkIYdvq7Nlyo67gCbP/6zvel9qOZiU3bR0mtJk+0EBq2ogxucpj1gPrdUgfRI52sIVUCPwuk6Jrem8ImxyBap9XF8jGumxyu/JocMVsHbyzFyxMg42kuL1rIa9ReY9B/kSF/lGSrirbI6CkWV2XP5dPv2QVm914tiVXz6PN9nDbW4I+UhiLbQrlU3VXPV0IXe1nPUSeuW6vPvUx5x35nTdEmQxHwxNpCJ/ZGbwaBUUlNMroLd/zHyftgxrDceABgEKTj17rkU+qDBvQ3kYEaLb7etwcJnhCZ9Xw/I6MUNGKeiQGJtEBp6zrsdkpTG7agJZiD/sodXw9/peUaZ79WawE4ys1/BtCtz4zcEp5Rqf1Ts8rdyzaY1yvBfOcsLXe/oYeoU0qiPp6CIQCfAHpNCxYPTPSjefXL+lZ9ORvsLfloHQirojeBjMOITym+m44fdG/3pt+tStEhN9qQzzIXHufXHwtaRhCDc9wkt8lFUtyeYzF3nHNGTc40QNR6Mkh4rG24Q54esswVLxPw90GcGnlNJXBXdZB9UkOQt/Rz7HFEz8461qVSNkm4kPuDE7/09sq8LU5XwyeZffaflLd1xmxu1luyjCwl8kPozdYCtuGVtmft4txLqDXkETS6LasSdxRLmup2Ssad0OJErXThnohGIaJdrAPAbNzPpWo2f6 xYui1ol5 PGuMgCaKR1h43RYUuvrmvUD2OkRiVFJjDqMIwzeA1+geu/a/gKKZFMttv+9dVoc/9srRy5oj/N/gTjYgrIlTsEH/SQMTG+TFTNc4TFR9X+wtFXrX7dncNHgqqL9I1AFkF6qD32LkLTiLhVKjaWYycqBdZvrXlNDbXxE9QDi+DpNT9iGmnGU+66bnybgh+Jco9Mi/vM7E2/5kuKP+nfu1Mf8NuAUWL75zfnXyLEJxcMFNSJTHNKN9LJ7t3csUUxamJY+rmoYIALMnfEduHFRZ63+yHoSQEVPI36wVeBxni3n2Uvs0WW3KdqIkZ3OpOj+E+vQv76c2R9bxQNAIeV9ByeLTvfod4CwbKyckEZdmArP5S0g02Rr+6F3XJZKgxWVDv+47QuiZkn8oFTnmDUoW/37Eivva29kfqrIax43JhtFzEknXvtXKGdaO+xtx3KzqeqgUqjma4QY11xd7SHh/QEDOj8miqvhYOiiPhGCoHZTt1wePiufAfd1vM9VwXSD8pTNujQbc+t9LWrCqoR8V7MP07BBspcLe5v2C/lH+qvsCvWD/T9L7sucwXkWwCgFYm3SrP5ihYyh/qdVIqx98DywUdkgnHEQ4MkGNmbn+0PcJKo+nAjYciOYtVTtC21WgwyEsjDgHoA6i3nuK18xPAM2KE2AL1liy5sO2D2GRS6bwnmWzTqDwuLs+oEA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 20, 2023 at 07:34:16PM +0100, Vlastimil Babka wrote: > With SLAB removed, these are never true anymore so we can clean up. > > Reviewed-by: Kees Cook > Acked-by: Michal Hocko > Signed-off-by: Vlastimil Babka > --- > mm/memcontrol.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 774bd6e21e27..947fb50eba31 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5149,7 +5149,7 @@ static ssize_t memcg_write_event_control(struct kernfs_open_file *of, > return ret; > } > > -#if defined(CONFIG_MEMCG_KMEM) && (defined(CONFIG_SLAB) || defined(CONFIG_SLUB_DEBUG)) > +#if defined(CONFIG_MEMCG_KMEM) && defined(CONFIG_SLUB_DEBUG) > static int mem_cgroup_slab_show(struct seq_file *m, void *p) > { > /* > @@ -5258,8 +5258,7 @@ static struct cftype mem_cgroup_legacy_files[] = { > .write = mem_cgroup_reset, > .read_u64 = mem_cgroup_read_u64, > }, > -#if defined(CONFIG_MEMCG_KMEM) && \ > - (defined(CONFIG_SLAB) || defined(CONFIG_SLUB_DEBUG)) > +#if defined(CONFIG_MEMCG_KMEM) && defined(CONFIG_SLUB_DEBUG) > { > .name = "kmem.slabinfo", > .seq_show = mem_cgroup_slab_show, Looks good to me, Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > -- > 2.42.1 > >