From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B857BC4167B for ; Wed, 6 Dec 2023 08:01:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44A9E6B0081; Wed, 6 Dec 2023 03:01:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FAD96B0083; Wed, 6 Dec 2023 03:01:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29A966B0085; Wed, 6 Dec 2023 03:01:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 193D06B0081 for ; Wed, 6 Dec 2023 03:01:46 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E10B7A013E for ; Wed, 6 Dec 2023 08:01:45 +0000 (UTC) X-FDA: 81535649370.02.182BBFF Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf11.hostedemail.com (Postfix) with ESMTP id 159FA40017 for ; Wed, 6 Dec 2023 08:01:43 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="QVYqrHB/"; spf=pass (imf11.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701849704; a=rsa-sha256; cv=none; b=VpdZeycck3p1jB6bhw7C9iiguXsvJZDViHjDTajtcgTXk2OyYSWXX+c2cHcRpC2NeqHXSF nYadhQkZi3fthYDfRZYBzzHSdck/2wlNV1WQnjEBt2iKdwZBGmIdURYaOTSV8nZqHZymD2 ItZwJepnp7EkJzzEFd4S5kplKvYPMJs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="QVYqrHB/"; spf=pass (imf11.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701849704; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NsJi+rAf1/pjE2JHoHBlEmIyNC7axeV0xxI+MHCEAm4=; b=0h8nn4FFdJPnZqhYtm8yUwOY/gDjikXycLiSNG23DBqNmMp8bWpqr9DylSQU0Z6KVgCNQh vIdl8by8Cnh8sH7QiC0Zj/3d8hBchfoLt5NszKveq1fTChmRWctsmLzRwTDq5iSDkgh1Le HzAh5LQrBiUpiJutpYbvLzoPWz+sV8E= Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1d0c94397c0so10104525ad.2 for ; Wed, 06 Dec 2023 00:01:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701849703; x=1702454503; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NsJi+rAf1/pjE2JHoHBlEmIyNC7axeV0xxI+MHCEAm4=; b=QVYqrHB//xzbp3N53qkIghrTXHBnaXkyWOBrkVpNrt9JjCJQxmsffM0p7IGAqoaYe+ P9bBpk9U7iinMm2wFNpoO2zkCjCV6rmYdJybZDzCSLPEYb31Q154iA8Mh+9TzFkw4e3j +sKFey1DEE5hmcxOFFXjtkPn3mmCtknjNA8o5xXi3XQXdl31mNjj2HCrfNZE5Cyr1O7L tmakQ3oHX89soz+rywyb3aLtqzkOCAN9zcFkkgeDor+vnfccVlQvGhi3eEOH43+p/Rhu XT1SLYJLCXyMvuIm84q8uB3YzzrttGLyQJ6lTf0moskqVcfj7Ehb4llsC9fjQE3YmvKy /sVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701849703; x=1702454503; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NsJi+rAf1/pjE2JHoHBlEmIyNC7axeV0xxI+MHCEAm4=; b=TiodGG8C7McIPQSAZ4ODXkBGw+vmgVvssBgpsQFr+yhYrhwh/sofBwM05iNdSNKTCN RM5aFfnqnALbOXwasi5ojllqDefPlWgVYEmZQFv1oV7xMv1oKPCINV/pHAdiyxlZJOBS Y93MYNoxURTcm5FXoo/312vXObM2fH8apDYkKwtTuBcrEhGmLfcPRmZXGoPNuiVE3tb/ 0p1aB+kK2poWnGj7R8P96jKRIrb2A51cvbCPTSrjJuOPO7a50tw3FHZDOLvSCysnVQqI ydrzG4gNQ620AyVj0sUw5N7jCXBkWfp7KvDmAV1Uzg/15StML/deebJ4tQOcj3+dZq7J iWSg== X-Gm-Message-State: AOJu0YymBlA0jHM6WmycMK7yvwK5AgVnq40ldNjzdtGW6paTNi88XynN MIjZq5YcWT8lcsXhcJAUP2c= X-Google-Smtp-Source: AGHT+IGA+NdMOoVaQo27rb8nuihulPx4cilWx0f3Si9dfTy/8wUKfwgUOGwMnzP3PtmBSojs/chvDQ== X-Received: by 2002:a17:903:1208:b0:1d0:6ffd:ae04 with SMTP id l8-20020a170903120800b001d06ffdae04mr321640plh.107.1701849702755; Wed, 06 Dec 2023 00:01:42 -0800 (PST) Received: from localhost.localdomain ([1.245.180.67]) by smtp.gmail.com with ESMTPSA id x4-20020a170902ec8400b001d08bbcf78bsm5976368plg.74.2023.12.06.00.01.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 00:01:41 -0800 (PST) Date: Wed, 6 Dec 2023 17:01:27 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Roman Gushchin , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 04/21] KFENCE: cleanup kfence_guarded_alloc() after CONFIG_SLAB removal Message-ID: References: <20231120-slab-remove-slab-v2-0-9c9c70177183@suse.cz> <20231120-slab-remove-slab-v2-4-9c9c70177183@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231120-slab-remove-slab-v2-4-9c9c70177183@suse.cz> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 159FA40017 X-Stat-Signature: edz6bf33f67xhnsxnzfqis19ypfxk4ra X-Rspam-User: X-HE-Tag: 1701849703-655774 X-HE-Meta: U2FsdGVkX1/GMnfiqY7V3CzCWexb91v9P+hSJv86efOsymcciEcn2RNF3db+MKErGJi7lMk0dsiTLgjqRov6JWv6yMUZ25qdGb6sczSzbrvaZTzOWBvwSKPL4PiXsVF/tHCG/544HVAcN3mKUUF/q9GewjCJzXl0FF81/QqgyFUqXA/baHBP79fzdwFGZ0XhdiWPqsiRO4l+40UbLt2XGEbtvROVBRa1TyEULbLWX7onBlLTOx1Q2aE23TR4im1HROOZxkp+Ey+k+3dtenqT/5V6SeyOu6BSwktC8TkGoLI7b95HL5/G1u5Vbityea2vY6icK7nCYrmq/AxWqvqjaQlieX3DDXXtv2J9W03KNenzBM9xXlB4rvR6PazL76pF8PUZp3JY0cJfAj2RILEMDaZHabEVOoYvW03PaN9gCDUfQzrRBjImBuFY5UhyLO/3jGsMzN+6dTYJdcDsPgHorGA2Y1DDCuzpAOsOzAueUFXot6nl6RxBaGLsKkvGWT0uYPwD3lAQ4X9fDTN3nu94UTs879vj5nfK/AafP4MV5IvJJHYqShMZS/nfto0k0oEg/QuvfGVfuYouHTOcDAg75BYBjlVfpT72Zirtb9Ewp46X699S3w5iGcRQGp4/NVJv3+69bRB/6s09W+XKi9TAmjmxB7m77Lnl/OV3bT7iI2jFGpVOxUBdDK6x4kafOCgkP+fyvUAeB6TSDhy4ODmmIAe/U+CEbc7+jYtbef/P6rL5ddi/Mf2JNcGp3EQMM5P4176IHN6Ur5eRNumdsUyQ3BNV0tpqYwPGXP4I/APfG962RY9ObkvjuL8z15OkWFER0WMMVfEjWP/vo0X+q4TrgxlLntfANZEp0tzyY/ZxojRpiyLAZCDSYrP/NJ2/3n8yGTU6NfsjD2EKWv7VJ1oqSuYfvIlOuYQ85vwtn11o+mCSCWAsLnMDehnul08xq4Qe3jTofG7qYVzjFktzCpb vI53U3Kx HOfkWWv/ClyZkr3cIVg73AhGbabK62YkA3AkRjRPCWT2XnJlFo+jPccQiFFa6/1zAsfnq0eTdatxb9fXWVWb91+uYPXejZMCdO9y/vRoDb2nUTN55xM4b/V4pJugC4+sSrYgnn3S4fo+8Nxpp9BMbzm1Yg86EuHgpnEsu/sQGwQpuebLxcEqNVkEG9nVSDJ5AnBK33UmiHmG18W3pwpHDoQcIp/avsAFkeKflP0wkxwLJqItD0VmdOKW1k7iMw3OIUR6RkDCm4soYMEhwAY24LKePethRDIHzscZdbYZw3Fqq3rzdKlSmYG0Y/Z+j+XcGnDE8NG/SNgwfbYK11zXmvInUylC8ZdfGECAZuY9ZG3bKYbe7RxGq63xT5usE6Nizf/pzdbHns3kA1FlaOwe7nlRmSvc55l5bsT7gAX33mglE4ro3ckBDBW6xKW0OORejhjMxTun26b7+D3hdLyWhHjXroBK9Rmxi9v8ivcf92ZdYr06w4PxrHb4tZjnXK8ecCZpjudRCMJivikUh4PurRpa3JIxCslIISKJV+z5MnZSiuTzn2NI+P5gRN+mE8niDWXpMEa0zykh0k8XBNuElPB1WR2+LqNFAs64QzmMAJ/cqUz6dC8M21ZEOfE0ZTmGEm3ADnsR4S8NyjtI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 20, 2023 at 07:34:15PM +0100, Vlastimil Babka wrote: > Some struct slab fields are initialized differently for SLAB and SLUB so > we can simplify with SLUB being the only remaining allocator. > > Reviewed-by: Kees Cook > Reviewed-by: Marco Elver > Signed-off-by: Vlastimil Babka > --- > mm/kfence/core.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > index 3872528d0963..8350f5c06f2e 100644 > --- a/mm/kfence/core.c > +++ b/mm/kfence/core.c > @@ -463,11 +463,7 @@ static void *kfence_guarded_alloc(struct kmem_cache *cache, size_t size, gfp_t g > /* Set required slab fields. */ > slab = virt_to_slab((void *)meta->addr); > slab->slab_cache = cache; > -#if defined(CONFIG_SLUB) > slab->objects = 1; > -#elif defined(CONFIG_SLAB) > - slab->s_mem = addr; > -#endif > > /* Memory initialization. */ > set_canary(meta); Looks good to me, Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > -- > 2.42.1 > >