From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC7C5C10F04 for ; Wed, 6 Dec 2023 09:18:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47D906B009B; Wed, 6 Dec 2023 04:18:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 42D756B009C; Wed, 6 Dec 2023 04:18:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CEAD6B009D; Wed, 6 Dec 2023 04:18:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1B69B6B009B for ; Wed, 6 Dec 2023 04:18:49 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E73B9160165 for ; Wed, 6 Dec 2023 09:18:48 +0000 (UTC) X-FDA: 81535843536.16.CA7CE16 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id 4D9F41C0015 for ; Wed, 6 Dec 2023 09:18:47 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=uCmwkN1z; spf=none (imf21.hostedemail.com: domain of BATV+2d31c4bdfe93494595b7+7409+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d31c4bdfe93494595b7+7409+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701854327; a=rsa-sha256; cv=none; b=jVR8aAsH8UV4U5h/BXLtrpIMtUW3bdUOfQDuf1QRxLLiZK5FELGckaXyeSjrt08PHtu9af ZhoAG9Qu5Ya8nPxnpTd7aPebrBSfZ6ATYB2SPOTGdl4cCfy4d77G8/aE/qXefIyrHVkwV4 MTpE7cmPsnus+R+mKIqJCY/u5qw0prA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=uCmwkN1z; spf=none (imf21.hostedemail.com: domain of BATV+2d31c4bdfe93494595b7+7409+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d31c4bdfe93494595b7+7409+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701854327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VV+1yK4XNdiDrEeyBFpz4l2AQZ37wduEiyTBhKsNJrs=; b=BlPXf2fX3c44jEXMBDj4JK9t1dEaR+4R8ZmfTaeFcsi+P8KJCF1kcyCT8/fTHU96ueU3/h kcy6891rdRQAjk1l7p1Yxv0ODPQfUH1t75zkqdhM2e8EEFBqzvNDtI6Sm8/BfMc9qO+tSW zwhGuaR5flGnlT2kUH7sNco96JtLZMg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VV+1yK4XNdiDrEeyBFpz4l2AQZ37wduEiyTBhKsNJrs=; b=uCmwkN1zBJnu1wxeEqNxmIajmo S2LuZEd1F31L8+OnkOZjFM1uGSIEsVSICLPFQ2Ct7bc4Je2xp1EFJfHD4V1VaeZiF0NASM1tdxaIj 4eqiQtLraiEtsJmfn9nrGtS79Quwq1JPo6mW4U0g3u8isokfrNVOMYAYl8sDo/2WZoGmr/Dh9n5FX U8bw5c6GYJHbARvx+83n73lHs8MeG5ba2Wg9vK4GKvbF5P1tLKmNvKeAxyr/INA0UO2JQZ7qCSoZL vHCfVdLvrLEXNfo3SYP7y8NOQdW7w30pa6rHb7ibVAwGbr7pvQhHskVOM60fP0nvG6HbYeklwpm5K lL5NkH2w==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rAo3J-009XB1-0J; Wed, 06 Dec 2023 09:18:45 +0000 Date: Wed, 6 Dec 2023 01:18:45 -0800 From: Christoph Hellwig To: Vivek Kasireddy Cc: dri-devel@lists.freedesktop.org, linux-mm@kvack.org, David Hildenbrand , Christoph Hellwig , Daniel Vetter , Mike Kravetz , Hugh Dickins , Peter Xu , Gerd Hoffmann , Dongwon Kim , Junxiao Chang , Jason Gunthorpe Subject: Re: [PATCH v6 3/5] mm/gup: Introduce memfd_pin_user_pages() for pinning memfd pages (v6) Message-ID: References: <20231205053509.2342169-1-vivek.kasireddy@intel.com> <20231205053509.2342169-4-vivek.kasireddy@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231205053509.2342169-4-vivek.kasireddy@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4D9F41C0015 X-Stat-Signature: gw5jsmbonn9j8by1bdr3qof9qao5w9iu X-Rspam-User: X-HE-Tag: 1701854327-115489 X-HE-Meta: U2FsdGVkX1/7vwKydSpYoJNKx9symtXtzSPBz4FiP7/Eis1nMwug3yDX2VV5DFi1ZTEiHqpDZwBh0IDgm8DgmsxMqnSfhR5RTLM+1oqA+W0RNZqsmFwu9qJ2T6Q8WPuv0Za/99HriCIREJcYel0z4G1UPCwhtg4KFmT0AMnRRPH1CGATnKQCLZLBVBcYXt2F3zwDF+sQ1FCYCYVfClsFEbdeFCkAkfNWz7MgK1Nv+xGolOKti3wb92ZQOmlxMDw6i/VshPXlu+Yy04TUXboLh4xeism5XnQS+QKZzQIAYbZGB2AZBOHjNyraHavD3FP9PlndMArjhgFTKyAJYtWXksiq6svI6JF5GQnBMj3h3Lww8XNbI7126c0/4ckEQzaHvhNHZOcoRDi13t7UUdJ+ONGJSOQAT/VF/o07xwEL3rtNnknq/aJjsUqm0Il/rYCSxIoXSI6oNuxqzd1gCZhAKLU/lEXxB9iGOACbfKW8G/1a6VxwI/dPvHx148o4eOAJYqW0aqia2yk1mfqoLJSIh8zori64wXXI6PuWEXhpu+lH4ZUlptDcyzhEZpMPQ3zun5BTPwvUXQBHuEgTJq5a7ntTw1gTQmOhe87JToe10tiCY5s/p1+qpOyopg/34/UpnsaXJlGRthRwzlmzqbGbPyhen8rAHH3XgeAl0oR0PeJXS8YzEQTUbTzQ48Cj5og+O3CKA2vhbUUScg2uYCTDxXxmuOc5hTpI8VHxgvDens5BA/7mXWxUIawQ0sKBzmnzrfp87w46OE6VVMW0shAhhxAQPY/WimXyCI68bO/bdcvScoVdt+OOd1Ol12lUejqhtAPRy8DhkErUfYTIhVfvdFgKsdR6xAmyF7F9DnFQo8++A+xGGr5dtUlcstO16hd/pfPqlTwfzJmOph+GCJjFyxReuKfyR5wJhCk1AlkTcRe4ndyHdAOQYXy2ShX6J8iEPT9Tx4E0rZeshbxOqAc F8uv1G19 Ps1q8pqKk+LJig/oYC5pI34EJIH/qdajQLsAskDZjEJdtTTPnIyfIHbhRDAnJ0BxzxOCh7a7ptcEmwQQWtvO79e5TlAoNQabB18esjQoRWZDK4YHkThzQS+GueruENiPg9+KUMjm/zWiq0zggIW6k2tVVqwVotJhU6A4juYfgwHVwmgk12Ic3UlP8/qcRFfn1OaSCHrm0ufcdrtKpbG8Gvgdubah37euyXMSZJ8EvcpGhF6nKdO/F0c3mXXl153NTVBqpsFtjTxEeBr9jQ8UAnDLMbE6ByEA60RiZfCj3upQZAdJ+HzNHImF/A4UNQCCSGFMZ+VDDQzai2yGKRWED4rdmph66eN6JDy1kjtGYPlDWR0a6vnhFBV7XU5eE5VkKGAJjYPEqoOjg9eGym4oj4LnDrKtUpskJxEMV4QNtdJNsWr5YltUSs1kBMQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > +struct page *memfd_alloc_page(struct file *memfd, pgoff_t idx) > +{ > +#ifdef CONFIG_HUGETLB_PAGE > + struct folio *folio; > + int err; > + > + if (is_file_hugepages(memfd)) { > + folio = alloc_hugetlb_folio_nodemask(hstate_file(memfd), > + NUMA_NO_NODE, > + NULL, > + GFP_USER); > + if (folio && folio_try_get(folio)) { > + err = hugetlb_add_to_page_cache(folio, If alloc_hugetlb_folio_nodemask moved out of the CONFIG_HUGETLB_PAGE ifdef, the ifdef here could go away. Either way, this looks good: Reviewed-by: Christoph Hellwig