From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 255AEC4167B for ; Wed, 6 Dec 2023 09:16:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE59D6B0093; Wed, 6 Dec 2023 04:16:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A946D6B0096; Wed, 6 Dec 2023 04:16:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 983536B0099; Wed, 6 Dec 2023 04:16:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8A14C6B0093 for ; Wed, 6 Dec 2023 04:16:28 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 40039120131 for ; Wed, 6 Dec 2023 09:16:28 +0000 (UTC) X-FDA: 81535837656.27.219A4BA Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP id 690ED1C0019 for ; Wed, 6 Dec 2023 09:16:26 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=5B7B3Lie; spf=none (imf18.hostedemail.com: domain of BATV+2d31c4bdfe93494595b7+7409+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d31c4bdfe93494595b7+7409+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701854186; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+rdgOEacg1B/vvC/+sAEkHKmfLSueyk6hI/Ck3gjYXw=; b=Zv1u8TFUQHYn05oKPTuo2Phs2oxoQQ8VmOQuGN1Qzln/VZGiIQsgMzlokix/kDfLo9NaqA U9UKvM4/Fzl9N6gRwMcNug6n09owAqZkOH7r4NAVL9GXT092NFchWVIinmXNXp9unWSshF 5twWZX/QQhvWF1k9vkWMMe1VYzPHins= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=5B7B3Lie; spf=none (imf18.hostedemail.com: domain of BATV+2d31c4bdfe93494595b7+7409+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d31c4bdfe93494595b7+7409+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701854186; a=rsa-sha256; cv=none; b=HLxUGyaXLO8pywcOyu/k8ygiEt7buXxBXQpze+cPI/WDzIbUtqrOUvVK0ouK65uc2SgOMh 9zBZRo3R01hv2B9MrmUaTPrNaDAu2b9pszklPNRp+t0RgwRVkqbOFMvXp2qWKzWmyVmynH vgdFy5sV6ttMi7Gs8EMnk0f70cvFVI8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+rdgOEacg1B/vvC/+sAEkHKmfLSueyk6hI/Ck3gjYXw=; b=5B7B3LierXroWOKh66tkbCdCLB B4GwMv2JFybRDRGJ/nrN8E5qMclinlVBOucNRqGsWhsz7VGwmulbMN50z4C+EvmiDyBNBgiT/Bb1K HrFF3jma0Mzyo9c6XFzqMCO3Y7ZpMBPYHA+LljkxRK7ZNDYLBo6I534yRbbUhUNiQ7Jll13xD5z/w NplnC1ZXmqNHJPnVXN5FsiFjg+daM5ydbXde7DFZxs4TQcFtLmVlN9jcHSVNeW8gzDUF/P30Fczo8 4F+a7IyjbAokIAYFCwpHdH+fnvaiiQPMB4SCtHc2pwKbVXkd4SecufU3eubP/sYxvHcTXoWm7giT0 RTp5m8pA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rAo11-009Wax-1v; Wed, 06 Dec 2023 09:16:23 +0000 Date: Wed, 6 Dec 2023 01:16:23 -0800 From: Christoph Hellwig To: Vivek Kasireddy Cc: dri-devel@lists.freedesktop.org, linux-mm@kvack.org, David Hildenbrand , Daniel Vetter , Mike Kravetz , Hugh Dickins , Peter Xu , Jason Gunthorpe , Gerd Hoffmann , Dongwon Kim , Junxiao Chang Subject: Re: [PATCH v6 2/5] udmabuf: Add back support for mapping hugetlb pages (v5) Message-ID: References: <20231205053509.2342169-1-vivek.kasireddy@intel.com> <20231205053509.2342169-3-vivek.kasireddy@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231205053509.2342169-3-vivek.kasireddy@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 690ED1C0019 X-Rspam-User: X-Stat-Signature: tqd8wmcg7wqnmgac8zmypjt71k4s14uo X-Rspamd-Server: rspam01 X-HE-Tag: 1701854186-710352 X-HE-Meta: U2FsdGVkX1/LYw8DFqBhcvSNrjFJobmym1ZJNRDlouizTsmxyLH9+qA7jAyHksDAf1YwbDSMyzc3icGzCRrB7x7bADMoW3np+74W0ATZ5llHgEaRsjLGfVKt/z4kLJ76mHaR/FDTrAvsjxmafhdkUOMEAM3d1WF+tYTL9kXyFdr9kklHcEiuQYvAVirY9QX/BqiHYUf6Ol6XStXoxEWAcTO4P86T9G8S2l2FnQZNaSGUfsYUN6a1E9+Pj5HoK92imW42/FAAnV9HkvSyi2VAu+FIiQHjTobCVQnOuWLED1QgHx2RLmUSBEzpwiDU5xGSRG0zdxcudqFn+2RWeqMpfnatxfkGtbScGOG6M4iINnqAyJc9e8d7WEZ/LKZ50O5dD+BuU616lypYcyH3qDdk6mhyVFlHo7dOfhOasibXJdiRwnP+dWxHHJ+AJwkUHc3MUhHNs2LSDRnXn7SbVQALZNATqHLTTDA/chpweZwaNAN8OIOwEvXvL2faTeUtKR/JYKNtTcR4dMBFQlpD+/xDqcLOqIUYvhmsXLXLzC77n/JwRDpsCj1sTmMKQi8vgMiNYkQDW5S25S9LPFXzHfdxA1g0XFayEevrxQa0wzjpMdvJF2jfdZYBJOZYdliu6vLs0ZjRK3OsVhNN32yDlsj5ISUbcMv2DpnyuDZt73Zr5OQdXFs9WpLQ4C4MU6SaMPRULQSeBWVjCO8ePPVwAOMm4MnxWGVDnfhyuvle0mvlA2Cq8IeVKdDDcEkkJIbDoYHtC4lUx1Ot5HzcH7yXANkO1eVx4u97DYOerZaI/GqfuR+moJYZU3s4vS/HETXFdJXwx7D36Ads7YxMv0T8fBg0i6yxaNVAl9B1CYFRzmgodtnsi05sFBvoEBwYlLA27lBPHSlsl+UcLJBs17gyM1cbZ7PxFz5HfuTZE1MQ3m584Ah/wleKTZDytVzhvUw3s8iDE8MGDT+4r4S7nvHkkjK TbVY/IZj FA3rfjfBwRRQ1u0/CI+X20MwT53xFgjxusCxGrs7tFUPtTfNsNzEa4OKvL7mtfe4D1ixZIcBVLUrD9U22J1kwlpYT56pyEs77MtuKe2l6da4X/A8RPOgBhE7qunnZikgaZZO0S84Q7VloV/s6HlAg54nGxtk+M7M7bhui1U0RBW4SVPaAI46WYvjlBHGf6pxvIj77ju4NRjHHr225FZIwppztplwvPtRIexUK/WwGqYPwgJF2CqjduYG0XOYZXx8qcS6WFpSZdRHQ82XpLktZnGP8fLxvfyG9HTVFToFOygTydtb0iPGy4HKWtmB/eRSzacttSyzPL3BPX0DeguVyQVpXqGAYWPJFFDVJVqZQpP0wJh5hgRDkr8v6+Ds4FgRUaVqftN552/8smYA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > + if (ubuf->subpgoff) { > + pfn += ubuf->subpgoff[pgoff] >> PAGE_SHIFT; > + } No need for the braces here.. > @@ -253,16 +271,59 @@ static long udmabuf_create(struct miscdevice *device, > goto err; > pgoff = list[i].offset >> PAGE_SHIFT; > pgcnt = list[i].size >> PAGE_SHIFT; > + if (is_file_hugepages(memfd)) { > + if (!ubuf->subpgoff) { > + ubuf->subpgoff = kmalloc_array(ubuf->pagecount, > + sizeof(*ubuf->subpgoff), Overly long line here. Given how much code there is in the main loop here this almost screams for splitting that into a helper anyay. And then the body of the pgidx loop below which is compeltely different for hugetlb vs not ask for another helper each for the loop body variants.