From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96AF4C4167B for ; Wed, 6 Dec 2023 09:10:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22EB86B0075; Wed, 6 Dec 2023 04:10:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B8396B0082; Wed, 6 Dec 2023 04:10:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 031756B0087; Wed, 6 Dec 2023 04:10:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E33786B0075 for ; Wed, 6 Dec 2023 04:10:22 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C65D0A0166 for ; Wed, 6 Dec 2023 09:10:22 +0000 (UTC) X-FDA: 81535822284.19.76E099A Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf22.hostedemail.com (Postfix) with ESMTP id 063F1C000F for ; Wed, 6 Dec 2023 09:10:20 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="nYi9/Fws"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701853821; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D8vZXQBRikGU6sWc2QsfIXjdmr6JSGCqbWWomJu158I=; b=AkMahTea7ewZcxQu12yqBVZM9svdbqEfc2lDIyAsk+9I/UK7ZEAgZkbzZ93txQf6fdIGFo tPbhTBCEYwyDjMecHRNqaz74nzP5gpVgcxSQOycyxlaXv9tvkt5kijJ/xV4Q5rrWZ2Zuiw MrI28xaLvlnziM1iuzMxrTVTNFnEXKw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="nYi9/Fws"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701853821; a=rsa-sha256; cv=none; b=nAhyxS2diTBApVTmCEoEXgNXDjL42FlGM0fLoorAjLROj1qptC5V/ihvJHTJMRIVeKDTLa 37VJNr9eg3+zOKKFsX1N6ODB3ged3o+52dM9+yMfbbFXwSDQT5C9u0lLdKu52fhv/Lq6Qe OjdeLwAfBd6yJ+80/eiuToJelfflWYs= Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-5c210e34088so4238402a12.2 for ; Wed, 06 Dec 2023 01:10:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701853820; x=1702458620; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=D8vZXQBRikGU6sWc2QsfIXjdmr6JSGCqbWWomJu158I=; b=nYi9/FwsU1FJzjeJ1PZ2tkgyaxIEtISC3a6UzguKIwJCJFTpb9/PtxWEn/xUCOGBWC pPuyi1YRgdyn04Ui9xPkkCpGALLcknqKgKL1RWagSCGV/nYjM6Jidn/u+7LUfFRCnJ7/ vwVPjfZlpg+VICDvvDml1gkudxPAZbnJlaNXWPKEgS0pFNY0xdXUFMGO3FKMXlO4oWL0 Lo1CdnRf8EI5BNGasBpEDNR8nKotOlZUdjxxE3hEtkyxJzJHKKXgrl9GB1Mm8mJjGwr9 zp7j7eFUMQaL+aLTl4WFA3q450pnqPtcQ2C2ki6XdL8WaCNZ9UWjpMppz8gMZQOOzLqW MLxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701853820; x=1702458620; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D8vZXQBRikGU6sWc2QsfIXjdmr6JSGCqbWWomJu158I=; b=VJ2uISFgFbdIGzARc+njnZCFBYlpLcaitSycjRtXHPm7ti0zbqVuUcDdiDDqWF1pQV lWJB2CUnaHbJ3Zb9GwOk1MXGp3/P8tnNxAt1APucVM6UGdPZvR3Eg9zJyJ8A0ZIxvSDq kCrjyDMXTjfTEKccK0hOkExBxQW99L2ejD6l5QAgleStTxSdG2GEIKPtKQsnKBf4M8iE /vPelug+F2tGrz2CCYFWwXiMGu5I5/dNgDi+B3J/BGrZry72mFU93UamfQ4pmniO8VZk B9vXldfD+4kj9ENCrrIc07xvRp+wemMH2OrlLkbBq4n0ZcPBuG2GJ3lhyxqKGGpr8IRY Unig== X-Gm-Message-State: AOJu0YzSIFvwBBqgP/rca2s1OwlfR99qFByfY6gQJzGVARHVB6gtiJu7 +usfZGsUkAN++Is14FLLj/ope+D1Rgg= X-Google-Smtp-Source: AGHT+IFset8/x2y0oFwNGQQRLfyeYkns1iFYfHHalNFN3DxWN75KXchutnoXwKUQTPjMGA8dsmHvzQ== X-Received: by 2002:a05:6a21:3102:b0:188:f3d:ea35 with SMTP id yz2-20020a056a21310200b001880f3dea35mr877394pzb.50.1701853819776; Wed, 06 Dec 2023 01:10:19 -0800 (PST) Received: from localhost.localdomain ([1.245.180.67]) by smtp.gmail.com with ESMTPSA id u6-20020a170903124600b001d01c970119sm11497348plh.275.2023.12.06.01.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 01:10:18 -0800 (PST) Date: Wed, 6 Dec 2023 18:10:11 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Roman Gushchin , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 08/21] mm/mempool/dmapool: remove CONFIG_DEBUG_SLAB ifdefs Message-ID: References: <20231120-slab-remove-slab-v2-0-9c9c70177183@suse.cz> <20231120-slab-remove-slab-v2-8-9c9c70177183@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231120-slab-remove-slab-v2-8-9c9c70177183@suse.cz> X-Rspamd-Queue-Id: 063F1C000F X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: t47st5j8wot1j317zio6ftci1yc6smhi X-HE-Tag: 1701853820-80389 X-HE-Meta: U2FsdGVkX180AbyxSuDusGm1nC/eonX7LkiVhAXo+ilfycvPpCOUW31glxFHH4ZaIX9U7To2Xgf3zPOTOFWIP/JHqhwSvMH7cJY2aLVzwgaq+ktcZlLWRmXO9zcSC/VtRSI3v/cQXP5Cbl5I1NVVtP69kcR3BnT2y7PYs2nywO2hvhlsCDLWMvN9nahUG5B2mQHPPheJrxTsqBAROSXIxvfINPs055MT/Rw5b3Uj01evWuAgFS1xyU0tW6k+KcgZZA4XfpUi9pXfsisZXqy9uR4bUkvfLnwo+0o68689EzYMoZraFBO/4ELFzzIhDNEKsi6Zz9G3PXywfUZzUTK07nhRCfjimC32WnyrSDnYzayQFY5w71EIzFZboeXsXT1nivO30T4fFUQrbYQ6SHhHxdcqx4NMsGvgiap9j5WViyMDPAgEGMmtG4oH4mMCn/WQa2YUDz1+QmbgmvnubOW3AbQZpC0B2Usrr88UkA56PUvd5C27N001dcskpsswPGNJ8rFOWkgJGA3JT3vNXNDOkgrRLt+i5Z1sWORPpQn9F4hCVDL53FRgbPUEdDho0uNG/JK2E5/DAG/njkjHuCA+oV61rJt4e86Q25ty4fMmaAbM5ayaY2C+KEJJ14iYdcYphaUMBvtDwayEwHvWG2E4wrLqvWXWsRMuAE2e0ZHkalmYaihYQmmmJEteA2y52NHLBCY6XFplh9vQ7+oC5W/8yd9hxLpmI/u2M49UsS1WyzaaxDqCpB3fz+DK/0VWgeX09nKryOSLn1JRiJ9o6pXtDZdBDku4j2NgLlgARpvGJc2iySXnvxZGRU+ZNpDbKSowVCeTRwGwqfU905Q3Vofzozd+E0jBZ1NNPJsKNTbqqp28e2zjVSH7OP5lY/wIthDaFc6CnAz8BAwlPLqOkIFdNutLQwG/iDJ5O4MS4odOT6TSeybEV6ro24KKMANYsajOg80hzru792yMNp/c1Mh LBETCVSQ 0w/Y3gSLELetcW5FN4pxNdqKGA//P+eJYCLch1L9e4cskOZvUkQ1N+877a8TO6U8I/5dvrPZUZnnquMQlQgsvJqxjS1rSapCwi/OZwgkwrTGe9u0cvbTHPRZK+5ZWbLmIKFZKsVoyXSqv1uTDmOBc573nhkJPJeP7ZooUsJL4tsItJGjB3YEDPiZPUiwtEK6yQTpQJ8dPfsBHTatt5waOryg+MiA516B33wruFwSACKKK80iw8+gI+S7JjfcCCypPuR3baqMdc2ias9qQ+rMA8dKbhryD8OhVjOxC8PTkdKuZ1olszyZHLH5U/W4tBwT7kbp5/E/XXEubj7qt+TyRMgE7eyvZZxEM+3CWvZ4INwDaZa5QVv4MsTnb5ZvmjkAFEkDbW72D8NHGs1e/L5RX2JgsMUbVOCSrAqXFWASOnWo4HELf8zGBkQNDV7kUe4a79p5TCzQGb+yCn9RtPqUXazazPrr88zuJ0TOqlsKyg/YJHLhjqN9VCQDjKdOS+3XIs3anhPFlddQFftuBQ9VkfBDgMgXV1ABJBVQI0xF2kzbX4rsAs2Z9fMlrh/kv8mg0VfyuyAVh04ZmQzvBeI6byXSccdJIIrHQHbbK4DwHRtlEszzVwlOy9EpZ0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 20, 2023 at 07:34:19PM +0100, Vlastimil Babka wrote: > CONFIG_DEBUG_SLAB is going away with CONFIG_SLAB, so remove dead ifdefs > in mempool and dmapool code. > > Reviewed-by: Kees Cook > Signed-off-by: Vlastimil Babka > --- > mm/dmapool.c | 2 +- > mm/mempool.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/dmapool.c b/mm/dmapool.c > index a151a21e571b..f0bfc6c490f4 100644 > --- a/mm/dmapool.c > +++ b/mm/dmapool.c > @@ -36,7 +36,7 @@ > #include > #include > > -#if defined(CONFIG_DEBUG_SLAB) || defined(CONFIG_SLUB_DEBUG_ON) > +#ifdef CONFIG_SLUB_DEBUG_ON > #define DMAPOOL_DEBUG 1 > #endif > > diff --git a/mm/mempool.c b/mm/mempool.c > index 734bcf5afbb7..4759be0ff9de 100644 > --- a/mm/mempool.c > +++ b/mm/mempool.c > @@ -20,7 +20,7 @@ > #include > #include "slab.h" > > -#if defined(CONFIG_DEBUG_SLAB) || defined(CONFIG_SLUB_DEBUG_ON) > +#ifdef CONFIG_SLUB_DEBUG_ON > static void poison_error(mempool_t *pool, void *element, size_t size, > size_t byte) > { > @@ -95,14 +95,14 @@ static void poison_element(mempool_t *pool, void *element) > kunmap_atomic(addr); > } > } > -#else /* CONFIG_DEBUG_SLAB || CONFIG_SLUB_DEBUG_ON */ > +#else /* CONFIG_SLUB_DEBUG_ON */ > static inline void check_element(mempool_t *pool, void *element) > { > } > static inline void poison_element(mempool_t *pool, void *element) > { > } > -#endif /* CONFIG_DEBUG_SLAB || CONFIG_SLUB_DEBUG_ON */ > +#endif /* CONFIG_SLUB_DEBUG_ON */ Looks good to me, Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > static __always_inline void kasan_poison_element(mempool_t *pool, void *element) > { > > -- > 2.42.1 > >