From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70902C41535 for ; Sun, 17 Dec 2023 00:18:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F22F26B0075; Sat, 16 Dec 2023 19:18:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ED3106B0078; Sat, 16 Dec 2023 19:18:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9B026B007B; Sat, 16 Dec 2023 19:18:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CA71B6B0075 for ; Sat, 16 Dec 2023 19:18:31 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8E3CF16069D for ; Sun, 17 Dec 2023 00:18:31 +0000 (UTC) X-FDA: 81574398822.12.6D3C171 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id E21E0A000F for ; Sun, 17 Dec 2023 00:18:29 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fY+v1Yom; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702772310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C1EyQtZrrzPsJdauHkagM7iwgSK3ui+7wFcf1Ql90yw=; b=sooG2qCNGFf6a+u7y4JoxMarzDA8/6QJbQsSSE9NuiwhORhJTOsEFd288gytOXt0rmJFdk j9WuO2tQjXXpQxKmeqmIdw9wKawmo4tQLXcW3Y4eu7IyRgmSO2qKHKinSEHMC7TCXmN/o4 KR+fckBWxV3rBz5IAjy4Ix18whKvr38= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fY+v1Yom; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702772310; a=rsa-sha256; cv=none; b=eAu1saA1SCQBIzr49JCWUO9b5RlfqGfnu8ees1yEsngWxw0XyzlRg0tcMotpqBqKTZ0xjE aWCrDKGLb6krkjIHytN2Ay6RsKHjIxmBWetsuPRQkl2RliSlZc+WVUBVIC8dg+usQwXhY7 197bkaGbo6hk4DiulU74JYZpO0roSGg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=C1EyQtZrrzPsJdauHkagM7iwgSK3ui+7wFcf1Ql90yw=; b=fY+v1YomSygsPdBd8Jdm4EwZ4/ Lo4ivfpOIdBieru9I2UKeMqgnxit8adT9+svb5ezPg/AkiCap0GNLwwnbbjx+lR6eXu++pYnmje2q OD5ac1zLfstFh58JX4h8u+wEjtz0VhEFXwKkfLgF7kaPPrCLQz2/hysUdcgP+EIn8YzJBW86rF9fM BXxJirnSvV4In+xhJcoomQQp1QRx4W97rs/jiH4UW2z0yY35d2/XrAz2a47f7a11iSs+ppnRiqE1f Km/XvzJZ01AWHw06hze7HJHb94HCR+nW60P+B57YKqkI2lcmwQfDeOkccQGxJGAacO5fMA+uzefNc OgkuZJjw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rEerJ-00BIOX-Vj; Sun, 17 Dec 2023 00:18:18 +0000 Date: Sun, 17 Dec 2023 00:18:17 +0000 From: Matthew Wilcox To: Randy Dunlap Cc: Kent Overstreet , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Subject: Re: [PATCH 46/50] preempt.h: Kill dependency on list.h Message-ID: References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216033552.3553579-1-kent.overstreet@linux.dev> <20231216033552.3553579-3-kent.overstreet@linux.dev> <20231216223522.s4skrclervsskx32@moria.home.lan> <82ed43c2-2a9d-4c5e-8ccd-8078397b7953@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <82ed43c2-2a9d-4c5e-8ccd-8078397b7953@infradead.org> X-Rspam-User: X-Stat-Signature: 6dkj55cjd3u7msw976uwt3cj8419pnti X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E21E0A000F X-HE-Tag: 1702772309-353206 X-HE-Meta: U2FsdGVkX1+rgyVM3xrftpaWG7RXhTS8CWXfnOS29GX5cn8x4RvNxA1LOx+W3p5aSP/XmPo2W3kh+trGH13xf7kg3vicIlGSW+Ygbt/uKutBt/BLNBUWmPm4boDZ/8w7rVSOdCz9F0V39KAx+VUas+33w7oUCMWurX4+Cqs5ve2oFhZs6IAhooYc7sgp+UJ6PAsX+5oUDAxOdFfCiXHvjnQUlKdlAmJu0CMFSBiZwE865yFyGwz7e8ez477lezOAO4avicSicDg/9zXipk45IRTtTBz3Xe7IbLs63VYzwJnjfn1pL5iy6nXSQwNPMg+O7wUrSjB2DP8sdR4EAk0ymAF54766+nEbP+KJf+WBcZzz1+ozOgPQVz7Ujcbx8yNxZPa91KK5/y08pOVWFVpFC/njMeiSg47cnXgUTkKPUxeBwG/GchXWw7p7fihZTHKzYTpzitrt/8i5IEjFKd0R/SKnreW5/H5pasWV3yS3VwE2wrdrSEFT4EZzkR8+osDGug0h9pWrL8ShGENCDO7hH6fcYJ9hbpBX8XEi31jEKD0Zn8XTnQa5KWooXPrLD3J++X63R4E6p2pvAoQ/R2x+pfz0/zJSW044iAjkn8VcuniCXeeN7kXKtZBay7jmBEckB6a1/N1hwIJSSpJ9zkvQX+xjZnVB/OHKbsS0kHAw6rMHUPbOew8di7rC7Zx5LqJVzUIkFAd/DLyn63AUml3HYhDfBj7kVDudYqxVEO5afP+yLtrCOZQE2fgpBeZwL6laZRzk6NGYylYNM1S0ivXlVVFpyCX8dIt81IlOGFZSDV783fzlOUzzhc93/ebTL9/BtndwtK5+BVXbCUPBUw9jXT9s0X4On6cw07P0ivXRT8M2GrWmMdmy/gklCuHzlYRh2uNdCX6QjEEFvXY3zIvrFKT5bclwTORA9TqlXIEv4ZDhHnpNuAg/JBJdN1irr32VT2/UJb/TUSEZ+W7rHhi g6CO/BjB uINEE4meJgrqWdk4rSbtVLcKgCi/PKmdvV9hzHGGcinOEuq7/HfbbLslOpCdt2KPukOlG1Z0yOsfB9SniCgwcljqZx6mhIF6FzoW6mQ/pAR77tGiGZN8EG0zLDCtwaI1AF/qet9BbjuBG3NVxK6rXz1eGIrsW678X+ebMxo8+ASgWmCHBDIcA5oOcr/VnnIU8xPK0j+4Fe4BWxLMOa/TyBkQbtg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 16, 2023 at 04:04:43PM -0800, Randy Dunlap wrote: > > > On 12/16/23 14:35, Kent Overstreet wrote: > > On Sat, Dec 16, 2023 at 06:13:41AM +0000, Matthew Wilcox wrote: > >> On Fri, Dec 15, 2023 at 10:35:47PM -0500, Kent Overstreet wrote: > >>> - INIT_HLIST_NODE(¬ifier->link); > >>> + /* INIT_HLIST_NODE() open coded, to avoid dependency on list.h */ > >>> + notifier->link.next = NULL; > >>> + notifier->link.pprev = NULL; > >> > >> Arguably INIT_HLIST_NODE() belongs in types.h -- we already have > >> RCUREF_INIT() and ATOMIC_INIT() in there. > > > > I think I'd prefer to keep types.h as minimal as possible - as soon as > > we start putting non type stuff in there people won't know what the > > distinction is and it'll grow. > > > > preempt.h is a bit unusual too, normally we'd just split out a _types.h > > header there but it's not so easy to split up usefully. > > > > I don't feel like I have NAK power, but if I did, I would NAK > open coding of INIT_HLIST_HEAD() or anything like it. > I would expect some $maintainer to do likewise, but I could be > surprised. There is another solution here (although I prefer moving INIT_HLIST_HEAD into types.h). The preprocessor allows redefinitions as long as the two definitions match exactly. So you can copy INIT_HLIST_HEAD into preempt.h and if the definition ever changes, we'll notice.