From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F933C4167B for ; Sat, 16 Dec 2023 06:13:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E16E66B00AE; Sat, 16 Dec 2023 01:13:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC80E6B00AF; Sat, 16 Dec 2023 01:13:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8F126B00B0; Sat, 16 Dec 2023 01:13:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BA39D6B00AE for ; Sat, 16 Dec 2023 01:13:49 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 35907A03A8 for ; Sat, 16 Dec 2023 06:13:49 +0000 (UTC) X-FDA: 81571665378.26.4E20287 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 426AD100007 for ; Sat, 16 Dec 2023 06:13:46 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mcxQLRcX; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702707227; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xTCeiRnVo2DjWRhzmP26oRimtFAuGMuZmVBxfVmUuk0=; b=yRNxyYKrDfb78+kfJp2MwnqMKQAx/wqIH2hVy4igzEQ9/XqLs/9+L1IYbHEUb8mDtvzLJZ yKzGpoH9F6OQyRz8griXcyGioyyML1J+W16DtmfpusTIpMEgMeWeodXIZwklymScyYSg3n dRHvnZBe1FUHyW9HsGq1K9VO3JxhmL8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mcxQLRcX; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702707227; a=rsa-sha256; cv=none; b=NSlz02aLHv9mMXmTuKIyFjej1OjkgDA3FnXIpwqdABYD23fx8ZGaEgDsKuTfgF6J/BoUbN xPc8nSX1gZSYMTdEfTRc+RJOUzMdctHgrjtJs4UKQUb7yy1BFgaE4SclMe/DqtWsjZoy5C jjHd3XRQ/KUtBExLRatmtv/K8nt8o7E= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xTCeiRnVo2DjWRhzmP26oRimtFAuGMuZmVBxfVmUuk0=; b=mcxQLRcXOnAQa9bcf+QRpJaGbe yka5CwzwHnLt9n6aj9xIiTKol5KUsSWtBTM/kf2SWPCnU/QwgaIlUlVofWhLmxR4Xm38l2RvVMosO duLTjj4rjncA3lGDL8vVGYMqdnxwQ3VTg/EvxqgjVY09sgq0GJCM0a94Z1+7RopZnt+6pId1LHyk3 bTCVIUH5/9F0C5sfgEQDkmJYKFcWUM7CC6UZiatqlgBWchLEDRElBQs1A4jF9GGZPCSPcbpCl7UTH w+uv1+6KpY1mnRy2h/ciT6E5mn+7k4RFlPJkU/rL8fHZ/rWFf7JbTU7b9w+EQf3rvPm+thcgrXJrh Sm9vR33g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rENvh-007aiS-1r; Sat, 16 Dec 2023 06:13:41 +0000 Date: Sat, 16 Dec 2023 06:13:41 +0000 From: Matthew Wilcox To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Subject: Re: [PATCH 46/50] preempt.h: Kill dependency on list.h Message-ID: References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216033552.3553579-1-kent.overstreet@linux.dev> <20231216033552.3553579-3-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231216033552.3553579-3-kent.overstreet@linux.dev> X-Rspamd-Queue-Id: 426AD100007 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: w53xbgcan5diyxsmrso81bqai1jfg9yg X-HE-Tag: 1702707226-91349 X-HE-Meta: U2FsdGVkX1+7nAs6ZuwrrEJWvqJdaYShBv3whSPt8t16h3L5MEanXZaS2QIHXc3md7dr8vLpKvPmFNVnwaVKX6lHN1t/zJDGcFanWE6dqWAQ3YheFfu+Olu0iPW/nqKPFWDqWFX3FfDE3smKVj//VtpG8P3/J2v59UcGYlMMrPmWObX4qhbX3qhMwF9n9HRiwc31XPi4Ah+65cYyYzQ6vwktyOBN62PTytaOymkyG2CbdF5lFr/1KyNS6p7hnOZGCXbtmM9LrkigT3WlTWOdKkRJ3rNmVKp3UgxbsV4E2Kk/xc6OgXPOM8JOghSsyXkGJeeY+u5FSBj94EzteKwF6YhMYS8yX7ir2toRp+iMlI6t9tZglT4elQUq4s3ri+KZdj+P5+vEDcceHI2esnPRfm1PXIP4SzjgxaST9gi8Wmi9EotbAxJ5VvqEpevgptIUFM135ZgGonEUXB9jBguDFREp83slsmsovEcISxZbBgekj6J/jRiaybO2eYFDXUP9sQRCln6556jLYISk6yk4DEjF4vXlTyz2uzXGUcsnjyDiMx8QmjIoOQ/8X2NqgHda4e+k9zfK2UrJKUmxHkkgTeUFUkt39VxlredlWFiEFsZKZdJXZvgEokhQPEskKs+HF9w58KpO/a12SBxxgIt2gKmaXthGWDqdg5GXBnFfuRUzxn4yYWcbi+FtDi0rPKrl7SQNawFZ3izlxnc2/mcTI3XLFvmDMjTegvc+sBIfeGCFnXrnJ+8XnIv3zAeDMVvrVaM4mBXa+ix1dwi98oEJOa7qQyRxJ2STVgaKNl5dqZEzKhkb6LKKG11DLgMwS+4daWXkCYV+ijTZBSa/PJeGUbSbXmXbheENzYmE/QlEnlMR00mH/652IWsFEdRp8ErJf4jzCh60fNb6vkp2192CNLRIN/QeFwi90HenyxXzogsjbWyokzbYFVUJXWKTWNhrtmFKOGygugv3iGLJMdF pklGbTIA cYRQhtQtTb4yBNoeWsuEEo0FBAjuw0TNPSRaUSNCGHDXAIaENPWxHbQYgdxzEr96kthtfnG5aTah1kWVw/DSziQIz0z/fnfktHkfJjEGFtxeeHcoIWM1YDT5fhJFtJIkyoVgYZFoXLAUVYS9r+qhH4n+l5krH5kNhM87/kKE5WUP9Q1V+/X+jPPefW1ciK+scVzL/0nBfZY17Fou2y5buSvyT2hxsuPIDg0sLaGeMNFavRbDQoVMPKIiesclkTRegObYh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 15, 2023 at 10:35:47PM -0500, Kent Overstreet wrote: > - INIT_HLIST_NODE(¬ifier->link); > + /* INIT_HLIST_NODE() open coded, to avoid dependency on list.h */ > + notifier->link.next = NULL; > + notifier->link.pprev = NULL; Arguably INIT_HLIST_NODE() belongs in types.h -- we already have RCUREF_INIT() and ATOMIC_INIT() in there.