From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59453C4167B for ; Fri, 1 Dec 2023 19:23:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5AFE6B0141; Fri, 1 Dec 2023 14:23:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C08636B04DC; Fri, 1 Dec 2023 14:23:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD1B36B04DD; Fri, 1 Dec 2023 14:23:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9B2746B0141 for ; Fri, 1 Dec 2023 14:23:34 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 70E638030A for ; Fri, 1 Dec 2023 19:23:34 +0000 (UTC) X-FDA: 81519223548.23.92AE41B Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf03.hostedemail.com (Postfix) with ESMTP id 941BF20023 for ; Fri, 1 Dec 2023 19:23:32 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="EpNyh8/B"; spf=pass (imf03.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701458612; a=rsa-sha256; cv=none; b=a8b413r7ykEOMTI8ROVDOg0GsITHICRKr9k4ys0syE+uMR1xvlx21KPNPsxPICsKhWRvoE 0MP5wxbJdfzotsPZVqw151wir8O1pHVCNC7McJPsFDOGO9vmggf1c2MQIvJjXhODBeoklJ KJ5WVIH815iUJN/Qpaudx5dHhDFEvus= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="EpNyh8/B"; spf=pass (imf03.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701458612; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zGnHU9tH1voo64tXXGshXyJbQMkreOUuj99Udj8dqZM=; b=6fBwBtZe4vwqwONw7nsMpP4c/xrRTm/wXocvUd4aZi1geiCZkDJa+gLW4I3VEWjJgd9kRC UssACRkITiowoot5YohFKuem2PlyeZLA3F+P7O9nq9iw2FsD/eifDOGl9vdK4wX400GR5b oZrsauT0o6SUsyhwTmS+4oU0FaRTstA= Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-28647f4ebd9so1676570a91.3 for ; Fri, 01 Dec 2023 11:23:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701458611; x=1702063411; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=zGnHU9tH1voo64tXXGshXyJbQMkreOUuj99Udj8dqZM=; b=EpNyh8/BPXCQf1JwbK1W2Iv2MimvGY8zE7ITCTO1q4RHmY8zrsmsFNX13nfK3o7II9 F0JJaqYwrtrChmo71lvVqoHZz7kY54YfBkvXKCehPBYA1GjwiFlUO8hpb33wpJrkPjqf DGYWj7Kc3frKNBdsCL1AymnJt7mPYCoxub60bFGN9VM+WhT95Spx7qvHIYoA7wGLJjv3 b51QBK3JnkbAjWqHtmDr0dfWMalQX+KRX5amB2sT25NZdFv35iPaaL587yxc0NRfPJN0 q3nS2MhOlzz9KaJX6u/iF/P0ByFYM/exQ0T3I6WwjSp3p1PDTrsh5Smg2SWFHm0khp04 SDfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701458611; x=1702063411; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zGnHU9tH1voo64tXXGshXyJbQMkreOUuj99Udj8dqZM=; b=hBrIPysDmNtAMh+aJ8RdKzG6Sw02zv1l5WFKnyw0wM+lgZtkHvAs8Zyqwu76mXO08F kgIYJfYHzrEF0MHHVlXrSAu6z974LVZmgw3/STQWsvZ304RH0SJKXWppVBlHM+adVeV2 U8hJtj/N85U2dCQzna8gfCWjc/sAxX0p/GvBOZfx9BtES/cQgoOy1T/n64ATQLZ8FFCL SebmPBRLkBo2hLBq8XVliEirT/RwFCbwbeDzKOVc53bBYbVXxp4rVhO7geA/eTM4HHJB iow6a4vd5oBKZDduS0eYBxZmlr1ziV8tdpxnhfn/8m0Qo/6mkTAsoOoKsh52pRqjJ156 YKcg== X-Gm-Message-State: AOJu0YwA4fmS9jSK3UM//Z10MyBnEiDDeG2kA0Sro7Du8X3AtC42kH3s +u33wA9GxULv3yE3PF3de2Y= X-Google-Smtp-Source: AGHT+IEmw6RSGSQ/Yb6hvuuNw6c2NWop0SGMdPfP5dw8/NJ7r0Z02Frxd2/HO3PybnKoEHNImS95sg== X-Received: by 2002:a17:90b:1e08:b0:285:c0db:8024 with SMTP id pg8-20020a17090b1e0800b00285c0db8024mr97981pjb.16.1701458610258; Fri, 01 Dec 2023 11:23:30 -0800 (PST) Received: from google.com ([2620:0:1000:8411:affa:609d:2701:8e46]) by smtp.gmail.com with ESMTPSA id nr9-20020a17090b240900b00286596711f1sm1711625pjb.19.2023.12.01.11.23.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 11:23:28 -0800 (PST) Date: Fri, 1 Dec 2023 11:23:26 -0800 From: Minchan Kim To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Sergey Senozhatsky , Matthew Wilcox , Mike Rapoport , Yosry Ahmed , linux-mm@kvack.org Subject: Re: [RFC PATCH v3 03/21] mm/zsmalloc: replace first_page to first_zsdesc in struct zspage Message-ID: References: <20231130101242.2590384-1-42.hyeyoo@gmail.com> <20231130101242.2590384-4-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231130101242.2590384-4-42.hyeyoo@gmail.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 941BF20023 X-Stat-Signature: bcek687u7ykxqw339rkwnsm6ibjzowrr X-Rspam-User: X-HE-Tag: 1701458612-612110 X-HE-Meta: U2FsdGVkX1/dPsAolW67YwO7RuWDq1frVD0F6JUB3BYL3xQe0iMJu8TMXHuAVrGD7ZIAcbwlwKEcR4TAnMHCwSuM82FMEuTbrMuEA/DhRxhg2bS6dlu1HKj8Yq0oCvOgtZ3Z3V4qGIq0/8wD/fJfmFi2CtJENBGSAD/gMjxwbcyAuaO4rUcxmILJEFzfpjvFXewFjNyS9BTVY4h9JvIulCVCbzLrSedtjtwM1GrOi/xOMtHsuTMMgqLFQi412TOEHmriLcqK2xA9aK8+WMgjygo/8qmQRKLZgvkMfsorywanbEcS10wTQqj6S6g5odGqqUmgxz7MUBGIjlYO7WiPpmOUUQPkdjzJMEwgetoj9sZIyE14TcmIVjstlS4igoJTmnnuCbwEWzrEcEQRrSC9xJ25Cb0pTTmTH+1B33NYWRlSzrrLgx8mtdy90CRi8x617cvDTWZG4QyS7cbS2Nq7lH4p61nYSPDBLhEqxtZqBmSrPGVcLgP4mTT4/dQ1w+PzSpdkS7NH/6mIe8uOXmmngWU7WsoWil5edVtqM58d3aGfkC5DtuLPdQIRi071CWJ0yWRZIf/7mKRNraklox8he/LMJYR2Q6Dj4j3jEDHPqjFABNhO7x1hbn/9IvSURjUNVhV9rE2SnU5/1+Wr5L26s7OOpArW5C0oK/FCDhpvFYS41757Tj35nt/dj/FGZ0fj3q+qRo6ZXfnnxfRbggSCdGneGSeXXYDThLmcsOW7jqW8+qNqbBkP83/IL998fnVQeCK/1DnPuLNzx98mXGjnS9vC4a3xQZfBX1cn4qLeaSqJOTZxgwxxEXMwOm9go4EBmwh46RkBTS9vzNVyF93O2ddnycj+qIeQDVArJ6KlZsfm8v13cXSWip7nXtZZ+4rlhlx45YY/hDOY3MceSws4UEtwU3T8evu0wx/bmc6aJuDMOvJinKbh7tin1qTRVF39Ppjt4Svri6ZtoPuE5UB LGLygyVn TMR1vHvrPtDgCXj227phadE0gMeIEoL7982+qubjRHOdJ4CusYJqVYw3RHvR8Hp9Igindmzue8VB/zwQDcsjq4ZI+N46ThwjcQ3IJtaxHbERDgKN/Wyv1Fq7KK5wEIqCuLxtxMlnRsoNOUCP18xJ2fDyZGe3aQR2TQmSV1lXTSOQECIN2njZvFyZzpoUfl2ckJBW4Z8MIKkXurVkrLD7gqxHu/nVsEVp8Pu9YUxCzaZz+ibx2OuyOkMyHuocL+4q9dvV/ENCOjv0wbV9Ltof6hQbeV6UZ1zXb/T3bCFp134mzirl1zSA77WMFVlGWlqX3tHNjjtTPt3ejfU+lmwTTbVos8UaWpcU5bE+rvH8fImVJDlF2LWxxeyErFIOqOCnmqDE2CDkPzfEsNr1V9BlU4d8N2NCbaxErtHhTUBYKdA4N4T5uMVBn1ndsZ9Livskt3NCByHWVPqsGtHHI5OIvr+/brnpAf7/l5od6MF8fVIa/ly1t6LOzqF+M371dLubTSu97D5q1A5uo/Sg3r3Rh90tB/ZJqJMXhh81/y3qv4yQQ54cc8kzjZTzCNKeHLuIovaGKxuq3na+4V/CRgbdI8ZlriW7gO1uF0zqrZFuRbeGqQbbuBXbMYIOB0JCPPPOhuDuAtxyc1Xr8FkEE1NmTsCEDxyYpqsFCjIMXcQleYOhLa8ktXT2xMTjtBoFsaWp/mheixZ5qHxpVXhMuoKlQav5jt/xbsZSQMVOOkbJ0ooh+lkFVrXmZ2/SSTwVmp2i8sU35id4nTeaTxK4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000239, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 30, 2023 at 07:12:24PM +0900, Hyeonggon Yoo wrote: > Replace first_page to first_zsdesc in struct zspage for further > conversion. > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > --- > mm/zsmalloc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index 47df9103787e..4c9f9a2cb681 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -317,7 +317,7 @@ struct zspage { > }; > unsigned int inuse; > unsigned int freeobj; > - struct page *first_page; > + struct zsdesc *first_zsdesc; > struct list_head list; /* fullness list */ > struct zs_pool *pool; > rwlock_t lock; > @@ -516,7 +516,7 @@ static inline void mod_zspage_inuse(struct zspage *zspage, int val) > > static inline struct page *get_first_page(struct zspage *zspage) > { > - struct page *first_page = zspage->first_page; > + struct page *first_page = zsdesc_page(zspage->first_zsdesc); > > VM_BUG_ON_PAGE(!is_first_page(first_page), first_page); > return first_page; > @@ -1028,7 +1028,7 @@ static void create_page_chain(struct size_class *class, struct zspage *zspage, > set_page_private(page, (unsigned long)zspage); > page->index = 0; > if (i == 0) { > - zspage->first_page = page; > + zspage->first_zsdesc = page_zsdesc(page); > SetPagePrivate(page); > if (unlikely(class->objs_per_zspage == 1 && > class->pages_per_zspage == 1)) > @@ -1402,7 +1402,7 @@ static unsigned long obj_malloc(struct zs_pool *pool, > link->handle = handle; > else > /* record handle to page->index */ Can you update the comment, too? > - zspage->first_page->index = handle; > + zspage->first_zsdesc->handle = handle; > > kunmap_atomic(vaddr); > mod_zspage_inuse(zspage, 1); > -- > 2.39.3 >