From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5061FC4167B for ; Fri, 1 Dec 2023 10:04:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D98A78D006B; Fri, 1 Dec 2023 05:04:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D48418D0001; Fri, 1 Dec 2023 05:04:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C374B8D006B; Fri, 1 Dec 2023 05:04:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B5AD38D0001 for ; Fri, 1 Dec 2023 05:04:28 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 87FF8A018A for ; Fri, 1 Dec 2023 10:04:28 +0000 (UTC) X-FDA: 81517814616.11.A163F83 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf19.hostedemail.com (Postfix) with ESMTP id 535CA1A0014 for ; Fri, 1 Dec 2023 10:04:26 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701425066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fwkox4Zdf2hnZaFjI6ZH8d+qJTEEYrW+vnW9MHVZ9I0=; b=Le8llHnM25ZWtTD7uvCNrOBWI3l7Fu2F0m5gwTyB1lY5kUNi49TmkFcEVZxoFJNNHMOme5 DFVC7E7eKDOx93ARniLpv8bLcFEVGciII5V14H0C9dwKUgFzd77wyPJ/gnerz3GWXl5dV5 CDv16vjE5DEcvb0KT2ReFcH4Alplh7Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701425066; a=rsa-sha256; cv=none; b=hoXZVXQcgNuY+1HO+f6IBxyMiL/BLPmozWBHu//blD+wmq02ooyLztvEnXklkRD7GgSLJM UDoq70AiGg+l0t0GbyeLaYUdD+9CBe9kPBGSY+byUdj7mIldb3zk37sYXwQKHpJrUHL2Qg cDT1nw4vt/QesMqatK2yEmDnr3lg754= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A80CF1FD68; Fri, 1 Dec 2023 10:04:24 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8AA851379A; Fri, 1 Dec 2023 10:04:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id kl3jHqivaWXNWgAAD6G6ig (envelope-from ); Fri, 01 Dec 2023 10:04:24 +0000 Date: Fri, 1 Dec 2023 11:04:23 +0100 From: Michal Hocko To: Kent Overstreet Cc: Roman Gushchin , Qi Zheng , Muchun Song , Linux-MM , linux-kernel@vger.kernel.org, Andrew Morton , Dave Chinner Subject: Re: [PATCH 2/7] mm: shrinker: Add a .to_text() method for shrinkers Message-ID: References: <4caadff7-1df0-45cc-9d43-e616f9e4ddb3@bytedance.com> <20231125003009.tbaxuquny43uwei3@moria.home.lan> <76A1EE85-B62C-49B3-889C-80F9A2A88040@linux.dev> <20231128035345.5c7yc7jnautjpfoc@moria.home.lan> <20231129231147.7msiocerq7phxnyu@moria.home.lan> <20231201014745.b2ud4w3ymztdtctu@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231201014745.b2ud4w3ymztdtctu@moria.home.lan> X-Spamd-Bar: ++++++++++++++++++ X-Stat-Signature: ejq9tonwouj5asgjqcg54adjkw8ocjix X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 535CA1A0014 X-Rspam-User: X-HE-Tag: 1701425066-343867 X-HE-Meta: U2FsdGVkX18dxxIV1CEH18LU8TvsCXtfjApyYsSfC/UJ9qxZMgdcWnLrH2HzSlxRphl2YgYhKXXREtOgPVVSKs2AEcHmi+TZ58A5UzyjdMmfYLh9Fw+9bcdHlG+vG682VNJHzdL1ghudC7uPFLD8Yz6JxPObTCm0iUBMrUtVb4INlzrN1K59r72RQ2x28t4n1aPFLhvuh5/enNSz5+R+i9Ga2RUOBBZWfiZNoapqo4pTfyoTduYBByh9a4/Rr4ZVSauNPKNY+9fZ67VQoMaYJFDy+e3qLX7SxkWG1d8UiUdaAzzj3benW93aYjZ0Mkhgz0K4uDOzUcA5iaPFuWRvFzGbbqyL7mLwC2chFYTfyQCjjIPzb6p9X4gFuga/2dodo5zeKp0bO7QqWds3f9aICzMr6rV8J+fzLUeB1IdJL/VI0kO5Hd4HLvWBWTW1v/pVQm0qTzLgyhioJM2IS1q7x4d/oA+Gh4z0rFHWhbGuD2jhE41UhxaFkxebqNxI9wPHrfIsfxVeSHDZIJ83APJhfcSDW4+bwtJT8YHEDBGhpPaGQ/wd3hLpJ0dIZVnEnwQNUf2l7hJKxOxHUiNBFxsT3LNLJbEdR7wR2k+gw3QXhjG5q77kUn9vTvRdvjFZtxi3subu1qeTny4ke/VQogYf0b0KMrJ73Gw1obQnGEWivUEmjAu5ZOg2Gdg0aApZmYrPmFszd93yHzLBWst5QVP0eeVdlbkjgB//RxtYcOW8J2YMOsdAKqvdMHvTjsMXQ5Q1cq7rRcDRFNRCm52gFb8tP4XJLhtCMThbVnM7aDuS8ZvXR7pO1PsPoEh2Ji9ZQlTTd6FpT9SfaZrXKcggI7MB/CouO1jhG8k/tCSCifSDvn/UTH13uoUohLgy0KKc925H9Jhsmmbrtx9vQm8PaZSyxl9h0TgL/sFkzZ/1GpmDN1ts9WmIHjFpITV9F7hgl2DJ5ixBx2bx1mOrH/ixZCB koMqD5D8 vGV3U7PPONgLwEuaMGs7LenFAYhqBnekjtsyxlosNN6d/DfChGTo1aUHHKVpb3eG2MG6qZ/sxX+xNaA9ncsuzhuoE7PtHkbxnd6mk57dLjnaW5RJJjeXT1koyLWdfwnOIXAMdCHLjbb080UXpbQIOFDKCI594bxoRxd6P3e5uawlFBc8gDwwfVPRW2lgkfTc7JbwU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 30-11-23 20:47:45, Kent Overstreet wrote: > On Thu, Nov 30, 2023 at 09:14:35AM +0100, Michal Hocko wrote: [...] > > All that being said, I am with you on the fact that the oom report in > > its current form could see improvements. > > I'm glad we're finally in agreement on something! > > If you want to share your own ideas on what could be improved and what > you find useful, maybe we could find some more common ground. One thing that I would consider an improvement is to have a way to subscribe drivers with excessive memory consumption or those which are struggling to dump their state. Maybe your proposal can be extended that way but the crucial point is to not dump all sorts of random shrinkers' state and end up with unwieldy reports. If, on the other hand, any particular shrinker struggles to reclaim memory and it is sitting on a lot of memory it could be able to flag itself to be involved in the dump. -- Michal Hocko SUSE Labs