From: Michal Hocko <mhocko@suse.com>
To: Dan Schatzberg <schatzberg.dan@gmail.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Yosry Ahmed <yosryahmed@google.com>, Huan Yang <link@vivo.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, Shakeel Butt <shakeelb@google.com>,
Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Huang Ying <ying.huang@intel.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Peter Xu <peterx@redhat.com>,
"Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
Yue Zhao <findns94@gmail.com>, Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH 0/1] Add swappiness argument to memory.reclaim
Date: Thu, 30 Nov 2023 16:57:41 +0100 [thread overview]
Message-ID: <ZWiw9cEsDap1Qm5h@tiehlicka> (raw)
In-Reply-To: <20231130153658.527556-1-schatzberg.dan@gmail.com>
On Thu 30-11-23 07:36:53, Dan Schatzberg wrote:
[...]
> In contrast, I argue in favor of a swappiness setting not as a way to implement
> custom reclaim algorithms but rather to bias the balance of anon vs file due to
> differences of proactive vs reactive reclaim. In this context, swappiness is the
> existing interface for controlling this balance and this patch simply allows for
> it to be configured differently for proactive vs reactive reclaim.
I do agree that swappiness is a better interface than explicit anon/file
but the problem with swappiness is that it is more of a hint for the reclaim
rather than a real control. Just look at get_scan_count and its history.
Not only its range has been extended also the extent when it is actually
used has been changing all the time and I think it is not a stretch to
assume that trend to continue.
Now if we extend the user interface to trigger the reclaim do we expect
that we always do SCAN_EQUAL if a user specifies swappiness or are we OK
that the implementation is free to ignore that "hint"?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2023-11-30 15:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 15:36 Dan Schatzberg
2023-11-30 15:36 ` [PATCH 1/1] mm: add swapiness= arg " Dan Schatzberg
2023-11-30 21:33 ` Andrew Morton
2023-11-30 21:46 ` Dan Schatzberg
2023-12-01 1:56 ` Huan Yang
2023-12-01 2:05 ` Yosry Ahmed
2023-12-01 2:13 ` Huan Yang
2023-12-01 2:17 ` Yosry Ahmed
2023-12-01 2:24 ` Huan Yang
2023-11-30 15:57 ` Michal Hocko [this message]
2023-11-30 16:56 ` [PATCH 0/1] Add swappiness argument " Johannes Weiner
2023-11-30 18:49 ` Shakeel Butt
2023-11-30 19:47 ` Dan Schatzberg
2023-11-30 20:30 ` Shakeel Butt
2023-11-30 21:37 ` Dan Schatzberg
2023-11-30 21:52 ` Shakeel Butt
2023-12-01 9:33 ` Michal Hocko
2023-12-01 15:49 ` Dan Schatzberg
2023-12-01 17:09 ` Johannes Weiner
2023-12-04 15:23 ` Michal Hocko
2023-12-05 16:19 ` Johannes Weiner
2023-12-07 18:57 ` Michal Koutný
2023-11-30 18:44 ` Shakeel Butt
2023-11-30 18:54 ` Matthew Wilcox
2023-11-30 19:39 ` Johannes Weiner
2023-11-30 19:49 ` Johannes Weiner
2023-11-30 19:50 ` Dan Schatzberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWiw9cEsDap1Qm5h@tiehlicka \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=david@redhat.com \
--cc=findns94@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=link@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=peterx@redhat.com \
--cc=roman.gushchin@linux.dev \
--cc=schatzberg.dan@gmail.com \
--cc=shakeelb@google.com \
--cc=vishal.moola@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox