From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67BE2C4167B for ; Thu, 30 Nov 2023 08:43:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDD506B044F; Thu, 30 Nov 2023 03:43:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D8DF06B0451; Thu, 30 Nov 2023 03:43:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C55DF6B0452; Thu, 30 Nov 2023 03:43:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B743F6B044F for ; Thu, 30 Nov 2023 03:43:11 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8F73FC010E for ; Thu, 30 Nov 2023 08:43:11 +0000 (UTC) X-FDA: 81513980982.12.9C6394F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 98CCC80009 for ; Thu, 30 Nov 2023 08:43:09 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XhkORBoO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701333789; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6duvYTCIHLWyO61x9wBLByulbCENKWZUW2PQV7NcSHw=; b=UptKk39I3/HTad+4omysh78CSzsC0APipZJ8pduauuLOwOu2lAH6wvQ38a3fNr/qQb41Ci bGra0RueEyQPewQxePrsDIA6yFjIvQQJvtWnlMIIH5VvECoOf4ZxtTVW/EfIch1xhIJxHm r/rAHjeMepssa8wsdjYdBrIcUwZKiyY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XhkORBoO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701333789; a=rsa-sha256; cv=none; b=ONuiKbXTPwyK0dXp52TF7Ia2WthIlGb6bZQUv803zQjBe+52XlXYEQ8qEY0hSiUXsT0uS9 G3+FlRgxfVW+UeJP8eq276b4vieyxzb9E9Kr6S30ZGL6vXQSuhj8IySOKtOCgooZDgH6cg zzAQ2qqdeZhLzjie+MxMByJwAT0vUjc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701333788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6duvYTCIHLWyO61x9wBLByulbCENKWZUW2PQV7NcSHw=; b=XhkORBoOEHyyUZtLNIbg7+QBqC54YmSYlqmHAw154s2kIFtkwcubmuEr5JeciYzeLvz9nD 2/iAoUXZr+Ab2g6LV2//h0/3Y+9Cx9j8QBHmQoEaGOKRT3dhmI1zp2Fsny84I14eUmvC+/ M4jPoRFK65NxaQTYfZxaih14X1KWjJE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-ItSKwKmdNPafA0h_-dQ4pA-1; Thu, 30 Nov 2023 03:43:05 -0500 X-MC-Unique: ItSKwKmdNPafA0h_-dQ4pA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BBB2B185A78E; Thu, 30 Nov 2023 08:43:04 +0000 (UTC) Received: from localhost (unknown [10.72.113.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A79D2166B26; Thu, 30 Nov 2023 08:43:03 +0000 (UTC) Date: Thu, 30 Nov 2023 16:43:00 +0800 From: Baoquan He To: kernel test robot , Andrew Morton Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Eric DeVolder Subject: Re: [akpm-mm:mm-unstable 25/192] loongarch64-linux-ld: kexec_core.c:undefined reference to `machine_kexec' Message-ID: References: <202311300946.kHE9Iu71-lkp@intel.com> MIME-Version: 1.0 In-Reply-To: <202311300946.kHE9Iu71-lkp@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 98CCC80009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: k6oxy5n7db4gt8ydapsdzawdkuh3so91 X-HE-Tag: 1701333789-463371 X-HE-Meta: U2FsdGVkX1/AjyN3F4iDJf5wUm6j+sx0ye7J2lQZTnbE7qvW8c7yQZGr05gs6v3/088rYKzbVtdmjlb4QFJN4AouoVNJdNy2RwvN8P3WVd6ttnkNpyHKhZAGHqE2fJW2gYKG0/4Lc0UY8StleC1uUga4Cjs2bkIR7ORc29CflE1UR435dJI21MpBnHIFc9wMlQEnAhJNnSYGrnWz/922RyQClmfk+rw/N4eBwp5KyfT19HT2c/J3QAnJ36GcewNickcdoF+4umwz0OOe28n0NMYB7w0gK8OBuHy/46XP04MZoaaN+WGwH50rJ9ZVpavaeqnzn5d2xFs4tVcohsrrbibkQ1WF9zL1QaFzQqt6r3diYYq0UBoZYeyxOJa5J/A+6bCYWct9h6OXl4em9qAc/Mry2BQEcbkfakzxTromjOcZK3KptsX0VJO0RJAxZPTPyIt9O6vQjjeiAoxAdLTozSGY2tZBU2eeGtMIfXw1uKzafcxJwrkt0BvXyLTB7I8oPHxRT6+xCXAn3anfG4wL+/VdagwZMFnycYQtXAoyDKMqkeOAyMFJoEPcbUCmsZv+ZBTG3lZ/rn81kbpEvtwfw/jjO/Ej4PWKDDGPBJrB7FYOGqu/BnvDbfdXtNfO+e+tArkpEsf0U/atEvqkEt8E9wRQS2wW3Y8aGZ0TceQxvGVaV8FA6asCVt0/7vp6pklAEvykz4p5u6llCQ52a10SnyX1m08SOXJAOIr6hOjWM1iewxx7VkP9LpzCOQed1UROAtQdn/VtQZ4QGR1OUcrTzc6UKtSQUU9qvk9JsMfo2FhPG1SD60ILK0sRjHktoDlKo0xxA5+1T7V6/1azlY0CK4zqi9zq9s9qSbcjfgQKH7cNRYjYy4Ir5tRMY3+8bp0v1+hzrcOqDH+VpRv/kI6tAZwVOB1EFUjjEf9H7EUiqmVjjB/crN2m//PcSf5k0V8gt4Ho4Y6+qZ68UrhNaZP 7vyyXsYU tQhoLCAP1iqPmAjVPaOcq0RTBY6tj5kUtZG3S+mqSf0fPhmz5MlSfNptCisIN1TtKTw3+oy7tkHejhjTFTtqgdqzMjDyGtOOGkRqR1VtnB2+ZTtcHzh27zkorYoU4lV9OORe8I3rP8F214RISlHnWAWt+1UxppPYhqoU+2Wdkagkah2VzzCmLYJTOUdD34l6Bd258aPLdaLsSRhrEvhvm4mSTvg6Sjsw8dphnVzHkZrrx36x5KHYJMnlRrH0pt4TYydcKjMnoaGLuVwJTbYA8Xkp7ZNHtY26QwIqPpgHYT7B/Hdmc1raYMvD/RvkTvtZyGvM4n/SzbtLbkxeO4dbzET5VMHC/wBf+1VbiLxW7akSmNX2BhDvCepy+1wtEWVxxEylRndh455cTMEiM8Bn3lGZfxA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/30/23 at 12:02pm, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-un= stable > head: cb1d236cb1038fa1bbae9913803f1c655b86d931 > commit: f8ff23429c625c2b2a134d87f490a89a98c544ce [25/192] kernel/Kconfig.= kexec: drop select of KEXEC for CRASH_DUMP > config: loongarch-randconfig-r122-20231130 (https://download.01.org/0day-= ci/archive/20231130/202311300946.kHE9Iu71-lkp@intel.com/config) > compiler: loongarch64-linux-gcc (GCC) 13.2.0 > reproduce: (https://download.01.org/0day-ci/archive/20231130/202311300946= .kHE9Iu71-lkp@intel.com/reproduce) >=20 > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202311300946.kHE9Iu71-lkp= @intel.com/ >=20 > All errors (new ones prefixed by >>): >=20 > loongarch64-linux-ld: kernel/kexec_core.o: in function `.L209': > >> kexec_core.c:(.text+0x1660): undefined reference to `machine_kexec_cle= anup' > loongarch64-linux-ld: kernel/kexec_core.o: in function `.L287': > >> kexec_core.c:(.text+0x1c5c): undefined reference to `machine_crash_shu= tdown' > >> loongarch64-linux-ld: kexec_core.c:(.text+0x1c64): undefined reference= to `machine_kexec' > loongarch64-linux-ld: kernel/kexec_core.o: in function `.L2=025': > >> kexec_core.c:(.text+0x2090): undefined reference to `machine_shutdown' > loongarch64-linux-ld: kexec_core.c:(.text+0x20a0): undefined reference= to `machine_kexec' Thanks for report, below patch can fix it. Hi Andrew, There are several places in m68k, mips, sh architecture which have the similar issue. Would you prefer one patch to contain them all or separate patches for each architecture's fix? >From 0549728ffab3c2e75f71b4696fa6f9709a85b946 Mon Sep 17 00:00:00 2001 From: Baoquan He Date: Thu, 30 Nov 2023 16:22:46 +0800 Subject: [PATCH] LoongArch: change dependency of object files Content-type: text/plain Currently, in arch/loongarch/kernel/Makefile, building machine_kexec.o relocate_kernel.o depends on CONFIG_KEXEC. Whereas, since we will drop the select of KEXEC for CRASH_DUMP in kernel/Kconfig.kexec, compiling error will be triggered if below config items are set: =3D=3D=3D CONFIG_CRASH_CORE=3Dy CONFIG_KEXEC_CORE=3Dy CONFIG_CRASH_DUMP=3Dy =3D=3D=3D --------------------------------------------------------------- loongarch64-linux-ld: kernel/kexec_core.o: in function `.L209': >> kexec_core.c:(.text+0x1660): undefined reference to `machine_kexec_clean= up' loongarch64-linux-ld: kernel/kexec_core.o: in function `.L287': >> kexec_core.c:(.text+0x1c5c): undefined reference to `machine_crash_shutd= own' >> loongarch64-linux-ld: kexec_core.c:(.text+0x1c64): undefined reference t= o `machine_kexec' loongarch64-linux-ld: kernel/kexec_core.o: in function `.L2^B5': >> kexec_core.c:(.text+0x2090): undefined reference to `machine_shutdown' loongarch64-linux-ld: kexec_core.c:(.text+0x20a0): undefined reference t= o `machine_kexec' --------------------------------------------------------------- Here, changing the dependency of machine_kexec.o relocate_kernel.o to CONFIG_KEXEC_CORE can fix above building error. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311300946.kHE9Iu71-lkp@int= el.com/ Signed-off-by: Baoquan He --- arch/loongarch/kernel/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/loongarch/kernel/Makefile b/arch/loongarch/kernel/Makefil= e index 4fcc168f0732..3c808c680370 100644 --- a/arch/loongarch/kernel/Makefile +++ b/arch/loongarch/kernel/Makefile @@ -57,7 +57,7 @@ obj-$(CONFIG_MAGIC_SYSRQ)=09+=3D sysrq.o =20 obj-$(CONFIG_RELOCATABLE)=09+=3D relocate.o =20 -obj-$(CONFIG_KEXEC)=09=09+=3D machine_kexec.o relocate_kernel.o +obj-$(CONFIG_KEXEC_CORE)=09+=3D machine_kexec.o relocate_kernel.o obj-$(CONFIG_CRASH_DUMP)=09+=3D crash_dump.o =20 obj-$(CONFIG_UNWINDER_GUESS)=09+=3D unwind_guess.o --=20 2.41.0