From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 838BCC4167B for ; Thu, 30 Nov 2023 03:29:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 092D06B040D; Wed, 29 Nov 2023 22:29:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0430B6B0422; Wed, 29 Nov 2023 22:29:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E73F26B0423; Wed, 29 Nov 2023 22:29:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D8F696B040D for ; Wed, 29 Nov 2023 22:29:34 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AFEB31606AC for ; Thu, 30 Nov 2023 03:29:34 +0000 (UTC) X-FDA: 81513190668.01.13051DF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 4EF8DA001C for ; Thu, 30 Nov 2023 03:29:32 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=X30FX6Ro; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701314973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KzUCaiBxlCQAig49WO2ddiIpIQAq6C9H0nvIt9MnJxk=; b=6NIojQdbVELpjg9a471dBw/4QrlMkfg8oxDyHcTaS4NnLDmXwHrmnZJB5coYYgaal+X0H4 UIxrAjLy5fBO2usfJrpTQ45vXhLgBkDEPyRecvIXltcM4OT+A0W7n5pNN2SH5rEen0JtJS n5VatpEZyG+IyEK8q/lFjJCASdIfP9w= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=X30FX6Ro; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701314973; a=rsa-sha256; cv=none; b=5HXtwatt8kuGscPLV44sKJx9HkiWeQXJvFvq/5aojOFy+8T15P6Tnuz8M+EsTGcBHc+6tg FG0B4Q/3UKLykvAk+PkTt4Sxvi2AqeaCnXvCLcZnQqdVIysBcfrPL4D38cLBh4xGgMA6tf gYxYW8fxbQAHebZ1ydmRfOVOdccuEpI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KzUCaiBxlCQAig49WO2ddiIpIQAq6C9H0nvIt9MnJxk=; b=X30FX6RoIF8uET3Kc8+Mi1Ti7y rnuewCmgbFVJtaHP8jqjWa1iVEUV1CWxeSxrfFkrgf6x0jbq5jiWkIK7Mx1e8uficbB6HkWI9tvDe tStb/WnFgn4eJUYGl89zpWd2UnW4exHZI8B3KQExvS7hVq4ug60fQ6/jQKcQzFiOShWMiXsQBfgC/ Xvf411d8LvFmNSeNAGaZqDO7UAjzmJX2mH7mfGw2sruSsdwUF1sy03kT7+Vs4hiXOqz8KsZlP/BS5 4Q91rLFDlPqsYg0qouu0LStvdF9Fu/aDx5r1wl6MgFOgyNcC3zGCSuRRXGEi9Ik6plrOpJ1MWER0H vg9Hr2Rg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r8Xjz-00E2d0-CZ; Thu, 30 Nov 2023 03:29:27 +0000 Date: Thu, 30 Nov 2023 03:29:27 +0000 From: Matthew Wilcox To: zhiguojiang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH] mm:vmscan: fix shrink sc->nr counter values issue Message-ID: References: <20231129130126.2130-1-justinjiang@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4EF8DA001C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: d7udfn8xuczmy44r4cjf4ejk3jq97y3f X-HE-Tag: 1701314972-896655 X-HE-Meta: U2FsdGVkX19OBcobs8VvtO5BlQOFL5fjl2berDCQpzTMGe9/4b9f+sRxL+SwTrEZO9EsixAWkbo2UrZZ1sllBQmRgEMCJw1ZuZIuf/jF7chiVpy4Ao9WdZehxy1BhgjmFOLeALd8rXngp1XE3NHvZIonoL8HzSOfzW1rYukGgO2Jtt2Zvsup8A0Lj0euebwH+DYgWKhVj3GUJabUnmU3YgJS9mT4hBJdhq93kmTH8VAe49tCOGYwc+XF1j94vwNtVJm4ddBceUcDK7GxFqAnYssLQiY3NvvlkqkvkgC1J3Gd+gfOmWYfgO5/y7bIh4biiqb/UZCiLbOzy7JD9q7pA6YBhljTP8ByeyILseZVPjW9swO+9f+b3CW/bIZ30S5rsBMpUxFOCvDBM3c9aLRUR8rh/0nYBWoO7mx2r8PcoJI24H6oCvdnjYuzGFCGBIm+89K5KUHNkExozq/FS89UX/LV9zVNIiioKWt1b9/y/09N3LSiFg3k0R9a+3Ue3qCBy7gDVBdq1CUiu8gUwT2+4o8gKWrcIRQ78fGTI95Pu3odp2/lWfAXseOpcS65x1sdC04ChzlQyooMXESrW4HI+vd4dImlxEGK0bjOOQwQzsw/rVML9fAQR9OoQ71KQw74rbEHTvauc0SqXmLMJGRp0lB+QCV27pQH4upoOY3Q1noojdunn+XaADeNgl7T9J1Maq1XBhlUjctpKY85THhN3Fsjqu362V9Y2hBkGtqGRy+KDT9HAhmZlhZLSQu7rSKV8ljgYkx3LZuxd2R0obYPd6LbbW2bUy63x/qh95FybZ7/oIw66YN3owOIzxngDDbXGT9aNAyaTwFtEFNeQc5ttdmcXeaUy8efIy0dC82l/ErF6a62zz6wAR/RH1eF/icXrFGNtbr3rPfL0Dfr5rq+OKSkhrBc6nMOUKEqgPp7LNqJ9bOqS51wieT9xq3pfD5nglgRDBs+c/lYwOMpKgA 0qLK5ObE 1pPJumbqwqqWNMSeP11DzZryZE2+D8yHlqoyIpjFHdo7FUJmdVwuJMMgfaPjufxlpSthiz01vC1H60Xc1k2inptycJAOjfK7+6uKRG+8MWuSbzhQYB2YSSFR0Gn3s4GMx5yD0S1vbO+MsnLg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000044, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 30, 2023 at 09:56:59AM +0800, zhiguojiang wrote: > > > - * If kswapd scans pages marked for immediate > > > + * If kswapd scans massive pages marked for immediate > > I don't understand why you've added the word "massive". Do you mean > > that the pages are large, or that kswapd has scanned a lot of pages? > The added "massive" means that there are a large number of pages marked for > immediate reclaim on evictable LRUs. Then the word "many" communicates your meaning better. "massive" would mean that each page is very big, while "many" means that there are a lot of pages. It was foolish to send out a v2 so swiftly. Best wait for someone who's familiar with this code to respond to it now that you've clarified what you were doing.