From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C6C6C4167B for ; Wed, 29 Nov 2023 16:03:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 014D26B03B4; Wed, 29 Nov 2023 11:03:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F06C86B03B6; Wed, 29 Nov 2023 11:03:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF5C06B03BA; Wed, 29 Nov 2023 11:03:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CF5AA6B03B4 for ; Wed, 29 Nov 2023 11:03:35 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id ACC61405C0 for ; Wed, 29 Nov 2023 16:03:35 +0000 (UTC) X-FDA: 81511461990.09.485F39B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf05.hostedemail.com (Postfix) with ESMTP id 8C65510013B for ; Wed, 29 Nov 2023 16:02:42 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf05.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701273763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i+2sG/kjJf9M7kpqxI31ZucX7BFcL70nR+1qm7SEH4c=; b=XVkyPEGkDxNb9VwwthqfDZZyvjtP4hXfMz8UqoGHzlaTu+cbU9jJTEmeMAijMNONYTKHNL rWcFbgPcfKdakL7Ul6ydgSsXkfZrNU4hpfzkIGmnb8CjrF0pkjPjQI7CKgUZaR/Wn/4joS DXo3Lt+97nDonnsNVhrm6Fd3bwfvRfs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf05.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701273763; a=rsa-sha256; cv=none; b=gf868CTaFWt2zn/oLdPqzycs7+edJHYZT0v8J2YqN+RxG8IY4kqfuII9lAZ5eTcoc7QUVV K7gZyu8kqhipSMxCArGDd+ZBe1AbxDbC/VdU/cqmzXR6a3YtGW+hDis9lm0Uv4ivOHAf4m jiI5FfYNISxZRfxjAeFWwzQqr2iAAhE= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B72421F8D7; Wed, 29 Nov 2023 16:02:40 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9A8F71388B; Wed, 29 Nov 2023 16:02:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Nzq8IqBgZ2UWewAAD6G6ig (envelope-from ); Wed, 29 Nov 2023 16:02:40 +0000 Date: Wed, 29 Nov 2023 17:02:35 +0100 From: Michal Hocko To: Kent Overstreet Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Qi Zheng , Roman Gushchin Subject: Re: [PATCH 2/7] mm: shrinker: Add a .to_text() method for shrinkers Message-ID: References: <20231122232515.177833-1-kent.overstreet@linux.dev> <20231122232515.177833-3-kent.overstreet@linux.dev> <20231128174853.vdpwullepoxg5blo@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231128174853.vdpwullepoxg5blo@moria.home.lan> X-Rspamd-Queue-Id: 8C65510013B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 7zrn51pyb4rcjrbnf8opcokpq797fjoe X-HE-Tag: 1701273762-57811 X-HE-Meta: U2FsdGVkX1+LKTrd7lyBN6b+mdW931AjuikYDFgLpS7WltBgKy0pM7Cpg6WHrK2EwkhOsVGzi8g3Odv1FvgyFKEatIf8mnk0rE09idwkKDbcvg4sKyyboQbrp0bKCFUO7F3tanogBEdq61VF6h/LBV9h80QSfHLuQCgRpKyo5/4oVmfXGvSA3YKpPiM08Wk/vtpP/v5ekwGmdcpJxbUc92UHMy3f647PYiZvlr15wNzflYkSC9AmwK3nMELIHO+NBhtRnDfDw3jYFupomtyzwuOr3BQJ2PYK9DFjEg01O/sofnywtqP4dsae7TZzny7Einzjon5Z00azGXBrK0/WmOnp2UY62ra3GSI+eB7AOGoKxcoapIqYwVSsSnEeaJENWfwsLqYt9m2UnVUMcLYOzA0p128wmycgDPWl/PjLXZStTbbyKuby7mVqwiGeMw6ksuEivLfOZ1JwhsCrERPsvdk8u8o2fEeYJZJzmsWZZKyCOws1UcLYVCsIrT7f9iej400Dr6CTlP81Du1AVQSD9emAwqSH7GE85U+D1ExGGCYLGOiLd6S64KL7tdrh6HlbQQAKr3w+PBWIgZYlk92KxF/AfEApuT617E+mz+LVJ93+yC1j5eQvNS+b8O+kv1E5gM43fkPnOSDZug6feNOPsNPLW+pcx+8hM/imgR4M5PR1FNmT0ljOkztsmHMJO3cHKi3dABtAXfgDtoZ8qsVY6MFK5vutG9l09VUz6Z9jSuVAk/FD73fANUhnlEX1qUi8fL665hBRPz/MEd9O0is4WI7Q5cQvPFzP40f/YnDMyNSb3X0667ubulkl1OHVypOq/7lVT01qp5DAzVzn1l02Z2skjt3lHtawsctoBH4JkgKx3+hzroGrrRxLf32Z6U0z8wLqvBHNk+nH/6tUUUNVmObx0C503tK6xbdNcVJ35lVqlnK/2P6htutnVuy+FlLT7njxA2+VhG5nr4C8w+h g/OfB4k4 I/+0Ej7xAWfx3s/yYTN3TS/yobzgXY4697o3K7AQ+Q4YFzSJ2569JfzFvkThsThHTqJRtJADNwGgU8cZ6A3L4mS6XOvwrNb4i6D42xLuzqoWAbA13eyrmh2cEBc651VJLTFqTUh5a5fDzpbBEA8C7B29RAh0t5bHgmC+vLGGGrve2HKn3mfFqCsncAWa/2J2dr6w/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 28-11-23 12:48:53, Kent Overstreet wrote: > On Tue, Nov 28, 2023 at 11:01:16AM +0100, Michal Hocko wrote: > > On Wed 22-11-23 18:25:07, Kent Overstreet wrote: > > [...] > > > +void shrinkers_to_text(struct seq_buf *out) > > > +{ > > > + struct shrinker *shrinker; > > > + struct shrinker_by_mem { > > > + struct shrinker *shrinker; > > > + unsigned long mem; > > > + } shrinkers_by_mem[10]; > > > + int i, nr = 0; > > > + > > > + if (!mutex_trylock(&shrinker_mutex)) { > > > + seq_buf_puts(out, "(couldn't take shrinker lock)"); > > > + return; > > > + } > > > + > > > + list_for_each_entry(shrinker, &shrinker_list, list) { > > > + struct shrink_control sc = { .gfp_mask = GFP_KERNEL, }; > > > > This seems to be global reclaim specific. What about memcg reclaim? > > I have no fsckin idea how memcg reclaim works - and, for that matter, > the recent lockless shrinking work seems to have neglected to write even > an iterator macro, leaving _that_ a nasty mess so I'm not touching that > either. OK, you could have made it more clearly that all of this is aiming at the global OOM handling. With an outlook on what should be done if this was ever required. Another thing you want to look into is a NUMA constrained OOM (mbind, cpuset) where this output could be actively misleading. -- Michal Hocko SUSE Labs