From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4387BC4167B for ; Tue, 28 Nov 2023 17:21:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B64CC6B0336; Tue, 28 Nov 2023 12:21:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B14B56B0337; Tue, 28 Nov 2023 12:21:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A03A46B0338; Tue, 28 Nov 2023 12:21:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8FF4A6B0336 for ; Tue, 28 Nov 2023 12:21:41 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6821D140115 for ; Tue, 28 Nov 2023 17:21:41 +0000 (UTC) X-FDA: 81508030002.11.9AA35C2 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf13.hostedemail.com (Postfix) with ESMTP id 9B8D120013 for ; Tue, 28 Nov 2023 17:21:39 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf13.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701192099; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kH/XzlZMX8Ixh1+AuqOipvEBoTIRxmoJmgvalr7cNQA=; b=6lCPbJjNhXkGvLrxIlfXZ0YVnF99xXAb1AhWzMmKUBQQQIDlpSAgl5yi8TAV/RFItfhn6P wtjyMF/HNiBEKPu/VQZ9fT23Z48bbfs+Cn3yn7M5JNo5RIk4bVFZ+yaZRQrqM2QlhcAIfL cAoWSnUpcdW7iIpgzxdzqd5D+WLDhIk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf13.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701192099; a=rsa-sha256; cv=none; b=xq6Il16hMbyJvuuHHrSklal83drokqnxHRb8mNgRuEmv+Oap9pLahHAb3vcNrd4LODPvgy GW/m54oBvSu8IZSRJsasOrInfOZF8Qwrs4O84S/xCue147AvyaGmPF1fjqkQMCidM6NNBP xfAm7L18XPBELRAZH3JxVBoEA58qdoA= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 388A1C15; Tue, 28 Nov 2023 09:22:26 -0800 (PST) Received: from raptor (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D45D33F6C4; Tue, 28 Nov 2023 09:21:33 -0800 (PST) Date: Tue, 28 Nov 2023 17:21:31 +0000 From: Alexandru Elisei To: Mike Rapoport Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v2 04/27] mm: migrate/mempolicy: Add hook to modify migration target gfp Message-ID: References: <20231119165721.9849-1-alexandru.elisei@arm.com> <20231119165721.9849-5-alexandru.elisei@arm.com> <20231125100322.GH636165@kernel.org> <20231128064957.GI636165@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231128064957.GI636165@kernel.org> X-Rspamd-Queue-Id: 9B8D120013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 7qsm4odkabtnf1c9y8amor6aw314sa5q X-HE-Tag: 1701192099-976238 X-HE-Meta: U2FsdGVkX1/3Oi2lCsgTI/CLhiI2uLnJ8LJ6XCv9V56JgGjsHL7Dq3B3Qhav57UDSAtVQAlPw26jz+aniN+6uJ3X/u/rNVHSBRLqre0oFBbagHeKO3HJkpKJK2Mu+v617pnuQ8Cz6IiHzp/jxnxismDBKiIPpa87jAlzxmi7Bd6p5LwKUwi+/Ap3VVfL4qm6avxWoLufU5ksa7+B/I4E5Q7B+/vNby2c5VKZEUq23zRSVjz0Ig2QARnoLhNPj6MBJyDUgdvnf9uiB3drwUa14nlZ79iYcXltmw0cEQzRbklR3iaNP+fhAAQcqdnHNgkC8qupW51pEjMwJFRzmn0S/8qckpna6ac8ifttZznK8n2ZUpaAJzWtS+fAAUF38Ky0xuSgO+ChBM5imFLd6eveivRvFQqdDGZAQ9MpF6ZCarIyvh8zrO2TZ3VaXORESzvUUxZ4SOt4vQ1TiM1GAaoeDR/rDg83IxZuecBA+rbT2S9g7vCzNJnwDu/YWOfmBBbr3kg5jwvCRoGB+zXkwDqrSvTXko9CDxGgfffoJ6Kj70Jo6UMDvlWbAyXIgwcB38+q6ARbsJvRfLawwrxzgWEh1moHg1/T0KcjKFFtAX1vXMS4nVQLFa8T6LDkPwgJlItlCFQThVtsSU2v7r5q4XV6K3C3g+lnRzLim6Wm+AEUb6yRwz0CV3Sg05ityxB4y4Lf3pWrYMT4G+gvMitI9H3ePl/+XpIC/AnmZqNnKwUf//iTL4wuyE0hEecQCpomFnxAb4nyx9PFV1cvSkLbKaIn2AIdIe2rXstqZfbGCXWkEiLlhiBak+eY8SLqx3MmsWZRz7AzhdgEOm8a3vqVUQxC5KxRFr0qcWWNvU14wwcmEzZOUXoXJFOpK8YgF/x3irEigBZRJk7GKgbtcH5T8jvBwxEaEgRoUFtdJQ5b+9TIstqHD+K27L/cIhJpSO1inTN7AagfIJetm9xR9Gpu2tC XFFNKXY6 4ZwgKBek76CVgRFAYAccOXMPtTFCXS8oluvRdoKYpf6CzxxhPntYoBUIk392jhEj8KjSga5BTwXFMxXTOoUPMYO++v81O10SqMmuZEO+ttS7LHQvVoHd+QsO69tt/Bzl+p0EPRR4ohUwwjzmI+gcC7w1SQYWZeJuX+6cE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Tue, Nov 28, 2023 at 08:49:57AM +0200, Mike Rapoport wrote: > On Mon, Nov 27, 2023 at 11:52:56AM +0000, Alexandru Elisei wrote: > > Hi Mike, > > > > I really appreciate you having a look! > > > > On Sat, Nov 25, 2023 at 12:03:22PM +0200, Mike Rapoport wrote: > > > On Sun, Nov 19, 2023 at 04:56:58PM +0000, Alexandru Elisei wrote: > > > > It might be desirable for an architecture to modify the gfp flags used to > > > > allocate the destination page for migration based on the page that it is > > > > being replaced. For example, if an architectures has metadata associated > > > > with a page (like arm64, when the memory tagging extension is implemented), > > > > it can request that the destination page similarly has storage for tags > > > > already allocated. > > > > > > > > No functional change. > > > > > > > > Signed-off-by: Alexandru Elisei > > > > --- > > > > include/linux/migrate.h | 4 ++++ > > > > mm/mempolicy.c | 2 ++ > > > > mm/migrate.c | 3 +++ > > > > 3 files changed, 9 insertions(+) > > > > > > > > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > > > > index 2ce13e8a309b..0acef592043c 100644 > > > > --- a/include/linux/migrate.h > > > > +++ b/include/linux/migrate.h > > > > @@ -60,6 +60,10 @@ struct movable_operations { > > > > /* Defined in mm/debug.c: */ > > > > extern const char *migrate_reason_names[MR_TYPES]; > > > > > > > > +#ifndef arch_migration_target_gfp > > > > +#define arch_migration_target_gfp(src, gfp) 0 > > > > +#endif > > > > + > > > > #ifdef CONFIG_MIGRATION > > > > > > > > void putback_movable_pages(struct list_head *l); > > > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > > > > index 10a590ee1c89..50bc43ab50d6 100644 > > > > --- a/mm/mempolicy.c > > > > +++ b/mm/mempolicy.c > > > > @@ -1182,6 +1182,7 @@ static struct folio *alloc_migration_target_by_mpol(struct folio *src, > > > > > > > > h = folio_hstate(src); > > > > gfp = htlb_alloc_mask(h); > > > > + gfp |= arch_migration_target_gfp(src, gfp); > > > > > > I think it'll be more robust to have arch_migration_target_gfp() to modify > > > the flags and return the new mask with added (or potentially removed) > > > flags. > > > > I did it this way so an arch won't be able to remove flags set by the MM code. > > There's a similar pattern in do_mmap() -> calc_vm_flag_bits() -> > > arch_calc_vm_flag_bits(). > > Ok, just add a sentence about it to the commit message. Great, will do that! Thanks, Alex > > > Thanks, > > Alex > > > > > > > > > nodemask = policy_nodemask(gfp, pol, ilx, &nid); > > > > return alloc_hugetlb_folio_nodemask(h, nid, nodemask, gfp); > > > > } > > > > @@ -1190,6 +1191,7 @@ static struct folio *alloc_migration_target_by_mpol(struct folio *src, > > > > gfp = GFP_TRANSHUGE; > > > > else > > > > gfp = GFP_HIGHUSER_MOVABLE | __GFP_RETRY_MAYFAIL | __GFP_COMP; > > > > + gfp |= arch_migration_target_gfp(src, gfp); > > > > > > > > page = alloc_pages_mpol(gfp, order, pol, ilx, nid); > > > > return page_rmappable_folio(page); > > > > > > -- > > > Sincerely yours, > > > Mike. > > > > > -- > Sincerely yours, > Mike. >