From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DC59C4167B for ; Tue, 28 Nov 2023 17:14:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 803A66B0334; Tue, 28 Nov 2023 12:14:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B3176B0335; Tue, 28 Nov 2023 12:14:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 653BF6B0336; Tue, 28 Nov 2023 12:14:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 52FD76B0334 for ; Tue, 28 Nov 2023 12:14:00 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 27F6414028B for ; Tue, 28 Nov 2023 17:14:00 +0000 (UTC) X-FDA: 81508010640.02.9D0BB19 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 03B5840018 for ; Tue, 28 Nov 2023 17:13:57 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JG0Zn4aB; spf=pass (imf11.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701191638; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vm0O4QHg+NgUnD86syn9qOPr1P8d6e7mjB/3wAPf3vo=; b=WtjtLg9cXUcd3XgEkzpzAXEBua0OP9q2bZU/DVF35tMu5J2DjfomTPkIFFtVJUUIyyDpmX k+CV8Dw9atX1XwQxwMCu8XDN3vM4qSYLz9iPrjkgUFPQXqxS1MWpGZ5mmIduAkAAwaTZDq /wR1Khqi7ouSyweot9XhU88lY5GbydY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701191638; a=rsa-sha256; cv=none; b=bivyGEHbqOi1S22fJ51/BvXMbFLKRIA0CXPLSxoM36358tSflthW5eElmWaaMgeE5t1TnQ 0PNQ6+TW3myDSQWfCxSakHRizAqZdRzV+S2QoqY66P6FvW8KU54eTuJUetdb0E1rRdMI9h q4bqfhsVAuAjE84lF1yL3FjUTQl/X80= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JG0Zn4aB; spf=pass (imf11.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701191637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vm0O4QHg+NgUnD86syn9qOPr1P8d6e7mjB/3wAPf3vo=; b=JG0Zn4aBuxFq1uUDjYuPSrafcxfJRm4wKeipRGudSYbEtFbJv801lwNuv/o7/hqTBOI8Ww NND5dgq+Jbf4WdNpscj8SA+vv+nVnuMOS4Gjouv/7E3NAevDtC2qTOPEBsZdqivGxDCE42 vrXRM5UUkS+d/dVQanKjX0ebTFIdJqE= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-r93duJ7yOMmGEkDdJQyRFA-1; Tue, 28 Nov 2023 12:13:56 -0500 X-MC-Unique: r93duJ7yOMmGEkDdJQyRFA-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-67a1f38b735so9823526d6.0 for ; Tue, 28 Nov 2023 09:13:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701191635; x=1701796435; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Vm0O4QHg+NgUnD86syn9qOPr1P8d6e7mjB/3wAPf3vo=; b=RJpX2xtaYZCpEI3kHRUJIo29tIyFjvLXaWctjby8DhiF196ITka74GPT4Vaz5AYj8f 9a2kcW+Zp0TkPY6HgI2pgEUoCgozh4Z30CGMZjPN95XUb6heRa58XPmzSDR6ggvoEDsD Rc/MMr/Mcb2yQsuSOqB5YxTfHgRqGVSN0oWmG4I6RhmhstXmFmNKG5PcadysrLQ8r7qi l7sErALP5/4/HanS6sPCKitgWIYWKam3jYrek25owmgbzpYO5OEQCATC/ZcmFu59Z+6x aH0BFQH73iMsWXSFwkMjN9OWkel10pcTDlnJbEtoQgkPjbjufyajNF4Wa7wQPZHDUaUV uxvA== X-Gm-Message-State: AOJu0YzNmVOUgEen8pDWj/Ia68soi7Z4qB4wy1iE3CEA9ZbmpL+KX+If mVsYOu8P9ht/qQxOAShGbfGZlW/Zjiv7buBEOhYGqvp7gjj73LlbdtYzoUZ0mkgzhY1wsY4ih/x QnmaA8qxgEcI= X-Received: by 2002:ad4:4982:0:b0:67a:14fe:f3b0 with SMTP id u2-20020ad44982000000b0067a14fef3b0mr15322576qvx.0.1701191635460; Tue, 28 Nov 2023 09:13:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFJRvkNDdU6zlDl3D0OUvysyyYQUO1Hv+GVAM1w4yF9cirbcHTWlpqNkLPcp5RbuilymG8ckQ== X-Received: by 2002:ad4:4982:0:b0:67a:14fe:f3b0 with SMTP id u2-20020ad44982000000b0067a14fef3b0mr15322557qvx.0.1701191635195; Tue, 28 Nov 2023 09:13:55 -0800 (PST) Received: from x1n (cpe688f2e2cb7c3-cm688f2e2cb7c0.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id w6-20020a0cfc46000000b0067a3f82c44fsm2265033qvp.138.2023.11.28.09.13.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 09:13:54 -0800 (PST) Date: Tue, 28 Nov 2023 12:13:53 -0500 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mike Kravetz , Muchun Song Subject: Re: [PATCH v1 2/5] mm/rmap: introduce and use hugetlb_remove_rmap() Message-ID: References: <20231128145205.215026-1-david@redhat.com> <20231128145205.215026-3-david@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 03B5840018 X-Rspam-User: X-Stat-Signature: 58t14xzu8ku7rimifoxedwk13rt8be48 X-Rspamd-Server: rspam03 X-HE-Tag: 1701191637-109873 X-HE-Meta: U2FsdGVkX18KMqCSbzrkNgQTGtu1QyOjl2pK7F/r0v3xuUFNt2sjIxeExKsJuJDfcW8RRqsZgvYM9mh0kxqmPY0P201WBKUwke3jm2i4nt9FsrfXaeNPEffxRiX6uWuv+tZk+12pQW78KkYjicScxX2S1uUeGSRHFrBleDKQOQEuIRY4s2MARAPnJ/tyYKt6+F4pI05T/V5EDLVZN7NoGZwZJotVVdcTcv9j7zNMffqNTefcWWEDcT8EqE3YIK7iT4K14TjGIErdujTkZmcHRJVdrPlS+KjxBw1RfSurz3wcc680UgDg5vzNGXWpTvS9hjN55nU4m78fOAdcis+WhclVsv7xSsvM9mUdbr0k97PUyDy7LXAA+wOfGYVmkShQJAtRdoKumGgLbjhtM3nGVWSB6GBszen63PsLCRbQ/j6vE8QLS8gxqGgBg639lqjvpumWlLD/V3i9ikU1By6jGGjCFbj63uUyU8OwDFSw0xANCVTLTyn5Mg3AZsCJR4Zi0B0Cyb3q6sKAN/wj0OiXnANEzVPvsIIvL45B6+zrHBrt696B9wKNvLyOWY+DuovU3gzkjaUeP11JIqdzMYNqqkE4pF0MMUcpMfd04o5Rfj5cxl+mt8LXld/byjKO7T3q4RdaBoEWkrqX9J4LaEdF6nAO4Zo8CcJr4Aq00YtxemRcr3fc7Yn7psrSPF+7n6GeiNFvBRNeDYlUenr06Qppl7WCYa0GvO712/UMYEODq6hR6Fg3jIcm5FZFSgDw4SJSPgYWYUguPsB8S627HIOWaUZo6hxD+9L0tBKZCG8/oEIth24fj8iyyRwWOoDr6/Y1tWXogO2WfyTvlCVgqZQ/CmYNWTLm1x/WJD75crw1fDej9kRQzquDg/N7oG08KreMDZOBBixjPLwNyhTW1Frp43MgkRC0a5glK5M9VyVZtDWqrk7JyNki14bXCcT5uuajZFExlom7RTrk/4cQMWf 0Drgih0H 0wyHN2BGADXeq1/IlAvje8ghOYxKaAi6iN41xYv2rsoG2B3xL4YoRYfIFa+XiCnPUO0jpCdot07VcskxgWZLW41Vg/wjRWZcYsGF3qeuNrLTGBcQINxgUR6Vco/d717FDw5KaXl93tEyFftQypfOSZDE+IzXifR/+pmxkGIpT5ms+1Za1vOrTkLAK3gXR8eGmb5axmgJ4tdoBBdUSsclfdryxkYo+vnFaFKhVGklSa/6zPglZeHhP70FMa2F7pkln8OfpiUPtR94+cMYAse3Cy1EAVIaxEG7vuGx73vejsB17bccCTKLoN1G5fMSZcOvgLtWJf+VmixgagGX6M2aa6xw0ZPV0lAR2/cojPKW+Kp0nc3B10v7BzuBN9Ki9XxSkDDHquEC3tDe2iMtRXTi6naySeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 28, 2023 at 05:39:35PM +0100, David Hildenbrand wrote: > Quoting from the cover letter: > > "We have hugetlb special-casing/checks in the callers in all cases either > way already in place: it doesn't make too much sense to call generic-looking > functions that end up doing hugetlb specific things from hugetlb > special-cases." I'll take this one as an example: I think one goal (of my understanding of the mm community) is to make the generic looking functions keep being generic, dropping any function named as "*hugetlb*" if possible one day within that generic implementation. I said that in my previous reply. Having that "*hugetlb*" code already in the code base may or may not be a good reason to further move it upward the stack. Strong feelings? No, I don't have. I'm not knowledged enough to do so. Thanks, -- Peter Xu