From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE558C4167B for ; Tue, 28 Nov 2023 14:07:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C8B76B02B2; Tue, 28 Nov 2023 09:07:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5513F6B02B5; Tue, 28 Nov 2023 09:07:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F1D56B02E8; Tue, 28 Nov 2023 09:07:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2FDFD6B02B2 for ; Tue, 28 Nov 2023 09:07:47 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0D912A01F3 for ; Tue, 28 Nov 2023 14:07:47 +0000 (UTC) X-FDA: 81507541374.03.AAFD0CA Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf16.hostedemail.com (Postfix) with ESMTP id 059B1180072 for ; Tue, 28 Nov 2023 14:07:18 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701180439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fpsr7k2s47SKz3n2FJNcQ2bpHv73SdZZedGMMyhZGFU=; b=DEjsrz2/ls+mb+q2CcmKZA5ZEC3iUWwEMwRzC8iom1OAauexIYC9MClliKR38M4v4KHKjA l4hpSWcudFcWRKNJBsORz1WpbIOgjIhJzQmeZOnmeXtndnX10A4ZIbNF4+iWC35MlgQ54x Jqiz+lpqNdEwvBbdoR6VYBE9dCPsjZE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701180439; a=rsa-sha256; cv=none; b=FPjqBxjRHey+dKqd+F1U2GeBqbN+kWBcJjF3krIDq2WyJua6Ii1V/n1M1/rMlV95rY+IND EQO6d3S6xt78RiPvRij04661AfZV8/+9DonCtaX3iODO3elZR+/06DufvADhEZpUhKZpjf NYY+PVuCdKPe0UCk/DDBbnnoRmjhckw= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DFD381F74C; Tue, 28 Nov 2023 14:07:15 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AE2421343E; Tue, 28 Nov 2023 14:07:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id YJlRJhP0ZWXeNgAAD6G6ig (envelope-from ); Tue, 28 Nov 2023 14:07:15 +0000 Date: Tue, 28 Nov 2023 15:07:10 +0100 From: Michal Hocko To: Gregory Price Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, arnd@arndb.de, tglx@linutronix.de, luto@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, tj@kernel.org, ying.huang@intel.com, Gregory Price Subject: Re: [RFC PATCH 02/11] mm/mempolicy: swap cond reference counting logic in do_get_mempolicy Message-ID: References: <20231122211200.31620-1-gregory.price@memverge.com> <20231122211200.31620-3-gregory.price@memverge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231122211200.31620-3-gregory.price@memverge.com> X-Spamd-Bar: +++++++++++++++ X-Spam: Yes X-Rspamd-Queue-Id: 059B1180072 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: n1r5kg8pb6qm8f1gtq3gk64xens89bfc X-HE-Tag: 1701180438-577019 X-HE-Meta: U2FsdGVkX1+2wH2kBuvhQnMt2oN4pTOxTqdO5L/uYPG8IbFYt3qMiQe/dlaTHkYMB4dMmw7DmOklj+ifWY6rhmiHQ42e/5IEGljbLynQ5pZz9NTT4f2gvfdgH8IIgTlVzYNm4rj65aqEKr8ano/N1Lzv2mjmG2KcmSkDuJkKfVKet8BEK3ta1K2q/JCSIMnB7lY+D09XFjS4OxvnSYyWfY4vfTuGZwV4uFuFajZDD5ldNX4B0ivl2DlFWpINGl12Anss+qju2Riv4EWZu4j01aF7b06XLxWxs7xfKeC3SBhGUYwtbyAB65mp4qqqphgi0VmchIZoOEIsQB2sl5/zBIudEjREjyBUwePsm0uwNIZiMTDKawplYyqV5Im0Z87i9NJ8V1gtenvWSkc5E7gvHsXeV6nVBLBoiWQSdtRRa2TfD26YBt18zTYol6ksw10A2biglgiR3KWUBO+CjZpqJHyh3kBtD38ort1sUfUJfNYP+k8JC+Lw2WV0ETzx20DbenfAIbyrUZGaVgfcbBDfeD9V8jdWoTZrDBkxRbhzjZ3Q/cSWPZJwGxDtPpH2N6HEzGkzruzOKnzXIKojKy0//s4LN7ysA0ld0iWAXgMVb0bE/m8aYe5CvXuuCLdvp4G7axEGO8YmBDVM1qn+2GMxpIAE+pONL99QRstqQYeEJRnq2wWM/QEecIQP1PV//bAUz4x/Mh1dc8C8enUjYck9ItVh30Eb02pFm7+zi/wEC0Jhh7kTz1h3BE6XT+e4foxJmW4EdaoGVAK/1CkdEpRgt1bJu+Zaz7W+gLhzr8lFjgg2eak/Ah33x+6Tay1MwJZXT8Pusq+8fjDYAKY5pcVrcaybi42agizVr9sYZdnQ8hU5M9UMTav5SBY3Bz9SsmyfOc4HQVU39pPC721nMiJuuqWbplWrWWTbLDfqExDgLU9PANsXQAZeMYq3K99zgLRWP1Y8m8ABa0+F1hRx+lH lYM8KFgZ ZlWf2OAsX56t0dHLVv6P+X9HKRZvAyS27m2aYJNr0Ko1dOYk6xx+xDrMDtV2w1pigSciY1y1ZB+zZ7kQt40NzfwPIQXkgAFIKv+rgCPo02CoIfl7RWp5uwL5Cp8Jo0eZE8FIjV/sxVZB6XZLCCoy1+RB9Y+8HYvR0GcNuBbbY3T2NW8SnDru8MA+XG/w7QaF/otklmpvW+HXNr7IWQHasRW71tXDP56/bohul+NX9bCyH2JA2t0Nk037luP/oqIwOBUugLaqc9dOhb+sErgOOxovVQ8u0V4UWclOwu+sJrs4cOxfhjGjSFBQIyNLeNSoCpESu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 22-11-23 16:11:51, Gregory Price wrote: [...] > @@ -982,11 +991,11 @@ static long do_get_mempolicy(int *policy, nodemask_t *nmask, > } > > out: > - mpol_cond_put(pol); > + mpol_put(pol); > if (vma) > mmap_read_unlock(mm); > if (pol_refcount) > - mpol_put(pol_refcount); > + mpol_cond_put(pol_refcount); Maybe I am just misreading the patch but pol_refcount should be always NULL with this patch > return err; > } > > -- > 2.39.1 > -- Michal Hocko SUSE Labs