From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D429C07E98 for ; Tue, 28 Nov 2023 10:16:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E15516B029F; Tue, 28 Nov 2023 05:16:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC4F66B02A1; Tue, 28 Nov 2023 05:16:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8D726B02B5; Tue, 28 Nov 2023 05:16:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B65C36B029F for ; Tue, 28 Nov 2023 05:16:09 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9266E1A0160 for ; Tue, 28 Nov 2023 10:16:09 +0000 (UTC) X-FDA: 81506957658.20.BDAA19E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf06.hostedemail.com (Postfix) with ESMTP id 71F06180013 for ; Tue, 28 Nov 2023 10:16:07 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701166567; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RTjyCNr26YnjaHfUfkRhWXzBbn6MttgwFhsaz1uKH28=; b=VL+Tp0eKflFyigcWNVQxYuGcsCfCXi1Ae5vacy7pa2MyOPf3jIpbtv2FhYemAv3AfLhYEy qMsTj6QPYbAaZQjYZLyFqXa/nVoSpfAe744T6RY4mJRRBPt5zmPcIaBIlZsTkJeD8ceLV2 bqBW9G6Il2FdnBb6KKMQAb/DiG2kDhE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701166567; a=rsa-sha256; cv=none; b=MxltP/NJW/R0HRC5A2LKtNy2UB8GfLnVk51rnCQV9q1f7qPZ7cGku9CVTqBe+gBmqV4zI/ 00aJQhYntraSzs48Ixot3+rPmhAJ4ijCVnLBlMmst3wDCIBI4y/fxxwW2h7qeH3VAQtIHG uWzOedJE7w4SGqn3xdP+NPcrznF54kE= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 950931F74C; Tue, 28 Nov 2023 10:16:05 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 69BB51343E; Tue, 28 Nov 2023 10:16:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id n6+UFeW9ZWW0bQAAD6G6ig (envelope-from ); Tue, 28 Nov 2023 10:16:05 +0000 Date: Tue, 28 Nov 2023 11:16:04 +0100 From: Michal Hocko To: "Huang, Ying" Cc: Yosry Ahmed , Liu Shixin , Yu Zhao , Andrew Morton , Sachin Sant , Johannes Weiner , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10] mm: vmscan: try to reclaim swapcache pages if no swap space Message-ID: References: <87msv58068.fsf@yhuang6-desk2.ccr.corp.intel.com> <87h6l77wl5.fsf@yhuang6-desk2.ccr.corp.intel.com> <87r0ka64v9.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r0ka64v9.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Rspamd-Queue-Id: 71F06180013 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: xdb6bmygcd9aatuuu5ynhxyo9caf81p7 X-HE-Tag: 1701166567-157654 X-HE-Meta: U2FsdGVkX187x7dYfXmNPdDa2DALdIAlkbIY7Vhvh4D5C+Ca5nUP9WUzw3mcFRAoa/WgESTclrAXnwaP8SdP9EC9gHrBglr5BMU9ZTuocYJJ1G63DahdfYAGjhXP8qNAQhatBFW0QwULyzaM2uiqc6G8Y8EqAbjvwxignzYszsRFaGNK8qDW/ANM+5XnSu/VkUjRUL6yslCrjAX9oL1+WIhUKCbhUn3/p+2kAoFZ8CN6ZKctwYVsFi4Gooc0H/cb/SoYwHaUccXztZILudyWaBdN0JORZeUPZDhjsH+0tS4kg6nQ4sSeH2kjxW4hS4goWutWJwF44q/J0b5nGcJvI/ZJ2s8YIpWBF/YE91HfrbMVzcf/eNCbmkxbO5pm7+3WL2l27fzq6tMw+bZL8WSllGeYESem20uQb6L2v6GayM7uveA6gjfrB81Op/lVcnEuiONPgMz+tmUP8r9BrQwtVNeWbg1RX70ICFUCDUsOPsNd44swoSXZ0Rj5R/kI03bNvmF3JnP0elOCjindNZ4sXX7fiSWg9tvydQ3ontnPvmurL6DQ5v8q1QqL3iCyb6pD15b8QFGvnq/pDpAjMWS1wqANVqb710rLTsOaiEhLk8hSMH1GnQfwmneoAclz8uPtRpYvlVNRCXrym8y+mixkG/aK0ox/kAD73IkceuwFjj9i0oD4lZlPfUza63N7tWTPrDbV10iJwsQth1majaEymmh+sqTwRO9u0Lww4oXodRf7RFu0DoOIc3Os2I5ZW6IlgdaopKCaJUM0ZjZl9LkHXlt0C0zTq6WF+cxt9ICarydo2SiNxfpw+JsuQ3zmjE460A0x1Ac2Ob3iGDQBcgVPDwA2tmzQf7HLHffSkvoIJZqMuVYxc0gNcUxY4+bDrWmA4ldAn4deo/YRxF0ugovjgCegVy6U5ohnsRWgbhbOsLEMlqx7nJrYPM6p4tuuwUj4Bi8mTpzvAE1yrqW6I2P 8Rp9x6oW FFrSuK+QaW6/YSbUycpLeIv51JzKNNTz5pkfjt1tBip4AWKTuV/5REqiuCYCGJCuRfkm2xTIZsSGoHBN6jQepyUUTzXwElEA0cl+PkcrlWWr/iU/3gu0DQ4iCOFAY+hWL3N3EQhVgdJLE3w9XyQ31y1xi5HTITiQP0SIpxEsHPvcQQ1KilNYbIiOpCYSOWk1BYrxzuc3ZA/4gFVk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 28-11-23 09:31:06, Huang, Ying wrote: > Michal Hocko writes: [...] > > Right. On the other hand we could be more aggressive when dropping the > > swapcache. Is there any actual reason why we cannot try to folio_free_swap > > even when mem_cgroup_swap_full == F? > > If there are plenty free space in swap device, why not take advantage of > it? Maybe a stupid question but what is the advantage of keeping around in the swap cache? -- Michal Hocko SUSE Labs