From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18EF5C4167B for ; Tue, 28 Nov 2023 09:59:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9274C6B02AD; Tue, 28 Nov 2023 04:59:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B2206B02AE; Tue, 28 Nov 2023 04:59:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 750906B02AF; Tue, 28 Nov 2023 04:59:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 638146B02AD for ; Tue, 28 Nov 2023 04:59:50 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3E5C01A0166 for ; Tue, 28 Nov 2023 09:59:50 +0000 (UTC) X-FDA: 81506916540.17.A719771 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id 2679340013 for ; Tue, 28 Nov 2023 09:59:47 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701165588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d4mv3q+Ul3hTUgO7pU2eP+aXvbGY8pfWGacb4a4AKAY=; b=vBPZKzslGoyf/TLEhLHaz7wJScMjRhj30tqoJM7si+4ioePpFxGQXZy0Vd58C01cmcwxOa u3vr/eL5cndGLUq84iaFcnL43MxVJ37mjmNDCsQfnMVsipxAHeMG7AdY/Gv9QjcLmELuD7 eRci63JAiuphZWIGhiO1BYNwsrQkZ4Q= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701165588; a=rsa-sha256; cv=none; b=eYsm80mMxaUWVnsTWpz1c7esQNYNn0o41iVybKe1GHlRpsJanXuf+OkU4yr152U4K3agxg +oRLENY7BuKzxbUz9baudTLoXW35FnSFbZod9FKd0v0LoT2+Pmlj/C8qCInY8rNFl35F8/ gl7dnJQDN/PWUBi2i0Kd58F14ndhbA0= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8CF5E2198B; Tue, 28 Nov 2023 09:59:46 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 738901343E; Tue, 28 Nov 2023 09:59:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 5OouGRK6ZWWZaAAAD6G6ig (envelope-from ); Tue, 28 Nov 2023 09:59:46 +0000 Date: Tue, 28 Nov 2023 10:59:45 +0100 From: Michal Hocko To: Kent Overstreet Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/7] shrinker debugging improvements Message-ID: References: <20231122232515.177833-1-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231122232515.177833-1-kent.overstreet@linux.dev> X-Spamd-Bar: +++++++++++++++ X-Spam: Yes X-Rspamd-Queue-Id: 2679340013 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: e7dyrdfb81oqwdr4rwnrh8eewpz997pc X-HE-Tag: 1701165587-416116 X-HE-Meta: U2FsdGVkX19E/pp1TUcaYr0xlpPq7xZzRn9qgsLJ0TKILWCX26J82LHfvSZP5ZwJctOhfntt3rGRqzJQAFw6guOtE3iQ0bwmLEM7bHexHdYbQv3dArRF6xDuq0DN/z3PPrZv2xvXCVGGq4t5WvigrtHXaf9B2P0luc3xML2A6x08dRezmiW58WY3oDoADFUP2TCIhVmryvgXlab7cJmX8qvrPjR+rclVcw08yeg0JuJX7jDZZh6x1jKoD3I0rsCdij7qf/yW8IqRoHivIxSs/S/hNw5Ay0SLXOMrUfdv6BgpJDWgI7KX7tv19/kJp8rTn9RlfpBIqurcxN0A3PpT6An9sFbrdGzT2+OO/iQFlynP9lR8amCRwgVbM//M6paY/Ri6bi7d93/sVo21Ovf4z7kubBOcXMIxFhFISB9KWNmxMbewB8M8UXKZ0gqdrm2Om53jTsjSuvOpB796Bboq+zMF/n19bgIa/CyAKLqYnGx1Lbbwjn5L89nh1er9mhpdkWmr8qzvHGpWa2izUUrHltWOUm3/gV2m4AbDtVPOJHo7GMPWjfrxnyMYncuP56pn6HKoqk/9ncuItIUF/GLiY5jIcSmoJOlZquFZMbZ8HYnFj/lu1DfNwkApJzRNuAsL/PRfm65AXly1G9Efr62QipPJXyztOQJapNIxgk+13pBf3K1JESj0XUt+Dhyo6XOofsVsHLdbjZS0z0CMFNQlNqTAyaEGRf2hbx6D1Zc4AOBwz/SWwSEVkObZA1Ifpy/Mr65zj8eVbLweyojy1BDiLToZYssH2+a/Wrl987J++urIc8lD4BQizM1maF0uZJwNZYaIlZlX//ulOe93hJdjXtooCpgY4P6YbVo11c4vaQGYa1EHfB7IfeP1JI3d8+M0FeCIbqIODjMxyW/xJdVCRXCIrQ0ikOTvKxUsOq1fGkKW6WEva5GW9cmAbDYkh2g5N5oR24hkYPuuNRhNxNP D++ZRUNx UJAT+cDbtWwwKTYMcrItC1CJKohhYIyQn5WVwXhthQptjvXI8GxJSRrOxn9s+orsRrsB0+9T8pOmojTwv4WWhvjQBlDdeBUNDXWJC9ZKwlWI9g0vmmzu8G6HSaITVZaybqhUPdNwij72OTQzoR+EUQ9Vmf1MchZ5lPECXZ1f8xwDabQA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000963, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 22-11-23 18:25:05, Kent Overstreet wrote: > This patchset does a few things to aid in OOM debugging, in particular > when shrinkers are involved: > > - improves the show_mem OOM report: it now reports on shrinkers, and > for both shrinkers and slab we only report the top 10 entries, > sorted, not the full list > > - add shrinker_to_text(), for the show_mem report and debugfs, and a > an optional shrinker.to_text() callback to report extra > driver-specific information > > - add extra counters for the shrinker_to_text() report > > - implement shrinker.to_text() for bcachefs, giving an example of how > to use the callbacks Could you expand some more about all these? What is the additional information you can get and how usable that is? Some examples would be really useful in the cover letter to establish grounds for the discussion. /me is looking at patches to find out more. -- Michal Hocko SUSE Labs