From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B1B2C07D5A for ; Mon, 27 Nov 2023 21:32:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4DEB6B0271; Mon, 27 Nov 2023 16:32:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD6556B0274; Mon, 27 Nov 2023 16:32:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C297A6B0287; Mon, 27 Nov 2023 16:32:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AC2656B0271 for ; Mon, 27 Nov 2023 16:32:04 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8AA5E1A0616 for ; Mon, 27 Nov 2023 21:32:04 +0000 (UTC) X-FDA: 81505032168.29.C0C56BE Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf10.hostedemail.com (Postfix) with ESMTP id 98630C0025 for ; Mon, 27 Nov 2023 21:32:02 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ldMT353g; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf10.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701120722; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=01/TtnGunSRoNeQivqkO3yp5gEABKRtIPv7V4mD6Leg=; b=hrjm5u1k5g5ilRjhP+QNbkTm5FjUkgW3EdZb9N+/2VD/mXkYdz7F4O7Ymvk7GHfZjhQ+Xx usy6Ncc5YIROF8b4GvpkHerR9uhD+1RqjCKR5JuG/v0gZzgH3nkQecxk2YxoVp6V/AzI0z 7LCyhq9MfSvPBvzQfHbCTDgf3xJD/4o= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ldMT353g; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf10.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701120722; a=rsa-sha256; cv=none; b=A/xEyh14lS5apCLc/YCsXjR0sKddBwZEyf6C8K7IHAfTIRaAKkLpLf4poW4pitGmNGgZ4t P7YQVHG4OVqC+V4t+Ok+F2pqguiTg2ErmxPvc6mGpLqdKRCVJ2SwHuB6uikY+NvdyG9osN E6oxQyg3ZeYqTNHRdqtd0P5R1uc9iYU= Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6cbe68095a3so3507313b3a.3 for ; Mon, 27 Nov 2023 13:32:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701120721; x=1701725521; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=01/TtnGunSRoNeQivqkO3yp5gEABKRtIPv7V4mD6Leg=; b=ldMT353gs+uk7nQgrALxYmd8bJXvctEOKed1RxEQ5gMUfJrfB2rJb4KuCWQW3kgpLP M3w4YxuyJLZZ7u71b+Brhm3D6O1q1Dkuv6U47F6M7Nk7xDOYdBH4fd0HwHflK3aBHgMx ONtmzF+Zt8x8O1HXTE6K/fP8ljjKOFjMuw3dU40R7O4HXP24V7MxaIKcWjanVDZSAbCu 1JH4WqfPGpA/ly7MiMD+CSg2S+b3uqIOfbZUe+h4EBTmLxFbFlFJFrQi6dnhWvVI7jho y7fIy2vBM36/WMpZnOsNMsRI0Wm8RTDq4e1XX/OM4wjiLYXJZN9bVZ6qbM26+Fvh4ber Og1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701120721; x=1701725521; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=01/TtnGunSRoNeQivqkO3yp5gEABKRtIPv7V4mD6Leg=; b=HwjPz9VJY7aFJ+GXzRu00eq027m4FSzDv5Ff8rcmZ7xV5sb6RADt4NPp7FBLx4/Cjh UV8TvdtoYsdESua2pqUJhHKc//2x4rHnMHBZJj29+FgRHrXB+Tj16Kd9sPzVDlblFV0q iSNcX0AFnHOfDCYIJ/hAgbvwNyYyD5lcbOgA/uhlcdkoa7RY0z53Huiap7Q1bI/gr253 +JzcNXfJLAjvS0KrsnDUM/2104wCC7+7bSx0+n3/40zwyjP5qdcddftwvJOn69uc8qJt Bk8lLI9bJ7LMqldwr/D/5eLbm4Za2z50w6WrvRb1A41pXQ1TAkP6OQ4HAtiBNwQmgIC/ GQIw== X-Gm-Message-State: AOJu0YyP5B+7B1LGWUHdy1NwX7OYeENQnbED/76WihAg+2gOVHhxt1r/ HfNKRCE+wYi29ARNB0+t/Og= X-Google-Smtp-Source: AGHT+IEFYl+6KKsimxSvgft+inPv0eWS+fc/a1z5KjjOVU6stzEhEqtiE6ubO4hduUvwWHuMnV+TTg== X-Received: by 2002:a05:6a20:4419:b0:187:4ee0:e95e with SMTP id ce25-20020a056a20441900b001874ee0e95emr15332849pzb.52.1701120721242; Mon, 27 Nov 2023 13:32:01 -0800 (PST) Received: from google.com ([2620:0:1000:8411:393c:1828:9438:b99d]) by smtp.gmail.com with ESMTPSA id 37-20020a631365000000b005b8ea15c338sm8104364pgt.62.2023.11.27.13.31.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 13:32:00 -0800 (PST) Date: Mon, 27 Nov 2023 13:31:58 -0800 From: Minchan Kim To: Chris Li Cc: "Huang, Ying" , Michal Hocko , Yosry Ahmed , Liu Shixin , Yu Zhao , Andrew Morton , Sachin Sant , Johannes Weiner , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10] mm: vmscan: try to reclaim swapcache pages if no swap space Message-ID: References: <87msv58068.fsf@yhuang6-desk2.ccr.corp.intel.com> <87h6l77wl5.fsf@yhuang6-desk2.ccr.corp.intel.com> <87bkbf7gz6.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Stat-Signature: yx37b5991qh66wco9d5od5iin7q3h1m6 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 98630C0025 X-HE-Tag: 1701120722-693072 X-HE-Meta: U2FsdGVkX1/eVhDs88JFPnr4GfDrnGMxsDOvSbVqJW8UixIWngxqHkUqAVRLOzGWUi44jAnv+IzQMkJfLEtJ97gC2ughFNxLjXdhNzX1dppXtw+66LGszsm+JlCQEVknTeWRAVBb9YelPiWnmUGmIAfVTrAzkYtCBDZnMa8T24mEYrYZeBV9LavPuB5K4fNNzD9HbNRaAxeeMFWyVaHjJF9I0s+P2NJ0i9nSIQzro60Rt81Fh2pFfx8XglMcK1HA//Dba9astBpyhFw0T2+30o389TyRwOGLnXEEW+tZ+a579n4sVekolsgw2AgV1sXhGwf7Ot5SEpYGqeUHWiYe3vG4GphiUdxSCYXx9n6/rNIZo+fowpKvUwnmOXIyJ/Oo12oDt9lBGmYLFl6zocoht/N2v2BhT2AFV5/FgwRWZrNPdNeHGjaKbicn2Fb5ktv+3FLb3YPsr+V5GkipqzfRdNxneODOsmN28vnS44CddREsZwDMhi8Gosese183anTB1tc3TgWnTCeDZRIKau/aSotzRxY1Dlubr1fyfDT9JrJR/adbNXQqetlJJt5MtSCAaTNnaP0t444qEzDUj057ozh7QMtgMNVWqFCTyiGWl97dJ5hQH2Z7QA02q1OU1rBzsZGFCCnqUoo4bHOKq8guyDqR1e1/YzojY3VSzbgRgn9bHSuHXlc4mm9krOl4FqM9LmB8S5JQ+eIbkZIs9nWDde9gfT/e/u1fc5FtcHA7PRycqn8TSWcU5nmeBJuVOk5PkMkGTL2+7cC5aqeCczIt7aBqObA8421+1xKvREnyqPE6Ya30f7U0mMjKpSOgfnHSczMP6EwwpRX/+BB8RzA2HTathWHfRDiVlFsj0sLVKBfVtjA6WY2pqH1D+u6yPOFTVR1SS7dpQ2O+ad3+YzBWd7PvJKJxceWHGQ1brIZDBhMsZ1gqj5CsCOnZE69a7tkHlf75uz7Qb6XiP1oMPny IR38ZeUz Gsb46VV4ZUGpcNpBDlOOs6W/x6imLvuQFqzpMiPwMtaWylRCbsedoqyRp4NpxMrC4eIj15JBTmrJCue9/i2o2TSf8QETj06Wm/Q2t0JDwAZ9O9v/vlIXJqVYocxNJnbJvadgiY8ai3hruSmia49LIdGv1c6jOGACMT3oR3eEweXM6Ha3ARpBBLtc/eNVaJZv8t9bnaSgPs1F0rtaiQ9Z4PwHUMrxAB6X4C4MTEdp4hkkp4RKISt72rKljt+DEl6RszkFRGTblk7i//yhn9L2e/++Rf6SX5CZUjbmpFtCDzEVvKD0DndJhLWyCAw55nfhc3I0QtHHh+5ufj1IBKaU7Q1WeZk7cY3aXIKQz89hFi4sxmlnGTdtE57DMw/cH+lN84FA66PfYsdiMbyZSKRO9unGV8Xfdz5MskTjyCdhio1nEO+RBR532iN6XeoSRohds5Ep+TV99m+Qm42RMXKBfHC2CHR5NsGc8bMWKU7GrufV9cKqn4Gn+soCnGMbBYlNKl6FdNHizNl8QBTGgi4hBYfSgypvzjY/1hb6wCU6S1EieqTga0yzf+WEh+pj6++8sD0d11ajh0Dfia+9sag+pW+HueZ4YuM8brWj2ckYNp6K3dGfbSXzqJkbWPP0g1MKtAySgy56PPS99PvaWD35J+Tj6c36LdRTUVWJgmj9RGw+RGGwol/mBIlL0C8XRR5QZ4uhJeu/vHXnR8lj6k0iQNhLhJSel7WbH5gCftOYMCKVqBEw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 27, 2023 at 12:22:59AM -0800, Chris Li wrote: > On Mon, Nov 27, 2023 at 12:14 AM Huang, Ying wrote: > > > I agree with Ying that anonymous pages typically have different page > > > access patterns than file pages, so we might want to treat them > > > differently to reclaim them effectively. > > > One random idea: > > > How about we put the anonymous page in a swap cache in a different LRU > > > than the rest of the anonymous pages. Then shrinking against those > > > pages in the swap cache would be more effective.Instead of having > > > [anon, file] LRU, now we have [anon not in swap cache, anon in swap > > > cache, file] LRU > > > > I don't think that it is necessary. The patch is only for a special use > > case. Where the swap device is used up while some pages are in swap > > cache. The patch will kill performance, but it is used to avoid OOM > > only, not to improve performance. Per my understanding, we will not use > > up swap device space in most cases. This may be true for ZRAM, but will > > we keep pages in swap cache for long when we use ZRAM? > > I ask the question regarding how many pages can be freed by this patch > in this email thread as well, but haven't got the answer from the > author yet. That is one important aspect to evaluate how valuable is > that patch. Exactly. Since swap cache has different life time with page cache, they would be usually dropped when pages are unmapped(unless they are shared with others but anon is usually exclusive private) so I wonder how much memory we can save. > Regarding running out of swap space. That is a good point, in server > workload we don't typically run out of swap device space anyway. > > Android uses ZRAM, the story might be different. Adding Minchan here. Swap is usually almost full in Android since it compacts(i.e., swapout) background apps aggressively.