From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24C2BC4167B for ; Mon, 27 Nov 2023 09:25:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F6346B0324; Mon, 27 Nov 2023 04:25:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A63F6B0326; Mon, 27 Nov 2023 04:25:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7966E6B0328; Mon, 27 Nov 2023 04:25:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6BDD46B0324 for ; Mon, 27 Nov 2023 04:25:20 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 43446160199 for ; Mon, 27 Nov 2023 09:25:20 +0000 (UTC) X-FDA: 81503200800.22.C4F01B4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf06.hostedemail.com (Postfix) with ESMTP id 291F918001F for ; Mon, 27 Nov 2023 09:25:17 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=WzRoQ47j; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701077118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=61MSObp9Cm4wJIwhaJPM5k6K8AWumSd2PvI/OJBZ1Zw=; b=LqcbBoyBt1T6ZBJZGij15sykf9fkP8S+PrkLufvTeB6V666LHClGitDv25krYe0qvqjikC 7OlNA4Kc+AY70rsohbuIESn/oDLC/ew5EdxXjivmh++paaKn6u0SeTVsaI39JgVkk7d9Ak uqjliyWEdxjR82MBn8zEg5K2Rhy3xic= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=WzRoQ47j; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701077118; a=rsa-sha256; cv=none; b=UTo1+0qM/+rUb5LWYmAScSTFthsk9Usi+PQBzQgEx35mkcNGb0vo/ebMlKP1/x/IPcp71U 0tbPR/VODh0RtXdASGgd+NmvnmJVD7w2CI5kdhUzx4vt+LcQjHzZzPHiFI9lHcmdmu2C1L fyL8xdeXc6zujVnyuad9ciWV/1rsjUA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 75EB521A3B; Mon, 27 Nov 2023 09:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1701077116; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=61MSObp9Cm4wJIwhaJPM5k6K8AWumSd2PvI/OJBZ1Zw=; b=WzRoQ47ji2nH27LMWlYI8uNllDtvtpliKYrjoYVIItVlTYdNLSsmL9q355E4bOd2wQfZss y0aP9NlHbzulOWxZUzu2dkt6euwiC49Ok0pox/0Vb4MoQWii2CUBbL4atvBaSmybN03Q0e QXTlKz5EwpIE+ijj/T2YNQIlV84Ht3Y= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 696281367B; Mon, 27 Nov 2023 09:25:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id RsU0GXxgZGXpPQAAD6G6ig (envelope-from ); Mon, 27 Nov 2023 09:25:16 +0000 Date: Mon, 27 Nov 2023 10:25:12 +0100 From: Michal Hocko To: Dmitry Rokosov Cc: shakeelb@google.com, rostedt@goodmis.org, mhiramat@kernel.org, hannes@cmpxchg.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, kernel@sberdevices.ru, rockosov@gmail.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 2/2] mm: memcg: introduce new event to trace shrink_memcg Message-ID: References: <20231122100156.6568-1-ddrokosov@salutedevices.com> <20231122100156.6568-3-ddrokosov@salutedevices.com> <20231122105836.xhlgbwmwjdwd3g5v@CAB-WSD-L081021> <20231122185727.vcfg56d7sekdfhnm@CAB-WSD-L081021> <20231123112629.2rwxr7gtmbyirwua@CAB-WSD-L081021> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231123112629.2rwxr7gtmbyirwua@CAB-WSD-L081021> X-Rspamd-Queue-Id: 291F918001F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: a54846fjkmqbznu6jfzeyejka8hh7d9u X-HE-Tag: 1701077117-305111 X-HE-Meta: U2FsdGVkX18cjo+ZHdm3o/Z6LFR2+jwc0EPlibjaZjlxEIur6OnSaXjtQip8/uZDN98gFhZviiwZ9U6DlJILZKIMxxieZMFO7zfwez3MbrO1/hPZ9mK7a2Qd2NJSsVOU8X5/K/xCCMr/VuZc7eja2oWd8gf+pyGu+RLp6ADqRVcuvkpY25dWvq7sd3io9VAx/5n9vODv+ySXDkRqgUdKzhHzS0oHarT8jcc8jFISkIEILiWv9J5S/scGRKtrezqddcK+RfJCM/Pfd5+9fY38XOR3Qv2kJ0BPbj6JUohRZ1pv0ICfgRNAknHBAcqkAhQvo9NDPP8I/34zmwCiA78spvOarYf47Bkh73/Fa5TKYtA317ARSpI/dJnOK62YScvU54f8dZACwxc85O2KiD2eNWSbeRgzEhbkDcH4nIQbC+V16y9lkvumCuOLdEb1CIykgFfAtoM+MgDxsVQYbOUfFH9hY73XRN3lB0PljmRsXltll3/MZN1JCdNHIoCD5IzUxj5A9hMx7d5gbrLrZ4H6GkeaVahnyaBGDT/LFyAFzef0j6jg1rfbjTLlE/lmdt6RzQLcun3bpbcY6Zpc35797OHDeEgndRi6Zr3IBUp4uQ/tsXV4NDK6Bdncw0snDzkWZviXkdBduSmVBE6BZy5dkjk/+4pUm3ugQyjhLtRDoCqTurg9NzRBjmyZcqRBiDeSi8iCxufiiQod7/MVu9E+lPfVfVXtyBI9rSy1ZZQcSLACAyzn0cERK+pDv2togqwgYpZnnS+MRRVzCpKNBdQfDpvUK35ejvnqbJ+DXe0hvm7DuzRcZeb0UWDoK7gYWu32ogTeoI6p/Pu8AOUq2f7urTpPeCvGYfZqyiaZIEe/KBQVKZhpXD+hakjcDoUKRMPmA1CBKWhp0M67B3lAxhyAfYxt3TmycPaC+nnb+46DRXD0Pz7UMwF8HpEvCzNuMLmWBoWq2ditePuoQ2+WKMp 1+9sqJCD jYN461vxiUg0Jccz8LEMGOsk6OimGgifQdKcN96dvGo45XkZ1wI8Wn1G4gDI8OplpiC55p5JP22LYXz6xGAxI7E9s+hsCflX4U5GblscKueq64abPdaU/sv8F2cLtUzfmlbuKZXt1HlklI+87KL4HpzVSkhwdknaqSo77rKZzq975Ap3UimS05SzD/5FdSznn8PnGo01ZwA2XYZCXMA4KrU6dRc32uN2iLurvwwyRVUAkTJulUz/rO1+P3Sahvzyy4pxO0dFsnUkGBAw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.010319, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 23-11-23 14:26:29, Dmitry Rokosov wrote: > Michal, Shakeel, > > Sorry for pinging you here, but I don't quite understand your decision > on this patchset. > > Is it a NAK or not? If it's not, should I consider redesigning > something? For instance, introducing stub functions to > remove ifdefs from shrink_node_memcgs(). > > Thank you for taking the time to look into this! Sorry for a late reply. I have noticed you have posted a new version. Let me have a look and comment there. -- Michal Hocko SUSE Labs