From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80383C61D97 for ; Fri, 24 Nov 2023 16:30:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 040478D0097; Fri, 24 Nov 2023 11:30:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F0B628D0096; Fri, 24 Nov 2023 11:30:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAC3F8D0097; Fri, 24 Nov 2023 11:30:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C6A9B8D0096 for ; Fri, 24 Nov 2023 11:30:54 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9C34AC0CA3 for ; Fri, 24 Nov 2023 16:30:54 +0000 (UTC) X-FDA: 81493386828.09.F0F2729 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf06.hostedemail.com (Postfix) with ESMTP id 4BF2E18003A for ; Fri, 24 Nov 2023 16:30:52 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Rh+hyci6; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700843452; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N2E9xKXVJXiXiZeMZ6ZTNOzlCXC20DQVQxf99ZeOw5A=; b=h2E/rrYB7ib0THqDn3n7EK5aSgQ92/qPnsLlntDOQ/0whllvnfg3QVui/jHC+wv88rWxmZ AQU0uk2rKIXLfkS/E2gF/P/a5wb4DFqqQOqKrsId5yrfHgjsApw9mCWTAGUvuKp+p3Qy0G eYY0O7w3aF8BfkqwlM7RQW/2ymsqJYo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700843452; a=rsa-sha256; cv=none; b=0r62ny33ajYwzpd8w1MOxxY3itKd72UaNfqOD4Vm868BwpBoWI0wTqTKZdfStXX52p3zDq 28kiQO1nRpSHMumi482t4iVTQnJqjVcCxrLPBuLQGLOZB0KhbkSLblyyyEowGIn9eaCXKl V1WU0AIt15TzMWLoGvLyBsY/oJRTdL4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Rh+hyci6; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 789CD21B68; Fri, 24 Nov 2023 16:30:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1700843450; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N2E9xKXVJXiXiZeMZ6ZTNOzlCXC20DQVQxf99ZeOw5A=; b=Rh+hyci6Ju+rXK0CAxSO7ua4ILoHzwgfrq4O9y3ailEltj1Qo+7Hx3PLsCib4s5RInhm1q U03QuXSU3zI8RBDQ2vw+5mdBlGPUmTJiHHr3UZ4SygKnqSmi+Shqos7coUwiPATrPQx1sH rB/luNfpj+uZFAVpecwXh/D8EcLc2Qs= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4C9BB13A98; Fri, 24 Nov 2023 16:30:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qniwD7rPYGVDbwAAD6G6ig (envelope-from ); Fri, 24 Nov 2023 16:30:50 +0000 Date: Fri, 24 Nov 2023 17:30:49 +0100 From: Michal Hocko To: "Huang, Ying" Cc: Yosry Ahmed , Liu Shixin , Yu Zhao , Andrew Morton , Sachin Sant , Johannes Weiner , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10] mm: vmscan: try to reclaim swapcache pages if no swap space Message-ID: References: <20231121090624.1814733-1-liushixin2@huawei.com> <32fe518a-e962-14ae-badc-719390386db9@huawei.com> <87msv58068.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87msv58068.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Rspamd-Queue-Id: 4BF2E18003A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ddyjn9tc4oz7up1aw7cndthygee1f6mo X-HE-Tag: 1700843452-250724 X-HE-Meta: U2FsdGVkX1/dSZN4hLDzTk4hazxeV0djS8G1tIlJzAeOcMJdEfbmB9UOI8PdwUUDsmoP/GMPGKdLw7xGHBKj8JiYDthtUvS/OlrBuuY1noJQ7F5i/2X0WSpKEc/wnE1aB3f4V0EtLSXhLfS2My62CQk1P1IkZGEw+yqu/aoennQWqJxrcx7B3okHfbbxsaMnxQy1aOfsUicPe60dHtxhOzUPLjWwzRf90nDO7rtY62wo7TFWHs4C+UfjWCxe4fKo4PMP0ghrP3EEDI7YSgmqy7d6y+1YVa9qaAz7yhXf6bGRrmVaOhV0gFoPYqbw1kty1BrvQ8idxs6X3TUrHenGjJFrp906tr2laff1x5zneEZGECp2k7kymerHOK0wh0waInXvcP1J9u67OIokxzlQCBC8iFrxVi7RCa0tGwW4rrQrtadAcJOpzMqwu9c0aooXReU6tahLNND89Qo131vlzuYglJv66yV571l3r18C9BT1b2+rRP9Vp30J4vqnUJSonXNPceGtT78NBq/Aund7Ii+3gyXc8kNxTlp3aC1XuGrvpEHQ7sO8anbrp27wOD54jGDI3e/YmAuUqJyT+DPe+NdZJNwSIa2MKGtgGdgd+mNz6yzz667W4NloAnY0zXpvvgfMKje20h+RqG+mJNbb0jRSRyhVVa3jwHhsVJ9FfqneJMYlgheuQrgDNF991KcKiBi3iuVpT0ZuZrt7iYtw1GfhRdH3r5mujW52UIYvx6RITRr/4URdThGThjPTdTuXiElm4ik9qrpe4vk/RGXxueSRWrhedTHWdZ4XkIMXoKGb4pQbDIVL/jurhxyRwS2DKjk7ZBMpJh87gzT4yetcgR77Pud9k8mQDyli7bsXQ6f9bAWDQjTUR0mdB9S/IezYocv1lBeMDLCXTQymA427vLVrRVZfiIKcwk5tWaQmsRWrrfUlRY9aOF4Akl03E4gnWC5EjisUe3cKvnfRN0B ZrupXrUI vqxuPcUzLTmaDoJ6S1xVLDLEl+/7kXWBJ+ngapX2CAo3o+mKYuCPMVRBi/uaemcBNnkR7bUUiAAoBrpZpEKvrDpIz5m/paB4HBZ49RjpOLceF7jl4NQg8g9YGXfJvZ5BA8/QD/8WY8blnF5ZUsbdxhWdsappDz8OrkVgFUqd0XRTDBKy49woGeoswySA3BtGdAXRnlwDJPVrNUE/92oyTWwr39s83MBJ2IoDgwmQSrorpgRCJJek5miRPRv5Ldatip73I463wAOla1eehVKNYZ7q8pBjQaM7k1DrRI+YFU5otCjewsKFA3GOSJHT2KYmpON8PB71+RvF4dZWPIWbuKa7KyHZyxOmbM7JllylB4+hksLA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 23-11-23 14:15:59, Huang, Ying wrote: > Michal Hocko writes: [...] > > Yes swapcache pages are indeed more complicated but most of the time > > they just go away as well, no? > > When we swapin a page, we will put it in swapcache too. And the page > can be in that state for long time if there is more than 50% free space > in the swap device. True, but why is that a problem? If you encounter such a swapped in page on the file LRU then the page should be referened and as such should be activated, no? -- Michal Hocko SUSE Labs