From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA2C7C61DF4 for ; Fri, 24 Nov 2023 15:13:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D95F8D008E; Fri, 24 Nov 2023 10:13:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 062378D0084; Fri, 24 Nov 2023 10:13:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E465F8D008E; Fri, 24 Nov 2023 10:13:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D0A7F8D0084 for ; Fri, 24 Nov 2023 10:13:54 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A478012015A for ; Fri, 24 Nov 2023 15:13:54 +0000 (UTC) X-FDA: 81493192788.15.76B413B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 900D54001C for ; Fri, 24 Nov 2023 15:13:52 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fX93P2C7; dmarc=none; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700838832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cpGcQbK5ALS/h/233m+c8jmOxYiT52WHP0nU+fSEvDI=; b=1XTOaQ/Ji0LTKsHhEY1k1BqdrkVyldb0T8C1roh6LLpjA7Z5zZOEvEuB87bf0o5gazeyPe eygBDKt+G51OeBcHmF7fpVWqda0IfupgU5egMdP7rRWlXFX4GYDNXVPxXCWwnjtWMujztH t8430DzEGgKL/QbEVq7bwUGmNA3lZdo= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fX93P2C7; dmarc=none; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700838832; a=rsa-sha256; cv=none; b=AFZdUdgmQWpyWC3dpzCGULaNVE6GQFb2CcqJGsRTAo+Dj4r58XMWINz6nnhAMyWUY+VkdD 7DmZB7NBqApaSNXDo2USvQjwlYPOpG27xVuxQtlXeqnnSzkTT2tVldVXqUONirjTiPrrIc axR+bH3XzIlu13MlYcLoL4BgE9Jb5eQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cpGcQbK5ALS/h/233m+c8jmOxYiT52WHP0nU+fSEvDI=; b=fX93P2C7tTpexgPCsWNuQcuoF5 V4NbDi/cjiBJ3iFD2y4kQwA8+IY1jUY//C5gTL7Y8jlJWwizOacgMGtmLWvpyP1Jxtmlv8KsF+u2Q 3AFGeeshrZuDXwCFRYI7nDjjzh5ZrGTMMIUvezBHV4zBK0vJKDx0VZIpALBPKeA84BikUEgoitHmR deGOVtSFkgHm/2kSyrhYPGpPu5pc1VH0zHdq1nq6ZFG84alWCsKV9908uETUg2hAyPf5y4SR2mvzr 6bWeourxF/Pzo9Zfk32xV0m0+CJWq9as/ots/slGIkFbbfZPP1/KgynAsP/vY1Aix+BJgIpgbC0sJ +O0DhaJQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r6Xrz-008gyc-Bo; Fri, 24 Nov 2023 15:13:27 +0000 Date: Fri, 24 Nov 2023 15:13:27 +0000 From: Matthew Wilcox To: Ryan Roberts Cc: Andrew Morton , Yin Fengwei , David Hildenbrand , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v7 00/10] Small-sized THP for anonymous memory Message-ID: References: <20231122162950.3854897-1-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 900D54001C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: j6edurgxjc3br96xfy4ker4o1jdrcd8r X-HE-Tag: 1700838832-297229 X-HE-Meta: U2FsdGVkX1/JuvCFKVvVPBK7PFU6gYJ6qqNl30AujJ4R3p3xlim2ImNLjIsoA9r6UherJkExaMmnpsw3QWU/jJmwtAyzR1cw2MIaNmBiKVu5l9ShZWacUue93IFR1Q3vyGj1imARchIHaltusSI+vYgRUGfeTPBdZn0ySPXYHgwenxr9qvkXvx/vkXpo9Qv8ySpFyn+nhYZFcOJJYnLN2mamRnKxI/c94dOcdlTR8NhO1YlL6RpDC0DaE7J0ULKw7KLKcjD3VsJz0MTkIdXDzTWXXfdy3GRCvmJzw4KzmXtIpp6TCXJ2J4sVGDldAIMSN+lN2+ylnmaRXitGMhhjQJwn74LqdkCXaE/HOme6RMQMrfA6Dn05qSJDMQk+1FSuc+vDGuJZyATHw740yxniftXSSAbH47lFQZjDwvu+FK5F2KmjQ/NzGdAAPiQ7d3Xivf/6UzUs3duqZOgt1JPtPJa8CNw/XdIYzp4gxR2DgZ8LWeekupPORCRrfKcWpGEFRna9V5Q6gBvC+gQFC72so6zGgMoHPJSOS3+P6uiCLFZoKliifvWzJerJ8Ppsl2k9l/t57p6aMjsUIznLDZ4GGdn4wwR1leZGFi7qgcMSIQWrKpls4zsvZN4RYpoH7BbKT3qbh0mYi+g3Yq4s2wTSLaTjwkf2htreH+k+pyL5FEAi0hlhiUmojF+ZfD+YHNTbcXELD3QVNallIO5bM7ER6qcZ0arSkLTuwS8d6fDRhzmJXtuKCvqgFAn+crqGg5O9R7FLipo0Y+bisKDu68ngWPM7eygqnhUHBwDWyQglX1/BwHuNUGfpfesfl2wuye7OKVOUsezLlSC9mBliTHLzj/su+uD1DE12oXPsQrLtCZS4xkaBvJmO78onxZYHBsbDczuuds7wJH8LzTLUgSIUs3ELWbzu71RKZBed2zAZaz2dRctVskNJnYBmqfhRRx4QUgsJGtRK2pGLwHNUWQo dtKgmSXv e+6P5NXp5rCCbWzTCwvCoDp2WzI4OQutoy8IfxWh7RKAP9FE9K3tskN78Qx3ff+LUbPheQraJUUzlYbXxdDc+vcHqbxwpNnS7bQ1u8Gewxz2i4vHEm3lD4wzDV9Ir4uY+7clX2Jr+7+IdIcUYlLP4sCHdKlYC/n6kl6EhOUiJulq5frVbvt1i97zkR3jc9i7xdDnugBSkBb/pZu8nXC0KyiB3Qg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 24, 2023 at 09:56:37AM +0000, Ryan Roberts wrote: > On 23/11/2023 15:59, Matthew Wilcox wrote: > > On Wed, Nov 22, 2023 at 04:29:40PM +0000, Ryan Roberts wrote: > >> This is v7 of a series to implement small-sized THP for anonymous memory > >> (previously called "large anonymous folios"). The objective of this is to > > > > I'm still against small-sized THP. We've now got people asking whether > > the THP counters should be updated when dealing with large folios that > > are smaller than PMD sized. It's sowing confusion, and we should go > > back to large anon folios as a name. > > I suspect I'm labouring the point here, but I'd like to drill into exactly what > you are objecting to. Is it: > > A) Using the name "small-sized THP" (which is currently only used in the commit > logs and a couple of times in the documentation). Yes, this is what I'm objecting to. > B) Exposing the controls for this feature as an extension to the existing > /sys/kernel/mm/transparent_hugepage/* sysfs interface (note the interface never > uses the term "small-sized"). I don't object to the controls being here. I still wish we didn't need an interface to control them at all, but I don't have the time to become an expert in anonymous memory and figure out how to make that happen. > If A) then this is easily solved by choosing another descriptive name and > updating those places. Personally I think it would be best to continue to use > "THP" since we are exposing the feature through that interface. Perhaps "large > folio THP". I think that continues the confusion about the existing interfaces we have which count THP (and mean "PMD sized THP"). I'd really prefer the term "THP" to unambiguously mean PMD sized THP. I don't understand why you felt the need to move away from Large Anon Folios as a name.