From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9735BC4167B for ; Tue, 5 Dec 2023 03:54:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08E386B008A; Mon, 4 Dec 2023 22:54:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 03EAA6B0092; Mon, 4 Dec 2023 22:54:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E21F56B0099; Mon, 4 Dec 2023 22:54:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D08876B008A for ; Mon, 4 Dec 2023 22:54:10 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 984E5C0534 for ; Tue, 5 Dec 2023 03:54:10 +0000 (UTC) X-FDA: 81531396660.10.CE845EF Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf15.hostedemail.com (Postfix) with ESMTP id B7F53A000C for ; Tue, 5 Dec 2023 03:54:08 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=C+NC9myA; spf=pass (imf15.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701748448; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mAbPD6wQF1oZm18W+YGadKrbUnABiAjudnkBSiNtMNk=; b=w0cxnpC7oY7QgURhkWfg2SUXfCc0nkGL6ucVPx3BfyzkBEQXTzqpIW54OI9YlRNOyr+ALq g3DWwcP2oR4nNBIoDcDGRzyOjpDz5QbWGjBHrMs8aLaC1W5HQk8Z/iO3xrn6H9SBAQp391 zQc5ljsg0dSBtjV7F0itsdKnEooItX0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=C+NC9myA; spf=pass (imf15.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701748448; a=rsa-sha256; cv=none; b=t/YEaGF6Ya041DBNTOlUTWh1qoVCvd3Vew8L9a0MPbkwQA/Vp/zEgVdLIFcSAPo0KlZpSb MFOk59KbIB9BXDTIPfwjk4ik38L7FW63Z1d3HbdmKT43KNJGZNBQFiG4eB9nyt3c1eSHsY cDKmQwWiLgcGB3UT4MCmsOXpE2xb8dI= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1d08a924fcfso18569545ad.2 for ; Mon, 04 Dec 2023 19:54:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701748447; x=1702353247; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mAbPD6wQF1oZm18W+YGadKrbUnABiAjudnkBSiNtMNk=; b=C+NC9myAcl6f+bHwI1lez41mPq5nOdzPUgc2dqWQDxg81N5hkS+brrJnh31HK4xtBN s33OBv1CjPrFk7dgrcQXq0ptsjQMiH1Y1kFCNeAIFwiDgcvzTc5UrTLOG/tV1Eo0dJ98 o/LOrLFPfwMHjxQ7g5ufyO4Ui656qB+WjOKnt9d1N+RcAUELy06dUwRbNDM6aTqXC5Oh j4QDDB1qLDCEjKfY3338aWoL3kM+0vGaumBhOBKGz2605bGbNpJGCiY3Z55Nt6cPoMRo T+ZSqxKF4XT+tzFENTBwlKwtkuH96dxOS9OUkRBOMgTHkKFBUAgskyVUGL+GDR+MfnPg 13sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701748447; x=1702353247; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mAbPD6wQF1oZm18W+YGadKrbUnABiAjudnkBSiNtMNk=; b=FAx83PI6vYtQzqr0OvqU+1pGfhEEgQZvJ2pTxJgKL5jCuLHGVw96D+iPuOwd7g3ZyD PJSvstfot5gHk3u3SH8+5GgXJQcc3K/OiIlqWDCx3kS914V3flf6IxhptiJsJGMSgS2G beXAT0A0UiOzuw3tpvmmCbcm22uE/rvpvK7L0p4PWQMI7QHcBw56dWevF7s5YfsgJvkY 3eYE3QXqkSGsDNiYkJnqLjCxDBNIgEP2/huA7OaBmcWmqzhcWx328vIg8TMvspRMjrLO F1PB17sDW7u69qsEYfFWSVo3CGcC+Ob//6KRXFum+W8KasjW8z4aY1CVZwQcBureCl+Y Vbig== X-Gm-Message-State: AOJu0Ywmr95F8VT3xqJ1uZDFBRsCwWrw7QVYN3gVa809+Sv3pfiFvvvu Gevcrr0f8QOUHDUZrov0P6U= X-Google-Smtp-Source: AGHT+IFHkFZVcbXxpT9yPIquBFa0+sY7wZfP3KL5IkCETaB32tGMnTODGeGvGDme+trhJ5fdRZNd3A== X-Received: by 2002:a17:902:f54c:b0:1d0:6ffd:e2b0 with SMTP id h12-20020a170902f54c00b001d06ffde2b0mr6599717plf.74.1701748447380; Mon, 04 Dec 2023 19:54:07 -0800 (PST) Received: from localhost.localdomain ([1.245.180.67]) by smtp.gmail.com with ESMTPSA id i8-20020a17090332c800b001b8b2a6c4a4sm9168837plr.172.2023.12.04.19.54.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 19:54:06 -0800 (PST) Date: Tue, 5 Dec 2023 12:53:51 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Roman Gushchin , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 01/21] mm/slab, docs: switch mm-api docs generation from slab.c to slub.c Message-ID: References: <20231120-slab-remove-slab-v2-0-9c9c70177183@suse.cz> <20231120-slab-remove-slab-v2-1-9c9c70177183@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231120-slab-remove-slab-v2-1-9c9c70177183@suse.cz> X-Rspamd-Queue-Id: B7F53A000C X-Rspam-User: X-Stat-Signature: iddu6wu4rue7e46hpqke9jd5z4qb1pc8 X-Rspamd-Server: rspam01 X-HE-Tag: 1701748448-704318 X-HE-Meta: U2FsdGVkX18RWs/c0LQhCPZUGUbgjYYJJvBCNSewzXosBbSdY6OdpmHgYv1P9i4VvTOTVHIq9dKIh4qoRuFn3U9r5VMFtqeniFsak7h0gbPCtjwTKr/6l3YgJjvo88w21XJm84u7k6RhhD/4Q7WwhTSyFCw9XgsYGNvtnt6LQmun/4l44mWuwvpNT3k6yQexSXG6kzE6SzNCNpObWFppoRV4hgEYZguIyXDCPFdbNwteYLsPMH/QYTgHFjVAZHVtoU90XRXWySuw4J4QtlPyzSeYKkvytmP+hJWISHtDTPWGsnA9jVG2HhRJNH60eOJ8b7IAK9pDTkxATaiXguPn1kumkjhWz009QxB5TWn7g0r8H0qlLSh8EeH7C1w+EvV4GJUHHQ6yvXktn5m4jCoH27N2V0PPa/TbcekCntVtyourM/VajjaV64G3Q5x3K7RmvZlPf9gy8FZSWZl+toTtaTnxou8wK7aSwdIRbm3pcLB1rNAPUVSe4FOIpZ+ceFiKHoDg1aZn+3VGnamf46DQCcTijSS8PUNPC6Gbfa6JRjlK2fEpCHIxOEDh146MJB4jAx8VWxVvboUaHfe8Lq2h9jPYuOg4TKbJM5eB682v0+xxNvbBWxOQsmIJhRWRPYg0qu9QQhKDX73PvFRCXzOJv3FJmxbW76WQE7k/5WeTQNO4MHQZmJnYhg1WCle3YeO0LqYGqhf2m05/86jjUfeHc3Kqgxo0NkLX73nLS58Z1DIJJL7rde34ri4XTMVkqsJHywnLeovF9wdWXZ23DNJiTu3dpa1vPimpNqoR0mJdzLfjjt8hBsigLIPuAO3fwsaDu0bcOtth0odWwx3mwpjIWu98IZGeDAnip476k/w8ZZp5uCbmYZE/IbEX9pAfML13fqadkVKFJYuRohrQaDOlwdjwmVHx9LlFD5JrnG/rdqkNe1/0QD+u/i1o3WISu0lwFP/NjalQw69KufFbLFR ApZ0fS51 HePLje8vUyIFWTp5EeLDApzDblJvL0+k6YnK/bmaaM1uQqWECmzvKezuLBE+TTWtHHEAIK5IJmltF+1aVNFBLU5QOR0/SMvqksiBYbjhtaC9OQsEmb0Mj3c2c8vopSfzZFe/ekL/fpB95OzMTflXefQViJQl5Lf29cBBoYg0SuX8m2xNYFKFA0MYuzeRL5mDZJvczFoN7f6aF5bLDtO8BbxnuqiCZSN1xLQteknQGLQg453V2ioWXoze/Iak5JGY7Mdg9Ff0R6RBff4W2a3dzgy02ikYeVj0piZwr4SN+g4WnYnt3Vp8qBw4pFu/83gF8OH/EvVaOg+1BeEZ24+gTGGtXBXr3QdxMS8aoCJqDlsrmMGSEU5fHpBwOKujPwFM82x1+hYvOHHWBXqEX9LmGi2guWXenu646V+2EjQ2VwEYQ3J0ncyFKieabbAp0MO+2uKvgmqiywXGJDf9MaJ+EDG67WJkpEGrv77ZrEZSxynv3gmODsQsXbWpxNYptQObjr30WMhE+Lqmkhy4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 20, 2023 at 07:34:12PM +0100, Vlastimil Babka wrote: > The SLAB implementation is going to be removed, and mm-api.rst currently > uses mm/slab.c to obtain kerneldocs for some API functions. Switch it to > mm/slub.c and move the relevant kerneldocs of exported functions from > one to the other. The rest of kerneldocs in slab.c is for static SLAB > implementation-specific functions that don't have counterparts in slub.c > and thus can be simply removed with the implementation. > > Signed-off-by: Vlastimil Babka > --- > Documentation/core-api/mm-api.rst | 2 +- > mm/slab.c | 21 --------------------- > mm/slub.c | 21 +++++++++++++++++++++ > 3 files changed, 22 insertions(+), 22 deletions(-) > > diff --git a/Documentation/core-api/mm-api.rst b/Documentation/core-api/mm-api.rst > index 2d091c873d1e..af8151db88b2 100644 > --- a/Documentation/core-api/mm-api.rst > +++ b/Documentation/core-api/mm-api.rst > @@ -37,7 +37,7 @@ The Slab Cache > .. kernel-doc:: include/linux/slab.h > :internal: > > -.. kernel-doc:: mm/slab.c > +.. kernel-doc:: mm/slub.c > :export: > > .. kernel-doc:: mm/slab_common.c > diff --git a/mm/slab.c b/mm/slab.c > index 9ad3d0f2d1a5..37efe3241f9c 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -3491,19 +3491,6 @@ int kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, size_t size, > } > EXPORT_SYMBOL(kmem_cache_alloc_bulk); > > -/** > - * kmem_cache_alloc_node - Allocate an object on the specified node > - * @cachep: The cache to allocate from. > - * @flags: See kmalloc(). > - * @nodeid: node number of the target node. > - * > - * Identical to kmem_cache_alloc but it will allocate memory on the given > - * node, which can improve the performance for cpu bound structures. > - * > - * Fallback to other node is possible if __GFP_THISNODE is not set. > - * > - * Return: pointer to the new object or %NULL in case of error > - */ > void *kmem_cache_alloc_node(struct kmem_cache *cachep, gfp_t flags, int nodeid) > { > void *ret = slab_alloc_node(cachep, NULL, flags, nodeid, cachep->object_size, _RET_IP_); > @@ -3564,14 +3551,6 @@ void __kmem_cache_free(struct kmem_cache *cachep, void *objp, > __do_kmem_cache_free(cachep, objp, caller); > } > > -/** > - * kmem_cache_free - Deallocate an object > - * @cachep: The cache the allocation was from. > - * @objp: The previously allocated object. > - * > - * Free an object which was previously allocated from this > - * cache. > - */ > void kmem_cache_free(struct kmem_cache *cachep, void *objp) > { > cachep = cache_from_obj(cachep, objp); > diff --git a/mm/slub.c b/mm/slub.c > index 63d281dfacdb..3e01731783df 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -3518,6 +3518,19 @@ void *__kmem_cache_alloc_node(struct kmem_cache *s, gfp_t gfpflags, > caller, orig_size); > } > > +/** > + * kmem_cache_alloc_node - Allocate an object on the specified node > + * @s: The cache to allocate from. > + * @gfpflags: See kmalloc(). > + * @node: node number of the target node. > + * > + * Identical to kmem_cache_alloc but it will allocate memory on the given > + * node, which can improve the performance for cpu bound structures. > + * > + * Fallback to other node is possible if __GFP_THISNODE is not set. > + * > + * Return: pointer to the new object or %NULL in case of error > + */ > void *kmem_cache_alloc_node(struct kmem_cache *s, gfp_t gfpflags, int node) > { > void *ret = slab_alloc_node(s, NULL, gfpflags, node, _RET_IP_, s->object_size); > @@ -3822,6 +3835,14 @@ void __kmem_cache_free(struct kmem_cache *s, void *x, unsigned long caller) > slab_free(s, virt_to_slab(x), x, NULL, &x, 1, caller); > } > > +/** > + * kmem_cache_free - Deallocate an object > + * @s: The cache the allocation was from. > + * @x: The previously allocated object. > + * > + * Free an object which was previously allocated from this > + * cache. > + */ > void kmem_cache_free(struct kmem_cache *s, void *x) > { > s = cache_from_obj(s, x); > Looks good to me, Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > -- > 2.42.1 > >