From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7B18C4167B for ; Mon, 4 Dec 2023 18:46:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C17B6B02E7; Mon, 4 Dec 2023 13:46:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 498726B02E8; Mon, 4 Dec 2023 13:46:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 387DA6B02E9; Mon, 4 Dec 2023 13:46:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 292BB6B02E7 for ; Mon, 4 Dec 2023 13:46:52 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 08EED12031D for ; Mon, 4 Dec 2023 18:46:52 +0000 (UTC) X-FDA: 81530017464.24.65CD615 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf24.hostedemail.com (Postfix) with ESMTP id EE45918000D for ; Mon, 4 Dec 2023 18:46:49 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf24.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701715610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AcsEvyjgiRamPaUZrpNKKTv9fBhZJOFDvHdp/jkLMsU=; b=sIYzQ02s2iSDSJTb+TJ7ulpTfnhgz3MpQeew3/gmpfFVjaoweer07XK3ekTinTL3armcD5 XsszdFFZnzFLgx4sFfe/UEHMKUVuANfXoe2IxqO0YWzjOL077BMIIGSiPGUfX9JOhYIkI2 FxIpmigmBr85ssoS4ZPqGoSbcMe0V28= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf24.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701715610; a=rsa-sha256; cv=none; b=zINnivfycxsk03XYFY7hT6XkMWng/VzV36PaHkzJJVFbULwtqZleUtfY4nFd2tuoMstx/8 pL2h+srdWcKsAtTrgcUUfO7FYZRsjpQoC0hOetDIt0d2/w9SuDVoY1syyVgpssmZqa9oTA X00RxYKylaIV2+y5JyOBhPnQFfL91f4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 9031ECE0FCE; Mon, 4 Dec 2023 18:46:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3EBAC433C8; Mon, 4 Dec 2023 18:46:42 +0000 (UTC) Date: Mon, 4 Dec 2023 18:46:40 +0000 From: Catalin Marinas To: Joey Gouly Cc: linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com, broonie@kernel.org, dave.hansen@linux.intel.com, maz@kernel.org, oliver.upton@linux.dev, shuah@kernel.org, will@kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, James Morse , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH v3 03/25] arm64: cpufeature: add Permission Overlay Extension cpucap Message-ID: References: <20231124163510.1835740-1-joey.gouly@arm.com> <20231124163510.1835740-4-joey.gouly@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231124163510.1835740-4-joey.gouly@arm.com> X-Rspam-User: X-Stat-Signature: fdxzbfpsdi1xxx93qidb4hufsz9ocs8z X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EE45918000D X-HE-Tag: 1701715609-530645 X-HE-Meta: U2FsdGVkX18jVeSwIKW37PAtHFJ6xrxD+dK6hRyuWyhigQVgYR+ubWzCq0V9X5NeNiLMFsUuAizBmQiQ9MihXRVi3wqFRxPYVX2xfKEulj+Hn0QLZQvImOed6SeSiLuaQSEfZStBaKqwOaXvCyOkOozcKzQiDOvQJhGFPDq0r53KWQDBSKjDK2D8+LNpvfCOfj+H2Zw5YYQiPnqMcFhrTPhf+7+bI2QvVpc3Dz+U6+T3uYgQo9R+5RJZpRgFGTYR8JVA+cHx+qwtXe8MsjhqCSwk0VzR7HFHoSfnpE1SdyprykmAvv3nxG14op6EmLGbH0ClSgUERPmRZVjXTXluHk2ugs0kXguNg2BstPrJQScrj9DEVMwRgPZZyDlvQqDuz2sNaqPA7BRQusYDzp87E6q1AU3HLSmaKFH963qmCMTK3DH3KRSkRlX5BnhUAICF3Yq1i6iYV0APJJwrQYDcd0fviKmBOWPLxK8z3X9EgW5hGB79A9RfpkjF1cbeO9QY/6M66kmMNlPhR81fvCRgi9wgdflfENbOLDNBU/73lUIXEnOpOmP4+FAxJvX4QHygIqG/v0YBWQgz28LmtB5LcdGBNF/NnMffiqiTX4MASvKo39OSCZJUE4edy5vvVv+2Y82Bddv0LRLMxZ2E8y63WauKAejMMSLIRTIuVX7UTrWaAwhSG+RA/KgcJg1hl+9r8iOqETt1srIrB2hGBSFsVGXGWzfFKTrBbal0PNVyiLQxnB0gtyoQTzvUowF5Be1Z2PKXl5qgZloRWYlxP33BNmnO2FasnoqRBqGwLek3hCjTIyis3LNnxq9CiGR2W0yrGdIZtQ7/X8KocZzt6dQrhrIsTO68kH6sFBipb+qP8GPnGN/fCjHkYhR63fli3XpLpFEexjz8Qf2DyR4yd+DyW72T4uBpDbleRuWrwCVPz2GdvvxbGlBt285GoxLpCZeQkE/8ClxC4lPTEv1JUoA WNgXdhGs v/XbeSNp7EOE6H5tdjPcL9FyxntH2ykWHusuYc/ps9m4jiQek6PtMwVxMueoevLJcUrOF5V6r9THW18jjkkJQOG1yuvBVQuY+HgDfBIdZ/hDbz0l6PFTdJLf3GIE/u6J0hk8alTxZxJ5J6XwefLpDGMS5I0MQF8i7QbPqOS7Ly8ZIuAQyRwSFOAw99x5eoKM5Zq8hnPN/yg05iWv1bnXhvN1SYLbVIS94V3RQZtJJTtIyFFQNOAE0qqu90asbnOXbdBPvYkqlxxJriHgQHJegMLHxXSbb7eQkNnjSDXeELTPg8S9281MDoOMUIHYsLUjI1Xez X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 24, 2023 at 04:34:48PM +0000, Joey Gouly wrote: > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -2078,6 +2078,22 @@ config ARM64_EPAN > if the cpu does not implement the feature. > endmenu # "ARMv8.7 architectural features" > > +menu "ARMv8.9 architectural features" > +config ARM64_POE > + prompt "Permission Overlay Extension" > + def_bool y > + help > + The Permission Overlay Extension is used to implement Memory > + Protection Keys. Memory Protection Keys provides a mechanism for > + enforcing page-based protections, but without requiring modification > + of the page tables when an application changes protection domains. > + > + For details, see Documentation/core-api/protection-keys.rst > + > + If unsure, say y. > + > +endmenu # "ARMv8.9 architectural features" I agree with Mark, we typically leave the Kconfig option towards the end of the series. > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index 646591c67e7a..00b6d516ed3f 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -2731,6 +2731,15 @@ static const struct arm64_cpu_capabilities arm64_features[] = { > .matches = has_cpuid_feature, > ARM64_CPUID_FIELDS(ID_AA64MMFR2_EL1, EVT, IMP) > }, > +#ifdef CONFIG_ARM64_POE > + { > + .desc = "Stage-1 Permission Overlay Extension (S1POE)", > + .capability = ARM64_HAS_S1POE, > + .type = ARM64_CPUCAP_BOOT_CPU_FEATURE, > + .matches = has_cpuid_feature, > + ARM64_CPUID_FIELDS(ID_AA64MMFR3_EL1, S1POE, IMP) > + }, > +#endif Keeping the #ifdef here is ok, it won't be defined at this point. -- Catalin