From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EC97C4167B for ; Mon, 4 Dec 2023 08:16:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8141B6B0208; Mon, 4 Dec 2023 03:16:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C4EB6B025B; Mon, 4 Dec 2023 03:16:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68C256B026D; Mon, 4 Dec 2023 03:16:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5AACA6B0208 for ; Mon, 4 Dec 2023 03:16:23 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 200D21C013D for ; Mon, 4 Dec 2023 08:16:23 +0000 (UTC) X-FDA: 81528428646.15.689FB25 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf07.hostedemail.com (Postfix) with ESMTP id 1979240003 for ; Mon, 4 Dec 2023 08:16:19 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=epcvYcXu; dmarc=none; spf=none (imf07.hostedemail.com: domain of BATV+fd69f8630f3eec4f0d9f+7407+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+fd69f8630f3eec4f0d9f+7407+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701677781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KdxoiUH+DnoPXPJKloqpuWbzvOzjnmB3ksfW+FHn/iA=; b=kIuef2N5qL0FfxBD4K9wQ6FZvIF61DEvIOw9WRGb7XYwwPNISTejVQL0aLc2oF2KYvDPFt Zo2q3uH5N+wp98XBlgtoOWgzTT/sjBuze2CHzwu5W7e6ePG/tTllPGqIC/l+M8wRZ1Ljy0 D3LBqE0zc7irSLYxcK0fuArxI03MJ98= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=epcvYcXu; dmarc=none; spf=none (imf07.hostedemail.com: domain of BATV+fd69f8630f3eec4f0d9f+7407+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+fd69f8630f3eec4f0d9f+7407+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701677781; a=rsa-sha256; cv=none; b=JHbDFDNk7xetSay+uNFk4ftT7Nk32vxVEH4zbsC3jIKire7RxAvlK6oy+WQaVOPxkEmNp+ e1hYpgRvh4Hu/YnOvQBtJQTel93miL1X8Z69PklrKpEZcwh6jV+Kry8xAxYQjRnmXkoiBy ryVeqlSFFF1p4HMPHcx+lRDEtXvBy/Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=KdxoiUH+DnoPXPJKloqpuWbzvOzjnmB3ksfW+FHn/iA=; b=epcvYcXuWh//at0Z5I0R/iFrki TIOYWMmpZPjc66GxwygzQCTPjmBQW8fmtsccbOerG1luXChaWcZZXS+lK+8BuNnm4S3NQkEujNarj 5pIY8AxghsMTaRJTft93bhPKTEkEYNizjCbM1O3U8dhQJgYSIIsLEkBtKFg/tvAnkkpgnFKaINYbJ RcxrjpJiy1a5IY6bTQbgZuycycCF4jdfr/GQ9oAb1N3h68a9WMvy/q3rqkh9efpbMDrW28scG4yJZ 3Q7tqilxsbo52IxpsbyN4XKiSO1DlfRi9WGjHGaxhpa0QOZhiO3yhATCO1+IQwyG+Uig0PSB5HAr8 WXhZQXkQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rA47h-003F3V-1Q; Mon, 04 Dec 2023 08:16:13 +0000 Date: Mon, 4 Dec 2023 00:16:13 -0800 From: Christoph Hellwig To: "Kasireddy, Vivek" Cc: Christoph Hellwig , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , David Hildenbrand , Daniel Vetter , Mike Kravetz , Hugh Dickins , Peter Xu , Gerd Hoffmann , "Kim, Dongwon" , "Chang, Junxiao" , Jason Gunthorpe Subject: Re: [PATCH v5 3/5] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages (v5) Message-ID: References: <20231123064443.1035709-1-vivek.kasireddy@intel.com> <20231123064443.1035709-4-vivek.kasireddy@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 1979240003 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: aasw487ckx9bdm8nz6wiect5u8rm365u X-HE-Tag: 1701677779-258864 X-HE-Meta: U2FsdGVkX1+gg8PrXe21xDi6B92Pm0Ds49D6DgMC7jB6OwgV6Pg6cfD0QKtwmOalkcQ26nFQIFDGh4UxSYP2+ACZyKfMu4AyfAeIPj9YqyE0klDPBTjNFl6k7TaOoQ1XFAdxMdJ8rLjObzHTUX/OKskbU8DUjxJ2bGe4+YCi1lkccHHvlwAZk57McZtYtSq+bHDg2Dxzek9I5EkhGNEiSsoT/AM9Nz2oyZHN/WfjOmFiIS3S/Yv6QlcKqF3jJ89syR3wLou98u5jlO4F2S8zmGOn5FFWsCwYTUBVQJyeNl7e7D9ho63jONb+Uiq4Rs6gI8GUV7jc3+dCHUyjXNL7Y93n2kNvzLdeQW61poAOjUs8bZZ8EhxekqIPEdewO4Iu+AaUQ+KjMicf0Y4ConNciudaoTkYYU8f2wZhnFb7Zyqq/9Rpv7f6GRTteEt84RVLK3XFdxuXo6TiSczKPm5i/odkOfmo2IcQUNztN4Gy2Zpwy5dqHR1wcC5m7nDy6EuGwJkLzAXKFlHNOt19vN5PlY+NC3E1ZW+fznmRR2oTJOxw02Jwq9aqLehQtE+IPf5V9w1KhzEDYxycQbLElg17oFCldWCk9M9Oa7A7lew+T0zd+hfAo+6O1tMHvwyzfzox3WLsTPVfUeneG2WNRuxeBsq3OTQsNRXaFHS4FqQaXx/Fa6kC9sY1p1Iby07JXPCiMSOPdNPCVBK8cakOxSHemc04XGcXQcXjW+xalu5hPUQaliaSs3qARVH2OBFoiOq0aRibrEzLvABVVgU9/higcL209bQf9KTKb0jacX6yrOa9TcDcWMya/JVKnVYocpCxfAF/iz1GH3wxd0nEeI27CKLxL4l5OX5tWJPIF07EKQtvTOUDsL+UKSzzW/pEIunXrmEAHNo0WNy3sZMEjHqRALQYrB0b21C77RrXxZ6RHecNmF6hXnk25MEtNnsF9YcWsWkN1+bwjEUZgHaX7eP KfC1E2uk Ikk7OZAgYAFipyjg14cB+O8tn6OwYWvR6q60ptSsOQyVhYS7oB9Qy7+A7LtpNgiYq1ZQrLQhz5ou7VdXKv9P58v3h2ucQNwNZkTFvrfPHDijoYHCCROaohAyNExewMjY2lvD71WlL7snYSPXYg+IHS0xDzbPPVKXdndhXllaSDW8iUndpIxhDKQLxPhtOrLfWtS7lAaOAR8EgZz9igJMODrYleRyZdOwvXSDfW9AD+WT3/49mq7x4AhwDjRE6KiOC+SZzb1lNlUbwnJlvrCcARL9xzx1rRSHiJ4d5xdjyRH6GUD4G/1FkRlC31WAOhcfJ6hJDJPFGwegHTz82ghMaFvFfJewEvftbV+D2I7FL4+jeGFqhX+mgdAZVdeeSqz0surzrKGyZ+aEJkiTjzD3S/bYqbtlX+QUTFvQh6iGhCbsUZ8zWsqnPzOqPegY8kk8d3TLIJZhl4tmHkO7l+vuBUCtVWF+LKHozKVvv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 30, 2023 at 06:41:11AM +0000, Kasireddy, Vivek wrote: > I see your concern. The word "file" does make it look like this API works > with all kinds of files although it is meant to specifically work with > files that > belong to shmemfs or hugetlbfs. Since it is intended to work with memfds > in particular, I'll rename this helper alloc_memfd_page(). I think it also > makes sense to do s/file/memfd in this whole patch. Does this sound ok? That sounds much better, yes. And please also rename the new api to memfd_pin_user_pages。 > > > asserts that this is true). gup.c also seems like a very odd place > > for such a helper. > I only created this helper to cleanly separate lookup and creation and to > reduce the level of indentation in pin_user_pages_fd(). Anyway, would > mm/memfd.c be a more appropriate location? I think so, but I'll defer to the MM maintainers. > As mentioned above, this API is mainly intended for memfds and FWICS, > memfds are backed by files from either shmemfs or hugetlbfs. Ok. Witht better naming this should be more obvious.