From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AD75C10F04 for ; Mon, 4 Dec 2023 03:45:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AD056B0276; Sun, 3 Dec 2023 22:45:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 65C8E6B0278; Sun, 3 Dec 2023 22:45:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54AF26B027D; Sun, 3 Dec 2023 22:45:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 46BD56B0276 for ; Sun, 3 Dec 2023 22:45:50 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0EB4A8022C for ; Mon, 4 Dec 2023 03:45:50 +0000 (UTC) X-FDA: 81527746860.08.7F2D7F9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id DFC6D40015 for ; Mon, 4 Dec 2023 03:45:47 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YkWkuzqE; dmarc=none; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701661548; a=rsa-sha256; cv=none; b=zDULdYnWodu1WpYeZdsweZa4mLJniIYJkHRTx4t/8YnG0ykQTgkCZpqrWiOmSLgLE8V64P q98l2usgaryrtTfNfwkfUeL+Y8GsFtBRjuJcWZFzVykvtdC/+IcXVibrrijuXJ9yAm8Osl d9ROEZda+KHLO6OGyqscadi/nvZsiac= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YkWkuzqE; dmarc=none; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701661548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ry7gr/5bN25PSCvv6lcR7bI/Ha0P4Dd9y79zHzmEuI8=; b=8ffUbIU7T7NpuHonXmYqy2bDaTkFsRsZRVxLTtnhSHgUtXiT2Z/5XM/CM/TW8oQ+N8VVou MyxIg+f4XBICsuHDl0N2dR/SwRmJo/vBzG6XxFA+u2UCZfDF+oA+YGCsfY333GemXTg08R Zq0jsD1EoEcu9/No2HTDfaEn9bidK98= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ry7gr/5bN25PSCvv6lcR7bI/Ha0P4Dd9y79zHzmEuI8=; b=YkWkuzqEUa8nmgcANwoKAEd8Hf OVNjtHLthRlcZaagQBRnVp+Ph4vR1RiIqQ/HnPnSfhf9rtBS5aaWOj1BVbk33Aji8MxdudOTHxc6Y T2dCNbbVOvZImdFrT/VkP8Ib4Orpwyy5mFV19e6SNhdc5/QAAe0OA+5Ry3YtJ8tetMbP2J4AToock gQMPA30g+pBS6y1MB2OiLj6Pg4jVrgBmyCUAA5B4MW1FOBGiVuMxpE4PzmyEv01jDMrn0NStvOTZl Pkm7qppzWZ3UEXO11JAi0435a2FKkQ1qOB0e/rkQMfRCLZyJ9WwTm0/iaKI5C3vPp5kSkMQaFn/U8 W47GrUiA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r9ztt-000IS2-5h; Mon, 04 Dec 2023 03:45:41 +0000 Date: Mon, 4 Dec 2023 03:45:41 +0000 From: Matthew Wilcox To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Minchan Kim , Sergey Senozhatsky , Mike Rapoport , Yosry Ahmed , linux-mm@kvack.org Subject: Re: [RFC PATCH v3 04/21] mm/zsmalloc: add alternatives of frequently used helper functions Message-ID: References: <20231130101242.2590384-1-42.hyeyoo@gmail.com> <20231130101242.2590384-5-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231130101242.2590384-5-42.hyeyoo@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DFC6D40015 X-Stat-Signature: qsph1iezrugrc3w977bff8azghtjjnjd X-HE-Tag: 1701661547-940683 X-HE-Meta: U2FsdGVkX1+H2S0/PsIv3VdwuWnTm8h/qIG/YknHDDjPZW+30Im7IXSRQW8GSe5Aj4ZC+0BLj1+lB+qI3xA6GPohfebI6HuIrWveW//4OcdbiFW4L06WXTwbHHkWXjfS1D8Uybmbi1EMf+y6Wdi4qvfLsajZox2oRL3qg0CVPsvZ3kbGcUev/FOImB4ZATh6yfUUJggxGIFeLi9Ru894TCn+wOc1GuqsMncBAuJ5hERaWXnTyLN4M3TbIvN9xj0aZQahykCIS/m/n9SH0eM/idn6fRHy2uwIIWqpPHS2I6DqUaJa9L+bWTzdRXq2bzzenx7FB0Bq2wwHYCDbDTIkPOSZoS3CzEsGZziTAIvpks+u3v3Agymq4ENCz38JoUnMv2vruUkjT0o6Jsnwex9AJgs8PEI3Jz/G8+jgwAFMAQDAivvUbRlfwwpeSMWx9AJ0lsj2dwQeZ1vNowLDSh4tc9af8JOT6lY9gQddQ9TDrz2RLHm1XZIXYL8ueHc0F8Ugg97KYHE4gxACAct8htYQQjuN9rdPOaddE2kYTfVoOstx0WrYfkEUFMaob2gRvSm1nB0phNVOVgU6ZR2fhhuhg/j673jRlKW0yaiXZksptkN2wlbGeYC5YWkKXedSh/1PDm+FEdmXlf4raEjk17d0EgN/ZCLv9Tui4m3t+nieTQCOdKoUbVbixA84JFoEVX5qcGwPOfhKF6VYIQPyJkk/xRCUhLM+Qd/fZHTq8j+XEtH10uNSJapiaPJeQYHU0Rr4vvWAcW7SP2EwGk4vAdVybSOPHtWVEwjsZvx3gsqDRxzRZ8jbvObQGme98zXfn2DOeGr9Nv5btHB15IS4FPl8mdeonn326oshAy4/ozOJYyQNIQWMAvfYqlW0cvesPBpPU6WFZG2V8tnSAWrV99Wlp52Ei5fc0fgJjdl4hG1hMuSiRBMJrdd/rqe7JiUxsZFddzyYY+AUS/IvDojMtl6 NCYICnIE bySSxdgReWonY5Nncfrckd1588N2EM2mUVJXZYDSmlqEzehkenDkt3l3FP4JHzJxB2FP524HlvASYma7j04jmVAfq0ygFDYh+hMchdU+pSXRJ5oxAc4kQWihQ8/5LJ+z4i9s0MN08/nKfs/E5Y2zOJG1HSUjx74IHWAu8B/JS9BCvdtZIw3sC1fdFIQYPDoA53ANPhaCksvuKriY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 30, 2023 at 07:12:25PM +0900, Hyeonggon Yoo wrote: > +static __maybe_unused int is_first_zsdesc(struct zsdesc *zsdesc) > +{ > + return PagePrivate(zsdesc_page(zsdesc)); > +} static inline bool is_first_zsdesc(struct zsdesc *zsdesc) { return folio_test_private(zsdesc_folio(zsdesc)); } > -static inline struct page *get_first_page(struct zspage *zspage) > +static __maybe_unused inline struct page *get_first_page(struct zspage *zspage) I don't think you need __maybe_unused with inline. > +static __maybe_unused struct zsdesc *get_first_zsdesc(struct zspage *zspage) > +{ > + struct zsdesc *first_zsdesc = zspage->first_zsdesc; > + > + VM_BUG_ON_PAGE(!is_first_zsdesc(first_zsdesc), zsdesc_page(first_zsdesc)); Do we want a VM_BUG_ON_ZSDESC?