From: Matthew Wilcox <willy@infradead.org>
To: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Mike Rapoport <rppt@kernel.org>,
Yosry Ahmed <yosryahmed@google.com>,
linux-mm@kvack.org
Subject: Re: [RFC PATCH v3 04/21] mm/zsmalloc: add alternatives of frequently used helper functions
Date: Mon, 4 Dec 2023 03:45:41 +0000 [thread overview]
Message-ID: <ZW1LZb7w+nICku4W@casper.infradead.org> (raw)
In-Reply-To: <20231130101242.2590384-5-42.hyeyoo@gmail.com>
On Thu, Nov 30, 2023 at 07:12:25PM +0900, Hyeonggon Yoo wrote:
> +static __maybe_unused int is_first_zsdesc(struct zsdesc *zsdesc)
> +{
> + return PagePrivate(zsdesc_page(zsdesc));
> +}
static inline bool is_first_zsdesc(struct zsdesc *zsdesc)
{
return folio_test_private(zsdesc_folio(zsdesc));
}
> -static inline struct page *get_first_page(struct zspage *zspage)
> +static __maybe_unused inline struct page *get_first_page(struct zspage *zspage)
I don't think you need __maybe_unused with inline.
> +static __maybe_unused struct zsdesc *get_first_zsdesc(struct zspage *zspage)
> +{
> + struct zsdesc *first_zsdesc = zspage->first_zsdesc;
> +
> + VM_BUG_ON_PAGE(!is_first_zsdesc(first_zsdesc), zsdesc_page(first_zsdesc));
Do we want a VM_BUG_ON_ZSDESC?
next prev parent reply other threads:[~2023-12-04 3:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 10:12 [RFC PATCH v3 00/21] mm/zsmalloc: Split zsdesc from struct page Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 01/21] mm/zsmalloc: create new struct zsdesc Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 02/21] mm/zsmalloc: add utility functions for zsdesc Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 03/21] mm/zsmalloc: replace first_page to first_zsdesc in struct zspage Hyeonggon Yoo
2023-12-01 19:23 ` Minchan Kim
2023-12-03 5:22 ` Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 04/21] mm/zsmalloc: add alternatives of frequently used helper functions Hyeonggon Yoo
2023-12-04 3:45 ` Matthew Wilcox [this message]
2023-12-05 0:35 ` Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 05/21] mm/zsmalloc: convert {try,}lock_zspage() to use zsdesc Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 06/21] mm/zsmalloc: convert __zs_{map,unmap}_object() " Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 07/21] mm/zsmalloc: convert obj_to_location() and its users " Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 08/21] mm/zsmalloc: convert obj_malloc() " Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 09/21] mm/zsmalloc: convert create_page_chain() and its users " Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 10/21] mm/zsmalloc: convert obj_allocated() and related helpers " Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 11/21] mm/zsmalloc: convert init_zspage() " Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 12/21] mm/zsmalloc: convert obj_to_page() and zs_free() " Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 13/21] mm/zsmalloc: convert reset_page() to reset_zsdesc() Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 14/21] mm/zsmalloc: convert zs_page_{isolate,migrate,putback} to use zsdesc Hyeonggon Yoo
2023-12-04 3:32 ` Sergey Senozhatsky
2023-12-05 0:21 ` Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 15/21] mm/zsmalloc: convert __free_zspage() " Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 16/21] mm/zsmalloc: convert location_to_obj() " Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 17/21] mm/zsmalloc: convert migrate_zspage() " Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 18/21] mm/zsmalloc: convert get_zspage() to take zsdesc Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 19/21] mm/zsmalloc: convert SetZsPageMovable() to use zsdesc Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 20/21] mm/zsmalloc: remove now unused helper functions Hyeonggon Yoo
2023-11-30 10:12 ` [RFC PATCH v3 21/21] mm/zsmalloc: convert {get,set}_first_obj_offset() to use zsdesc Hyeonggon Yoo
2023-12-01 19:28 ` [RFC PATCH v3 00/21] mm/zsmalloc: Split zsdesc from struct page Minchan Kim
2023-12-02 4:36 ` Sergey Senozhatsky
2023-12-02 22:46 ` Matthew Wilcox
2023-12-03 5:21 ` Hyeonggon Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW1LZb7w+nICku4W@casper.infradead.org \
--to=willy@infradead.org \
--cc=42.hyeyoo@gmail.com \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=rppt@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox