From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A157FC61D94 for ; Tue, 21 Nov 2023 13:21:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CA816B045F; Tue, 21 Nov 2023 08:21:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1798C6B0464; Tue, 21 Nov 2023 08:21:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 042DA6B0468; Tue, 21 Nov 2023 08:21:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E69146B045F for ; Tue, 21 Nov 2023 08:21:43 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A4EE1402F8 for ; Tue, 21 Nov 2023 13:21:43 +0000 (UTC) X-FDA: 81482023686.05.ACEBB5E Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf28.hostedemail.com (Postfix) with ESMTP id CEDE4C0006 for ; Tue, 21 Nov 2023 13:21:40 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=OMrBIS+d; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf28.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700572901; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eeSboqAjtQLorF8gWd25eGiF12N+F42IRC+rLymJQbI=; b=Ji6Yu3doel9bKehPKxJzbQvdyRXBAPEMdq8V7+cVJwgSUD4BQ3Ky85ELuRjxt/sq98z9hF 6A38sB/YH2VlG6bavRExqtZucIWs82gF8F8XvVJ4i4PUE8y1mizFgbpQ1Y8ntB8PRrYUyH zep7ExSGP+bbPcqhDUFNsDXDipL1VI0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=OMrBIS+d; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf28.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700572901; a=rsa-sha256; cv=none; b=RkqnCAh1KPvFGFwpwmoWlD3A1G0PSq4uEaaeb48wAia8kzW1l3Y69UlCJkfNmmyNXZl/5v +PICIHoWTEkgD/58IplIJabRAWPWxzza5s8S/S3DUOQZn9exN5ZZA2nmdnkQnOFWAEbwAh mdIvjgJD7rnpFFZnBZIy0h3bGBEA8D4= Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3ALCPr6U019674; Tue, 21 Nov 2023 13:21:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=eeSboqAjtQLorF8gWd25eGiF12N+F42IRC+rLymJQbI=; b=OMrBIS+dviaKyEBrdmxY6Y1viDijLzBwV5fA7KA08dUs0W0+rW7W7N+mP7MJvhTkIpIX tJwmrvGMJNC68tYYSFVAObVCXOWgZKMETpyXAmW9OKhwnkqQ/6LUZzc4NPIi7JCplv6k A2g+pYiXmgWQSjUv4acMRCMJrJdUp0FLnSDZ1laC7AP7UD3q6js9JLFSJggOmkhkNPWb Coq7oyqfQ7OoTt0Z/JzZa7kOAJWCl1om/fTyyHT1DDv8pvgvrskXJ+Ud5dEzwkgPZ8vk O3swRPY0Oc3kLPklsjhFtvuR/L4+2khyZb6Axfezt9pAVITRJTnM942c96lhtH6aRO6w 5A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uguhu34r8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 13:21:36 +0000 Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3ALDAvqI015522; Tue, 21 Nov 2023 13:21:36 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uguhu34px-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 13:21:36 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3ALDJAMs019328; Tue, 21 Nov 2023 13:21:34 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3uf7yygyhj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 13:21:34 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3ALDLVFW45547966 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Nov 2023 13:21:31 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AD79020043; Tue, 21 Nov 2023 13:21:28 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D175320040; Tue, 21 Nov 2023 13:21:27 +0000 (GMT) Received: from li-2b55cdcc-350b-11b2-a85c-a78bff51fc11.ibm.com (unknown [9.171.14.211]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 21 Nov 2023 13:21:27 +0000 (GMT) Date: Tue, 21 Nov 2023 14:21:26 +0100 From: Sumanth Korikkar To: David Hildenbrand Cc: Gerald Schaefer , linux-mm , Andrew Morton , Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML Subject: Re: [PATCH 0/8] implement "memmap on memory" feature on s390 Message-ID: References: <20231114180238.1522782-1-sumanthk@linux.ibm.com> <20231117140009.5d8a509c@thinkpad-T15> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: NbTv6UbR9kMb309-jvyhh6MyQEstmKOC X-Proofpoint-ORIG-GUID: GhEUkmm31j9GsomI-sPIdNOidy72mCAQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-21_05,2023-11-21_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=18 mlxlogscore=65 phishscore=0 bulkscore=0 mlxscore=18 adultscore=0 spamscore=18 clxscore=1015 impostorscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311210105 X-Rspamd-Queue-Id: CEDE4C0006 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 87pno7f4a1wikqh5q9zz4zk664b1no4m X-HE-Tag: 1700572900-797465 X-HE-Meta: U2FsdGVkX1/ars9tdR97RYrC/24DCLcYro/1CVSFTHaDzfle5siOD7oQchssM2NykvZPTxZtpeBipXFSxU/rVCqCaoKpIwFHwYQ9LxjxAlzmyimnaen/W9QhVeLuop7ylQAq6u9WTLVuZkwD0q8c5pdC7KzkVTVif7IsARq3X6bXpR/hweQL1pIhx2GPt4nn79ZK98YCRvhvlYpBmYtKZ+sDsqLDd/S2UQLkCV4j5Zsen931p99J1TVLxnhRvMWjgWmCav0QbSiTrg5FKYPVShWA9ZEou2yY4lSgkL0Xr1E0+f9hpNzLQ7GabuTzzq7JhACc1iEByYwqaNRAiOB/rqqiBJO4J8mvFBU+sUbQraj/KN0RYAX02NQU03BA/YZH6TfzLESDpqUxafGCOxxs8KX6kXm+ZQDGzusQmka7vECUhrLo2oZ9HlFUWIC0f4whS8Yld7yRJqkWOiusqEba5DGos2JslADJpMYZHKlXd30LhPidxDlGSeZoF6O8+lyvEUzkm0d2JUO/MBM80CD1dC/5PR24651JIpOnsAR2OXk8x68z4/4TU6tN/OKdssIhoEzRFLX8lpIjMt5s3WjpRRGUMj+X+Z8wdFHi2NmMMZIWwPaTVHwLo5QpQE4TFXISBojESWGSFbhTurWh3L3kQShEIPYL7ON8s1Kc5+t3RxXBkZR1pRaXgnJT+S/1FWlGC0VlK8wakBjo6gXwZ2zWjCeuuGcw2PzwKF9PwELSyBr1KM7ob+kh4dyFjg6Ay/Qg4CFAZuNGj9HEFZLd7t8F0AaneN2Cksu7YzojZf5Qs1so9EhEhF9yCUGwOMm44VOcx077yn4Hwn/6NxbBWPgEDnh8eKDGVMKfvAbYxHRdi9wqK8l1CpQVlSvUPIdZa0tttsbRmvuLK+/PCEg4EgdVKSlK9O5Z+Yh44C4FwUcvUlbbLqEvMUZzeW/63fHPS4zL0w6l4dReQ/L48ESj5Sh bPi0wN6Z brUavYk3pvu5VVTEoxmuTkI7mb0fw77D4o2yzKFdh629etdJAKURJ94MPdbrk+QXfzkwwl5gEZ2zzjsuoB6VvfZ43GxmJZC4hFFNfKjo07KHhZOBuIa5i4ax4gj8jHKipScJCXs/0tVKGSNc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 21, 2023 at 02:13:22PM +0100, Sumanth Korikkar wrote: > Approach 2: > =========== > Shouldnt kasan zero shadow mapping performed first before > accessing/initializing memmap via page_init_poisining()? If that is > true, then it is a problem for all architectures and should could be > fixed like: > > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 7a5fc89a8652..eb3975740537 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1093,6 +1093,7 @@ int mhp_init_memmap_on_memory(unsigned long pfn, unsigned long nr_pages, > if (ret) > return ret; > > + page_init_poison(pfn_to_page(pfn), sizeof(struct page) * nr_pages); > move_pfn_range_to_zone(zone, pfn, nr_pages, NULL, MIGRATE_UNMOVABLE); > > for (i = 0; i < nr_pages; i++) > diff --git a/mm/sparse.c b/mm/sparse.c > index 77d91e565045..4ddf53f52075 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -906,8 +906,11 @@ int __meminit sparse_add_section(int nid, unsigned long start_pfn, > /* > * Poison uninitialized struct pages in order to catch invalid flags > * combinations. > + * For altmap, do this later when onlining the memory, as it might > + * not be accessible at this point. > */ > - page_init_poison(memmap, sizeof(struct page) * nr_pages); > + if (!altmap) > + page_init_poison(memmap, sizeof(struct page) * nr_pages); > > ms = __nr_to_section(section_nr); > set_section_nid(section_nr, nid); > > > > Also, if this approach is taken, should page_init_poison() be performed > with cond_resched() as mentioned in commit d33695b16a9f > ("mm/memory_hotplug: poison memmap in remove_pfn_range_from_zone()") ? Sorry, wrong commit id. should page_init_poison() be performed with cond_resched() as mentioned in Commit b7e3debdd040 ("mm/memory_hotplug.c: fix false softlockup during pfn range removal") ? Thanks > > Opinions? > > Thank you