From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 176C1C61D93 for ; Tue, 21 Nov 2023 11:54:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F4966B03C7; Tue, 21 Nov 2023 06:54:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A3BC6B03E6; Tue, 21 Nov 2023 06:54:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 292CB6B040C; Tue, 21 Nov 2023 06:54:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 19A2E6B03C7 for ; Tue, 21 Nov 2023 06:54:47 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D9E61C0C1B for ; Tue, 21 Nov 2023 11:54:46 +0000 (UTC) X-FDA: 81481804572.05.8AA07C0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf14.hostedemail.com (Postfix) with ESMTP id 260A6100009 for ; Tue, 21 Nov 2023 11:54:44 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf14.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700567684; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rqxL6K+cTlELevNWyEflUlyYLGy0VWXMk7LIi+/+/3g=; b=FM3NtSGlIbySbEFpgha2iRyr9tOKDsXsxWCL16KyH464eNy0G4/ppTPbmPm6vhOnWk+cpa unykqS7GqPuJVAoS5YztUmTI0pwp52qTr1+JqRhVawsB/JIlV9TbaxpNu1B3w7h3QySZpe swfal8R7QdlaYnBSwXCsTXhdjt/YJE0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf14.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700567684; a=rsa-sha256; cv=none; b=YmPbKx/jgwWy0wQMhkdUAxp6QtR5So8oqSJ22iZ0uFcaiIKqyIVH2B7/dikje1DjlEakB+ qfMoHOVMUWuYCeslTP7qW6noW5Mk9ETBLHmQVNDQMIb3Ik6L/BD3m+J3VZ3L+XmYNrQLDc vOB84Up7uZe9X7VHVnD+BPT+mu26PLM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BBD48FEC; Tue, 21 Nov 2023 03:55:29 -0800 (PST) Received: from arm.com (e121798.cambridge.arm.com [10.1.197.44]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DD1103F7A6; Tue, 21 Nov 2023 03:54:38 -0800 (PST) Date: Tue, 21 Nov 2023 11:54:36 +0000 From: Alexandru Elisei To: Peter Collingbourne Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC 20/37] mm: compaction: Reserve metadata storage in compaction_alloc() Message-ID: References: <20230823131350.114942-1-alexandru.elisei@arm.com> <20230823131350.114942-21-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 260A6100009 X-Stat-Signature: ij6ame9w7y7uexff5cz6g6rr6q8huxsk X-HE-Tag: 1700567684-837 X-HE-Meta: U2FsdGVkX1/0JeoQ4590OKa1VEw2dw2/W7xE2GWkA5fg2ePp2Sa01Ph5hQldZwZVB771VcGQxZ2JJEWh77fl1+MJj1qy/aK9fX58FQ3FZ/3HLauoaw5msc2WCWH/Ly+EsNQBvmh37VRDHKhIH9H9YZln3eV+RHgtMovjify3E3stbK0EjYnpKF+tWKpvAWZrqrxIltqSPTp8VQgGy7IghzsWQYpgrPpZTi0a1VjssYUW4j13QT7cqvoN2CD3IH2s70pu08vp23C4yGG0YG5RcyQ4gGmGfw8i3s0sAEY6+bmebBpeg5R7RlE+ap/2UtRg6QVbshMnjz/GeroVVs1l2W4glNvJPm2Lil/14p6979TQ39VTFqrWQSxxM0eLp4lSPJjO9p2bCNnu8wKEqCSA2ugt++88q1sNroH6xCJ2DI+6Cm9vcufjukRgEeUO2IcyUcQPBMCW5iYplOp1OUv/nBPuQ7pdvfOjyDXLOciSGaJj2vifX4O5oBewIEHOg+KBa1lU6P43mWS/TikG82MTYwZrQCo7IjQX0yZivOPaIFLwXSaqVzxx30s/6gBBI36zLRXJ8CldbYT4vFJ0Jqj9hxS6MoA5VqOXXToIBcHnvHR8J26uBmIDmJ1sd661IxvpHszfk+BC4qYmvAeO5rE5uOULJQY9zUxU4Q7I9GpjQgIA9HKxPLVfrwCJ8N4picqf5/ro+sMz4jcxQG02oPGDFmlnaaoIFI8XROWGCLLv7I97C/TGmvx015Z6heuP7NvvMT1KnDtnzf5DMJgBZTnsywo13Fxa+3CvMinKVTLMTxHTZXqTibHgFRlDQnXmk0x4u+ARmvilf5srIgELfp/g0Thstlq640slN+vYwRyLyipFA2UzqyG++03F8c0daZ/uqlKXuU5vkyHqtvkTxvycZ+W3iPIdoZB3tLzyV6knK5w6786LAoUugfT3p7RdOYUmt7gECxxIQLtOr22C5EL 7GUC+Zqy P3Jk2jMUKYgw7E6uBOa6nGbxy3ktNknouUGbYtW7QfpeNVCa928BANbOqDXihV3RUxA6/lDjWVtLeFv22hlJfXnYIE6wJYuYQNIlIvOsoKM9zScXzv4hT9Q5nqPRzu+rR9fnm8YDG+7TvrR7Cr6HMiV/2FrU8f+bq1a2qY+qacmTOhRpMpJVrtnE+t4eg8IblO7LrFey19HTPphCSyjydNxTDsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Peter, On Mon, Nov 20, 2023 at 08:49:32PM -0800, Peter Collingbourne wrote: > Hi Alexandru, > > On Wed, Aug 23, 2023 at 6:16 AM Alexandru Elisei > wrote: > > > > If the source page being migrated has metadata associated with it, make > > sure to reserve the metadata storage when choosing a suitable destination > > page from the free list. > > > > Signed-off-by: Alexandru Elisei > > --- > > mm/compaction.c | 9 +++++++++ > > mm/internal.h | 1 + > > 2 files changed, 10 insertions(+) > > > > diff --git a/mm/compaction.c b/mm/compaction.c > > index cc0139fa0cb0..af2ee3085623 100644 > > --- a/mm/compaction.c > > +++ b/mm/compaction.c > > @@ -570,6 +570,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, > > bool locked = false; > > unsigned long blockpfn = *start_pfn; > > unsigned int order; > > + int ret; > > > > /* Strict mode is for isolation, speed is secondary */ > > if (strict) > > @@ -626,6 +627,11 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, > > > > /* Found a free page, will break it into order-0 pages */ > > order = buddy_order(page); > > + if (metadata_storage_enabled() && cc->reserve_metadata) { > > + ret = reserve_metadata_storage(page, order, cc->gfp_mask); > > At this point the zone lock is held and preemption is disabled, which > makes it invalid to call reserve_metadata_storage. You are correct, I missed that. I dropped reserving tag storage during compaction in the next iteration, so fortunately I unintentionally fixed it. Thanks, Alex > > Peter > > > + if (ret) > > + goto isolate_fail; > > + } > > isolated = __isolate_free_page(page, order); > > if (!isolated) > > break; > > @@ -1757,6 +1763,9 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) > > struct compact_control *cc = (struct compact_control *)data; > > struct folio *dst; > > > > + if (metadata_storage_enabled()) > > + cc->reserve_metadata = folio_has_metadata(src); > > + > > if (list_empty(&cc->freepages)) { > > isolate_freepages(cc); > > > > diff --git a/mm/internal.h b/mm/internal.h > > index d28ac0085f61..046cc264bfbe 100644 > > --- a/mm/internal.h > > +++ b/mm/internal.h > > @@ -492,6 +492,7 @@ struct compact_control { > > */ > > bool alloc_contig; /* alloc_contig_range allocation */ > > bool source_has_metadata; /* source pages have associated metadata */ > > + bool reserve_metadata; > > }; > > > > /* > > -- > > 2.41.0 > >