From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4E18C197A0 for ; Mon, 20 Nov 2023 17:30:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AF606B02A7; Mon, 20 Nov 2023 12:30:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4609B6B02FA; Mon, 20 Nov 2023 12:30:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34DE56B02FC; Mon, 20 Nov 2023 12:30:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 24B0C6B02A7 for ; Mon, 20 Nov 2023 12:30:07 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DC4891A0952 for ; Mon, 20 Nov 2023 17:30:06 +0000 (UTC) X-FDA: 81479020812.27.0F675FB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 3FC32C000C for ; Mon, 20 Nov 2023 17:30:03 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Ej2/zPoa"; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700501405; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wiezd/vwYSqpEHIOZBhRGI+wBEWN8CahQi5f/TV2hvs=; b=5KBXn9QdBPsTVHi+AIejDkYgX9wxJxp0aPaJnK2u2jH+cpOCy7rE4SNymcAU2lbNwvMNmO JR8DY1bnruf6W3eslso51MJz4Bi6dvJKiMwIJUxVqc0HMhPIMiKBEtXXNDA02WOM5OeRA+ +2hbLXJHGoxID5tJSudIVfxJ8GwkDdY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700501405; a=rsa-sha256; cv=none; b=yVcGFVAUCYyHD7pulk9Uu1lPZHoDKKHr8twMTCh0a63juNo3n2JD1ptWj2/0RKseNpkjUX JboKgv4kMlLsMq6DfTB5m0TjYP5E6239QWd+IkoCCElpgj14OheJOCqtsnQ0LMNd6F6V6h UNuR3g7X9NqARoPOUAg+SRt92DnbEb0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Ej2/zPoa"; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wiezd/vwYSqpEHIOZBhRGI+wBEWN8CahQi5f/TV2hvs=; b=Ej2/zPoaX2Qduy+l9cXzF43q44 4UaBhyypySzb1OgmJKpjpVnS50BIS5lNwe1VDb7nQ5mPDhKtw+vXTLzinDMquI1WIrZVUHWuaZBqv EzOs0WIvkkZ866ez+MlaL+ijQgJqT+/zSkHtqejs0HzkTVvlSy2vwhdex9Z0/H4LkAQZqqbpJS5lc xU7FxJnBCjt3wkl7obs3viwnCxQRqJYKX+F/rkCxQOp0tcYtWTx8ZfcbLpK8lVPl9RFraZLawAXgp hBqKPqQ5GtIFiKvnzISMf8iT11Z6hEYaenjAubpjlGzNAyxRIX4ovpfQEztzxo+9UseWN0w1sDqcS or9nfolA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r585t-004oJH-Pr; Mon, 20 Nov 2023 17:29:57 +0000 Date: Mon, 20 Nov 2023 17:29:57 +0000 From: Matthew Wilcox To: Zhiguo Jiang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , opensource.kernel@vivo.com Subject: Re: [PATCH] mm: ALLOC_HIGHATOMIC flag allocation issue Message-ID: References: <20231120023537.1785-1-justinjiang@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231120023537.1785-1-justinjiang@vivo.com> X-Rspamd-Queue-Id: 3FC32C000C X-Rspam-User: X-Stat-Signature: rcmu9wn5gg6x5rfrrs1pcbnpfgn614e3 X-Rspamd-Server: rspam03 X-HE-Tag: 1700501402-371391 X-HE-Meta: U2FsdGVkX18BOUXetvw+nOY/ysJzZjvwrtFleiT4zq9LkAHs/No77I2IlFsP4bIj5qbWhdOFzQvCHy634ibHcTUECSQ1q9c7hbV5RL1X/4XIseHqRLPqT3qil9Mb+xhA8a812S7py+MjULvNx/DuFu/ebPE4ojEg356h5BaiFenzN/bhVGEjbEgWhXcXXxKaUf5pGrEp/MlmJI+bEPmv9UpZ32rIufVXwS/DjuCUC+a+Nlnltg8EqVY/o0ckOX7JFjpmjHWIht+LRzr1Feo8q6DMvzud4MtOwj3kO63hWtpzvmzF2IESJoB3bW9Vkz5ynG8S39qejuR5emH18dMpH6OnCzbC2erpexyDxWoBIveW5Fk1BhraNVS/nen+dExqTg1Z1gZTE9xHQ3bbLV93IoXkV/63rtRmVTp7QHTgLNckB9asg4ysWNawwdmPiJLjv/H8+oxLTlXYjxeGm2y0SqdXxClU+j1KiGYM7II7IRwd6XK66Y+IAuYzn9ogq9SXHCz+fQ56hNSgmq+Yzquz6GYCD5I2a1ZgYHbgximSusKWVQKbSIFrRArSauXDyvLeWCEktvs6xfMWeWUrOKNw+0iMTyr1TX3c6BSUTcutEpVPUXu5l5nWqYeIE8Kcti7Zr4SF+VbwNKXm7q/yZu4ruclEwkpyr83Bug6w2zPBXhtnQM6wUZuJgyfss7yPtj2uJ0C+XZfe1HUAL/Yr6U/c2mvVwTgy4sJ48DdivdC4lqNvlZqOwHD+fHmJOD9+M8gMRtsxD6U44arDYf0i8Lk3c8CfwQ26WiVBKqkuMEKFccFunFrJRg3FvAQLmiwa8cFWyAtaOGqHohKC5WKwtMhPaP7+bT31bFt9LHLAnnbvkV0P0BUTiR5C2ngLRnWFLMXGiRQkf5tJu6gBcfgW6qKGelDKeh+8eYRWpEpl5UHrObtsmwEfOpICqCOVBx9Fle+RYYeM2fF1FZjAFgxN4Oj bH7jXAzd rRd7bNVup4q4CnbiQkkrEpSksscjEskIkLKzdZ2+4zmKUOdlNbNt+jyodggk5dK4m3lKEWRV/jfKKBZB48BR0Xv+Oi3zi5nUgundCYz0EYDkh1anrkNp5mPnzL3Yki5UtPk7Bx0IhQFWPfPiYspeZe+7Mx66DijT3cPFCexe4kuHFOQ0goPTJncnTYQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 20, 2023 at 10:35:36AM +0800, Zhiguo Jiang wrote: > + /* > + * If pcplist is empty and alloc_flags is with ALLOC_HIGHATOMIC, > + * it should alloc from buddy highatomic migrate freelist firstly > + * to ensure quick and successful allocation. Assuming that all the serious question shave been dealt with, let's fix the less important problems ... * If pcplist is empty and alloc_flags contains * ALLOC_HIGHATOMIC, alloc from buddy highatomic * freelist first. > @@ -2918,7 +2927,7 @@ static inline > struct page *rmqueue(struct zone *preferred_zone, > struct zone *zone, unsigned int order, > gfp_t gfp_flags, unsigned int alloc_flags, > - int migratetype) > + int migratetype, bool *highatomc_allocation) bool *highatomic > + /* > + * The high-order atomic allocation pageblock reserved conditions: > + * > + * If the high-order atomic allocation page is alloced from pcplist, > + * the highatomic pageblock does not need to be reserved, which can > + * void to migrate an increasing number of pages into buddy * avoid migrating an increasing number of pages into buddy > + * MIGRATE_HIGHATOMIC freelist and lead to an increasing risk of "increased" > + * allocation failure on other buddy migrate freelists. > + * > + * If the high-order atomic allocation page is alloced from buddy "allocated" > @@ -3208,6 +3234,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags, > struct pglist_data *last_pgdat = NULL; > bool last_pgdat_dirty_ok = false; > bool no_fallback; > + bool highatomc_allocation = false; Again, just call this 'highatomic'.