From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B99EEC54E76 for ; Mon, 20 Nov 2023 09:39:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 181B56B0429; Mon, 20 Nov 2023 04:39:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 131FB6B042B; Mon, 20 Nov 2023 04:39:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3D896B042D; Mon, 20 Nov 2023 04:39:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E289D6B0429 for ; Mon, 20 Nov 2023 04:39:50 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AA09814010C for ; Mon, 20 Nov 2023 09:39:50 +0000 (UTC) X-FDA: 81477835740.05.9A03721 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf17.hostedemail.com (Postfix) with ESMTP id 56CE74000B for ; Mon, 20 Nov 2023 09:39:48 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=etwpbxU6; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf17.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700473188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+CHgsTGKnTpbF8MedKWJQOq6ykdOdu6WVq7LnYx1a7Q=; b=xaWaLxtl/aP2+CLDbsO5n5RHO4T8tYN/vIQ7sjntKPrjJyiNi1DnISCrnd8G/wBlO8VU5B 4w9TIXFn1wsJTKeV9F+MROECZyIMr2Eir6CXamigTyF3V2K53fZM0fGN2j+FeJVZjHg8Jy 2ZaFLpD1YGdb/RQ4B1KsJxFmng0/v0A= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=etwpbxU6; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf17.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700473188; a=rsa-sha256; cv=none; b=xaXqgCe4BexmfcC7V6C9D0zWxT4742gDkOkotxnbwpxDPVkXJWpsz37N/k0NGyqhy6fptr +5MspassWtHKKLLBwwXQ2zcdeeXbK+sy5wRnAqjXEvm+RbFxWakHEO4+Fq/8VbMdpSZLcG WKTB4svn2y9nc1N55kJuyB+a5Kthz2M= Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AK9MbmM022686; Mon, 20 Nov 2023 09:39:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=+CHgsTGKnTpbF8MedKWJQOq6ykdOdu6WVq7LnYx1a7Q=; b=etwpbxU6zp6AgOTdX8UqfPg8zF7yyYh1SdvY1wMGVkOa3BpOjCMwXSorJSofrxedgpN4 3/EBpWJGK34s6UYJNl3k0mqIZhvOiid4ApMu62x5+8h7ddY3DUf7Wa+t7MM3Sn8wsIc6 xd+4iZPqDe4++tUGqsTuob+VKuhPs4m8KV9twFmzKld29P89yQPmeAMcM3hMcd8qwyDZ bSZ0S32Xqkxt2ncCGX94W5RM0WLUd6YlrYEBMLkdCjtB2Wdwg1l/lYG7LGNDFsYWyN5V sIY3LzVtoVgDRjGUD+7m4rWdGeW6/y119IKe3QSFZxcKn5EZQoG2FUdWay7JtYyeQj+R GA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ug4rv0g4x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Nov 2023 09:39:44 +0000 Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AK9OiqB029893; Mon, 20 Nov 2023 09:39:44 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ug4rv0g08-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Nov 2023 09:39:44 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3AK7KM1o008909; Mon, 20 Nov 2023 09:39:40 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3uf7yy8e4g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Nov 2023 09:39:40 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3AK9dbaq39846224 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Nov 2023 09:39:37 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0C87D2004B; Mon, 20 Nov 2023 09:39:37 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7E20B20040; Mon, 20 Nov 2023 09:39:36 +0000 (GMT) Received: from li-2b55cdcc-350b-11b2-a85c-a78bff51fc11.ibm.com (unknown [9.171.34.73]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 20 Nov 2023 09:39:36 +0000 (GMT) Date: Mon, 20 Nov 2023 10:39:35 +0100 From: Sumanth Korikkar To: David Hildenbrand Cc: linux-mm , Andrew Morton , Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML Subject: Re: [PATCH 3/3] mm: use vmem_altmap code without CONFIG_ZONE_DEVICE Message-ID: References: <20231120072317.3169630-1-sumanthk@linux.ibm.com> <20231120072317.3169630-4-sumanthk@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Vcg2raKPY6RueXma9dVQd7y2O_sVaTn3 X-Proofpoint-ORIG-GUID: 9GXehSnBmUTDmVh2u1Uvqyx1pa7sbyHS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-20_07,2023-11-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 mlxlogscore=333 malwarescore=0 impostorscore=0 priorityscore=1501 suspectscore=0 spamscore=0 bulkscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311200064 X-Rspamd-Queue-Id: 56CE74000B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 6gcpiceuzi6qp45maf7r4f9jwhwwphcp X-HE-Tag: 1700473188-876359 X-HE-Meta: U2FsdGVkX1/jlk0dErC0YGdWr7xJz0wFj+XP4HYJgBZNEaAbwZz//sIbJdYqeb5v9v6dHAPuLAjHAOxpQRSkt0UMK6cXonRcVEVXECqvdhLvI7rjZcgQBMzp4PdAqwMPZiTbbdJtlMSxNw76eRBCheadXc7c3P/qjHW7yNts6CHGiiwldDaBZfFpCTn6msC0MpDoAgne9z0yjRWrnxRqf8GPdNy/yfnJDZMQcl7fYpm8INrfQGCksJAI2if79xbzgpFUmzUeqjv4Yc7nv6VZnz2u6lde0IwJbplcqaATlfCII1+YyRLtsbwIlIvRIkQkq2klPwaVuzJ8RZD19twv7W5G1x6nmf8u2SqzObGFR97A4f7rkIbbveYXsHB/4AHg2g2lwLke8GYhOtqQcseBPVA1HNGC9B6mAWCb6U6JM5nA6fd8YoQ5ICLbV5S0fXM44x9fup3DdCRN04C54hpD3yAMCBSXVYpN93fyPNL/6gh2Y67xfnDPB24kPvXDZRRcOaFpyS4lfNqHWiQuPaJSLt92YZfF7VBjHaIDkEFJGGcU5tg6nl+/p0vQlg2yHs7f9ZgudXH5WwGMKiFBdQrROMWQd1sLcNrUFJ/QYpSho4+Q8vyEMELyCB21Oz4g0eU8dfIC66sPpXeD3sCsqNwIT6WZJNca1BnH5lWhAVuCAAXZuWWPJreWBfHOJRed0qxOOgvL30CfNNZgeIkmTH2GEzREdkF3SFuIVaANab0ML7b0uNUwEHW0d7YmnVVbmgHZ1FFz0MqyBUOiKKMcz8gJbWX0SurhhLhqA5kxcXhrrIQOhrJX6Bl9GWcG2/4Xc+uBh9os1tcjAJMMpS/twPdCxS+MgUQRuSNcaANgPdv8y7srbO0V472ZIVCWuXXXj5H6l4ou76SlvO7GDcjsBuG1L3RSAwOOnNOJ5cBBjKcLdwjOg+ZfhrpmiM3EZaT30kEG7SxGeN0JDpgLX14Z462 lyfiFSN3 dL1y1SRZ7apfItoZc4Mh+t5CpikZfYS8TVEn1AWWJugSgOB6/a3qGxBeJF/Ye0EaBb+ElPueRJ4fkdEK3cV1GB4Wefgz2oL4wmApTtraQZk1ikmc4Nji4GTVREDuXAEm2AI6OASQ1wIRFUAgxrRDkJil5/I4BVDb01RnpRV7endlPfo+oPiw8FR9Cmg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000026, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 20, 2023 at 10:01:13AM +0100, David Hildenbrand wrote: > > What speaks against just moving them to the header instead? They surely are > tiny ... > I followed the previous convention. Sure, will make it inline and put those definitions in header file. Thanks