From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B8F4C54FB9 for ; Sun, 19 Nov 2023 21:12:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE6446B020E; Sun, 19 Nov 2023 16:12:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A96D26B028D; Sun, 19 Nov 2023 16:12:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B5AF6B02B1; Sun, 19 Nov 2023 16:12:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8BB826B020E for ; Sun, 19 Nov 2023 16:12:23 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 61C241A048C for ; Sun, 19 Nov 2023 21:12:23 +0000 (UTC) X-FDA: 81475952166.14.7762C6A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id BD1FB1A000C for ; Sun, 19 Nov 2023 21:12:21 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PhRXGdul; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700428341; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4yGkltmM8hvQ5Y+Wmub3JiXWUCK7R5wHysZVImu3ung=; b=da8eumtYSURoKKr5owYDSemNbBiyuhHzXUfsAxnY7zI7eyN8LZECeMnTDEAWIzFScOLE0I 8flGRm+xYt0TKFfdsjBt8ltBuzaYCei3KLHdnLz/Slx76l2bcZ1u0+R0MQ0Nxh7S/Ckt1c rgTTpXMrKKN70+tY8xALQhb7Hy74MJs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700428341; a=rsa-sha256; cv=none; b=xoAr+AQ5v+q2+aTveJTn6wp8wbMEg4sq2Ww7J8lSWEHMeziYhaZWGIUyOt+WObaL02Hp0J iOmaPDEOA9LtpFq2kUNUxKajbJjr1SxS7SlMS7QzulDkyBY5XEwfRf7HiYT5A5hh6c5UbU yIA8OTEVjBCOM5eSUgVPV1tJT6Pp0Ms= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PhRXGdul; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4yGkltmM8hvQ5Y+Wmub3JiXWUCK7R5wHysZVImu3ung=; b=PhRXGdulG6GFPYCO+YRKK+9dp1 ojal+WbNlTGQxgQKxVrvQ+5t2coN3Q56h7HHJPCDxEUKUs6USZF/ICEIfM4697dc1A6Thhd1OiB+y UyX7H5Y+7wJcrEcrQyPz6hyLqkLLXCTVP4vOiRL15FbBSqVorMRwVPFRXk6Gwc9zPIyNKD4so2xtG UBy3klULNmlxbdR6lV8LO5HgGfNlKVAKn6JS7dZyqtQmUg9bh+yVUk8ado/hOc+ohAUXW1gH+Hcmc T6VeiWFq+srCpYWt87bB6WFbj098kZEnnsg2NMXe7kmDJTHWEnHi6NLkM+fuvYRkS455+yX9MVzOA /tNCEzGg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r4p5S-00342X-32; Sun, 19 Nov 2023 21:12:14 +0000 Date: Sun, 19 Nov 2023 21:12:14 +0000 From: Matthew Wilcox To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , David Hildenbrand , Hugh Dickins , Johannes Weiner , Michal Hocko , linux-kernel@vger.kernel.org Subject: Re: [PATCH 16/24] mm/swap: reduce scope of get_swap_device in swapin path Message-ID: References: <20231119194740.94101-1-ryncsn@gmail.com> <20231119194740.94101-17-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231119194740.94101-17-ryncsn@gmail.com> X-Stat-Signature: jtqs8dkuffcaotfkb3o7cxmf85bxr36z X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BD1FB1A000C X-Rspam-User: X-HE-Tag: 1700428341-480033 X-HE-Meta: U2FsdGVkX1+BwatvVZilqOhZ5vHm7R1A/sDw34xgWgU6amkejvmpXkE549LKpFh4iVstRApse+Otr49ilWKuQFotBhdOtCQFqN7YHSpiutJU0R6m89Kn/QgZbFqCwwotQUoCMYnP+Xem6UnNDTGGMiu7Lg9jVa3JwiG8zr26c+hPLLxmCJeuYQk9IHEjSeM8GVnQHP07CJyh8ONnLFGTnjkAOQ3IxY6k02HSHNtITTqyDnBGZycjS7n37mN6aJk2TX8LmsHEQqryWaFB+yxGU01NAwwVl8cX6vLttpWXWX91JE6qiD9zGZxPgvF9u1+yfLp2+W9XRt/C78IULeroYowdSdRhLRhrHiKLfKksQRmzJY3HsKG5RRToTKoInfsJDj+qtZzXthARoOZXPlHgdIz3ovmH861CugUr7au+TkWQkFqh/39enx7DWwqnVNcDjOFybFh9cDTFgIcOzWT3FMWZtP89hAwhWwELxUpK/2n6Lxt3tuRPZUoi3Sbu2LcehsaSjyu7gdvTJEKguvLC7EeYAJyIq0FeO029KghlIVaBRrSZyv9/zGsX1F8MbYXbveGovBXz478gZIJkFcS4Z95hQn1dHchZB6cCHVDyH2DK8lTl/5iDniDwgnnW0lvPgLunKyn9gtrzBum7kiLA9Qr7V3I85bYNQpMJNsJztr3ZLHRKuI9nIwSXcPEy4jRYKvil2c7cwnjiNjO7dkPMNnyG7UY5+bGuF1Phs1mrwJ94jwL/yke/2gepKdPtJ62l7GG4/29pkonkv1LmE0JXRtSV0naPzE+ohtb9oZ9Xq3ZrZst6Xa9wuShW3Ll2QslwhR5AjtbWP5wTcc22lfrFfqTyS1xa+Qf32lPtFe+VrWguUox62bLSURioIjBiMyAmX1WMsVuhZFwdTaShDWIXI8VScqGHYeeiveePBKLtsX9p2PwL2cRypWGMaeYkS13ugDPMbcuo2KrFLxa4NG6 RJOlnVcs CP/17mgLBlFHDVj/EKeEoS5EOg9Y+xpfUbAVevqswQsx6nCwJvBgDcZDQJuNGGnitszCaif9E3yMFMP4/ZkhP7zvWC15ZrcYwCo0u3ibRHZi6RBLRTUUMPnZ2GdSrqy+GmdiwKU7UqY/53SXRBsLk0IzMDDQabj2IMK2bLSCAn0V1saSoXvkxVS/7yw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 20, 2023 at 03:47:32AM +0800, Kairui Song wrote: > page = swapin_readahead(entry, GFP_HIGHUSER_MOVABLE, > vmf, &cache_result); > - if (page) { > + if (PTR_ERR(page) == -EBUSY) { if (page == ERR_PTR(-EBUSY)) {