From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FC11C54FB9 for ; Sun, 19 Nov 2023 21:00:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8E0D6B03B4; Sun, 19 Nov 2023 16:00:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E3D756B03BE; Sun, 19 Nov 2023 16:00:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2C366B03CA; Sun, 19 Nov 2023 16:00:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C504C6B03B4 for ; Sun, 19 Nov 2023 16:00:20 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 88F911607E0 for ; Sun, 19 Nov 2023 21:00:20 +0000 (UTC) X-FDA: 81475921800.03.48C2338 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id D0F95140031 for ; Sun, 19 Nov 2023 21:00:18 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=L7I4eUqh; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700427618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ewgYBVW+Iax6CqzUrSGGjtpzlAkAA8ZMF03lgMpKaIM=; b=icwO0a3T2fmbBq/1o1/s45eO40m7q7ILvch1nORrLT/oNJm9yNn6NIHvfK5DyuQFhYCrrQ xeETM5sEkVjD++B//hT1it08SbVKbFMPB2r5sQue+ofgaldhrZWjT34nWq5RQ0/5qu3X7P HRb0OTP3p8dKxgRJ7jq8wfsvgccMxSY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=L7I4eUqh; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700427618; a=rsa-sha256; cv=none; b=gmv797ePFf37BVFlTt9JMg9cnf27lyTL45kXaLH9dOJx+l0Ot8oYRGXAvONt5ZXyOki9gX KNxnsAW83VuNhwcoBZ1OeR+xPaD4qQElD71SZzin77LdKGV1CubMl8MLJo8EOx8aC6sVG4 7zNdHwQuJ/CseRqflikneLcTe51nD4Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ewgYBVW+Iax6CqzUrSGGjtpzlAkAA8ZMF03lgMpKaIM=; b=L7I4eUqhsu4ZZE1SCodP+CJCa5 lYRdOOhI8LmR0CCIKa3wU5+7oLM/bhCZcjFmXsE2EfXVh5IrKBhX+la7+E9OeSncmFHwfi6/5jrJF M4ayq94GPqv3jN2o6ub8xvP3YV3p/v1N6H6fhVNDsNQvNcwWG++4ngyUKPQtJft61+hp6P4PcZXD/ M1r/cPpOU+6yynFEkLk5FXGmolrrwfxMKQssZIULatYKHlIy6oIEY0fgrud9V8vigjqGNTAnQmu91 26WPxjLWmrrz99hjnHnjkMe7wAl2aYvKkb/VuGRHZunrgggQMzkBX9EVYZAyeODiVaNNNRBMSxxfL BQasstSw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r4otl-0032p2-JP; Sun, 19 Nov 2023 21:00:09 +0000 Date: Sun, 19 Nov 2023 21:00:09 +0000 From: Matthew Wilcox To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , David Hildenbrand , Hugh Dickins , Johannes Weiner , Michal Hocko , linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/24] mm/swap: move no readahead swapin code to a stand alone helper Message-ID: References: <20231119194740.94101-1-ryncsn@gmail.com> <20231119194740.94101-4-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231119194740.94101-4-ryncsn@gmail.com> X-Rspamd-Queue-Id: D0F95140031 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 6ips3s6d18zeoputz6buy5gup9rpnfry X-HE-Tag: 1700427618-98669 X-HE-Meta: U2FsdGVkX19cH/kGJs2kZKzbmGCSC9yAdtSXokYR4v8zPpMp2u0jh64hivRFdskahBJDUeFIxSLPJui1QMk8QBRyXjpOsPC0EvbYR+h+x88Yle7nZ+0ADU0jXfmIQzzolmmvtJwTuQaOPYHXARKATDqg2heR/ZdO//YIzPGO76ayen+/EGjx98ZNGzz77DYbflol0DNYsX/nSnVg0A0pZO0YOGeFFFIfzBzf1z/CgqUf5tIWQroeJoEAORNeTVSOJFINNea0RRm8XHRCWX1G4+H1CFVg85EnOsMgzCbUPSsAI0ha4KPrDdaJ8+Tx5ER9hA6IZ2XuheJSyVfIWveH1Z/vBCxC7u+nI75GqL+7Zw7dvdp+qxH96nrLOWuY3kYcImIrrE6SgR7dg4kD88/ndqA7kOBh/vul7r2YmB3SQzy8rwgxR9LjzGrm42kRqp60BFWshBvfxqJhUr/JJHKWaTLvHCfgpA5AhvAjJtgpl4lf58bxud7vJMTrprfl5xDw071n1WhvmTHgL/jp3qyyzSBHu3ApsrQBdNUxzeZOVUj90DHulFhQ8BiwcYx7fcB/TZXo02XdT9AoMlPjGOFzPjRBjQjsJEIHbFgC4aJXoSPJMeSZFrTQ9xPFlQDS63evW10NMGZCj3sw4pMf/IkOrooNfcUCLNqLC628S1vWhCKCveIH6w7rASlm2W5eEmwSbE0P8wzSBq+YPNfoWwSfgQ2shKZ+b3Io2n5kEXGX6/8KRUashS6cYZKi7qjGaIVi9Wh9R0qE3Mn4LpYY5HC+Rkfn4tNLMYTxHKJkxGaCb9F82Q4dMvXCdi5VCXK+b894x4Agd3H5n0fXx0JmEsqLeMshQi3+RvbEtabAdneA3z2zn0Mc4DZa13oDlsVmAaGeqhXhks9ohMK19ldazDTCs0XjXk3AIKxBnBN2obtn2Wolz3I3u++JG7Dj97JKDP6MCKgjMvqUVg4S7XTwpEO 28ksaScc lELCdzGk4Owhn/u64FTZMAlKVQQ3nOi+/2vG4drECGKO9w0GOS+u2rqemx8QH4c/j3oKFeYdSEbbe+1OC2mihXCplwBgPqy6Kgf5tNVyxJL2zWRBwW6tBxpLzOZNEd3n2hQlkUvgyIXNNXUo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 20, 2023 at 03:47:19AM +0800, Kairui Song wrote: > + /* skip swapcache and readahead */ > + page = swapin_no_readahead(entry, GFP_HIGHUSER_MOVABLE, > + vmf); > + if (page) > + folio = page_folio(page); I think this should rather be: folio = swapin_no_readahead(entry, GFP_HIGHUSER_MOVABLE, vma); page = &folio->page; and have swapin_no_readahead() work entirely in terms of folios.