From: Matthew Wilcox <willy@infradead.org>
To: Barry Song <21cnbao@gmail.com>
Cc: David Hildenbrand <david@redhat.com>,
steven.price@arm.com, akpm@linux-foundation.org,
ryan.roberts@arm.com, catalin.marinas@arm.com, will@kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mhocko@suse.com, shy828301@gmail.com, v-songbaohua@oppo.com,
wangkefeng.wang@huawei.com, xiang@kernel.org,
ying.huang@intel.com, yuzhao@google.com
Subject: Re: [RFC V3 PATCH] arm64: mm: swap: save and restore mte tags for large folios
Date: Fri, 17 Nov 2023 19:36:57 +0000 [thread overview]
Message-ID: <ZVfA2Z8XyD3qtTMZ@casper.infradead.org> (raw)
In-Reply-To: <CAGsJ_4wsWzhosZJWegOb8ggoON3KdiH1mO-8mFZd7kWcn6diuw@mail.gmail.com>
On Fri, Nov 17, 2023 at 07:47:00AM +0800, Barry Song wrote:
> This has been discussed. Steven, Ryan and I all don't think this is a good
> option. in case we have a large folio with 16 basepages, as do_swap_page
> can only map one base page for each page fault, that means we have
> to restore 16(tags we restore in each page fault) * 16(the times of page faults)
> for this large folio.
That doesn't seem all that hard to fix? Call set_ptes() instead of
set_pte_at(). The biggest thing, I guess, is making sure that all
the PTEs you're going to set up are still pte_none().
next prev parent reply other threads:[~2023-11-17 19:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 1:43 Barry Song
2023-11-15 14:40 ` Steven Price
2023-11-15 15:16 ` David Hildenbrand
2023-11-15 20:49 ` Barry Song
2023-11-15 22:45 ` Yang Shi
2023-11-16 9:36 ` David Hildenbrand
2023-11-16 23:47 ` Barry Song
2023-11-17 0:15 ` Barry Song
2023-11-17 11:28 ` David Hildenbrand
2023-11-17 18:41 ` Barry Song
2023-11-20 9:11 ` David Hildenbrand
2023-11-20 10:57 ` Ryan Roberts
2023-11-20 14:50 ` Steven Price
2023-11-24 1:35 ` Barry Song
2023-11-24 8:55 ` David Hildenbrand
2023-11-24 9:01 ` Ryan Roberts
2023-11-24 9:55 ` Steven Price
2023-11-24 18:14 ` Barry Song
2023-11-27 11:56 ` Ryan Roberts
2023-11-27 12:01 ` David Hildenbrand
2023-11-27 12:14 ` Ryan Roberts
2023-11-27 14:16 ` David Hildenbrand
2023-11-27 14:52 ` Ryan Roberts
2023-11-27 15:42 ` David Hildenbrand
2023-12-07 3:22 ` Barry Song
2023-12-07 10:03 ` David Hildenbrand
2023-12-08 0:00 ` Barry Song
2023-11-17 11:25 ` David Hildenbrand
2023-11-17 19:36 ` Matthew Wilcox [this message]
2023-11-17 20:36 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVfA2Z8XyD3qtTMZ@casper.infradead.org \
--to=willy@infradead.org \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=ryan.roberts@arm.com \
--cc=shy828301@gmail.com \
--cc=steven.price@arm.com \
--cc=v-songbaohua@oppo.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=xiang@kernel.org \
--cc=ying.huang@intel.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox